Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-30 Thread Herbert Xu
On Wed, May 31, 2006 at 12:11:59AM +1200, Michal Ludvig wrote: > > Just in case you'd change your mind about $SUBJ - attached is an updated > version with that applies on top of the digest-speed. > Just in case... ;-)) Sure, I'll keep this in mind. I'm certainly going to revisit this module at so

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-30 Thread Michal Ludvig
Herbert Xu wrote: > Patch applied. Thank you very much Michal. Just in case you'd change your mind about $SUBJ - attached is an updated version with that applies on top of the digest-speed. Just in case... ;-)) Michal The interface to tcrypt.ko was until now driven by magic code numbers with

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-30 Thread Herbert Xu
On Tue, May 30, 2006 at 04:09:42PM +1200, Michal Ludvig wrote: > > Attached. Patch applied. Thank you very much Michal. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-29 Thread Michal Ludvig
Herbert Xu wrote: > On Mon, May 29, 2006 at 09:37:35PM +1200, Michal Ludvig wrote: > >> BTW how about the digest-speed thing? > > That's fine by me if you can rebase it on the current code set. Attached. Michal This patch adds speed tests (benchmarks) for digest algorithms. Tests are run with d

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-29 Thread Herbert Xu
On Mon, May 29, 2006 at 09:37:35PM +1200, Michal Ludvig wrote: > > This is a testing module only. Who use it? I guess just developers when > working on crypto stuff - they (we) won't be scaried by the ever growing > tcrypt.[ch] I guess. The question is really who has to maintain it :) > Even

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-29 Thread Michal Ludvig
Herbert Xu wrote: Hi Michal: On Thu, May 25, 2006 at 09:27:20AM +1200, Michal Ludvig wrote: It's not a rocket science. It does, however, introduce backward incompatibility. But I don't think that would be a problem - it's a module only for testing anyway. I like the concept. But I think you

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-29 Thread Herbert Xu
Hi Michal: On Thu, May 25, 2006 at 09:27:20AM +1200, Michal Ludvig wrote: > > It's not a rocket science. It does, however, introduce backward > incompatibility. But I don't think that would be a problem - it's a > module only for testing anyway. I like the concept. But I think you should be mor

[CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-24 Thread Michal Ludvig
Hi Herbert, the attached patch makes the use of tcrypt.ko more convenient. Tests can now be called with algorithm name as a parameter. That frees us from reading the source and looking for the correct constant every time one wants to use the module. It's not a rocket science. It does, however, in