Re: [CRYPTO] blkcipher: Add IV generation

2007-10-04 Thread Herbert Xu
On Sat, Sep 29, 2007 at 09:36:48PM +0800, Herbert Xu wrote: > > [CRYPTO] blkcipher: Remove alignment restriction on block size > > Previously we assumed for convenience that the block size is a multiple of > the algorithm's required alignment. With the pending addition of CTR this > will no long

Re: [CRYPTO] blkcipher: Add IV generation

2007-10-01 Thread Herbert Xu
Joy Latten <[EMAIL PROTECTED]> wrote: > > So, I am thinking CTR and some of the other modes, > other than CBC, that use an IV will fail with this > change since they currently don't have an alg->geniv... > should they have a geniv similar to that of CBC, which > is gotten randomly? The only oth

Re: [CRYPTO] blkcipher: Add IV generation

2007-10-01 Thread Joy Latten
{ @@ -434,8 +450,16 @@ static int crypto_init_blkcipher_ops_async(struct crypto_tfm *tfm) crt->setkey = async_setkey; crt->encrypt = async_encrypt; crt->decrypt = async_decrypt; + crt->geniv = async_geniv; crt->ivsize = alg->ivsize; + if (!alg->geniv)

Re: [CRYPTO] blkcipher: Add IV generation

2007-09-29 Thread Herbert Xu
Hi: [CRYPTO] blkcipher: Remove alignment restriction on block size Previously we assumed for convenience that the block size is a multiple of the algorithm's required alignment. With the pending addition of CTR this will no longer be the case as the block size will be 1 due to it being a stream

[CRYPTO] blkcipher: Add IV generation

2007-09-29 Thread Herbert Xu
Hi: I've just checked in these patches needed for CTR to function correctly. [CRYPTO] blkcipher: Add IV generation Different cipher block modes may have different requirements for IV generation. Therefore it makes sense to move IV generation into the crypto API instead of having the c