Re: "crypto_hash_setkey" call from atomic context

2015-12-14 Thread Herbert Xu
On Mon, Dec 14, 2015 at 09:53:03AM +0100, Fabrizio Demaria wrote: > In our MPTCP implementation we handled the setkey problem by > pre-allocating a properly aligned key's buffer right after > "crypto_alloc_hash", outside atomic context [1]. Would this workaround > be enough to guarantee that "crypt

Re: "crypto_hash_setkey" call from atomic context

2015-12-14 Thread Fabrizio Demaria
In our MPTCP implementation we handled the setkey problem by pre-allocating a properly aligned key's buffer right after "crypto_alloc_hash", outside atomic context [1]. Would this workaround be enough to guarantee that "crypto_hash_setkey" can be safely called in atomic contexts? Is it always the c

Re: "crypto_hash_setkey" call from atomic context

2015-12-10 Thread Herbert Xu
Fabrizio Demaria wrote: > Hello, > > I am investigating the current usage of kernel crypto-libraries in the > SCTP code, considering to adopt the same crypto framework for the > MPTCP implementation. > > In sm_make_chunk.c, the crypto function "crypto_hash_setkey" is called > in an atomic contex

"crypto_hash_setkey" call from atomic context

2015-12-10 Thread Fabrizio Demaria
Hello, I am investigating the current usage of kernel crypto-libraries in the SCTP code, considering to adopt the same crypto framework for the MPTCP implementation. In sm_make_chunk.c, the crypto function "crypto_hash_setkey" is called in an atomic context, despite the fact that this function CA