[PATCH] crypto: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- crypto/seed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/seed.c b/crypto/seed.c index 5e3bef3a617d..27720140820e 100644 --- a/crypto/seed.c +++ b/crypto/seed.c @@ -322,7 +322,7

[RFC] MAINTAINERS tag for cleanup robot

A difficult part of automating commits is composing the subsystem preamble in the commit log. For the ongoing effort of a fixer producing one or two fixes a release the use of 'treewide:' does not seem appropriate. It would be better if the normal prefix was used. Unfortunately normal is not con

[PATCH] crypto: qat: remove unneeded semicolon

From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/crypto/qat/qat_common/qat_algs.c | 2 +- drivers/crypto/qat/qat_common/qat_asym_algs.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/qat/qat_c

[PATCH] crypto: cavium/nitrox: remove unneeded semicolon

From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/crypto/cavium/nitrox/nitrox_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cavium/nitrox/nitrox_mbx.c b/drivers/crypto/cavium/nitrox/nitrox_mbx.c inde

Subject: [RFC] clang tooling cleanups

This rfc will describe An upcoming treewide cleanup. How clang tooling was used to programatically do the clean up. Solicit opinions on how to generally use clang tooling. The clang warning -Wextra-semi-stmt produces about 10k warnings. Reviewing these, a subset of semicolon after a switch looks s

[PATCH] crypto: atmel-sha: remove unneeded break

From: Tom Rix A break is not needed if it is preceded by a return Signed-off-by: Tom Rix --- drivers/crypto/atmel-sha.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c index 75ccf41a7cb9..0eb6f54e3b66 100644 --- a/drivers/crypto/atmel-

[RFC] treewide: cleanup unreachable breaks

From: Tom Rix This is a upcoming change to clean up a new warning treewide. I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks. clang has a number of useful, new warnings see https://clang.llv

[PATCH] hwrng : cleanup initialization

From: Tom Rix clang static analysis reports this problem intel-rng.c:333:2: warning: Assigned value is garbage or undefined void __iomem *mem = mem; ^ ~~~ Because mem is assigned before it is used, this is not a real problem. But the initialization is strange

[PATCH] crypto: drbg: check blocklen is non zero

From: Tom Rix Clang static analysis reports this error crypto/drbg.c:441:40: warning: Division by zero padlen = (inputlen + sizeof(L_N) + 1) % (drbg_blocklen(drbg)); ~^~~ When drbg_bocklen fails it returns 0. if (

[PATCH] crypto: qat: fix double free in qat_uclo_create_batch_init_list

From: Tom Rix clang static analysis flags this error qat_uclo.c:297:3: warning: Attempt to free released memory [unix.Malloc] kfree(*init_tab_base); ^ When input *init_tab_base is null, the function allocates memory for the head of the list.