Re: [PATCH] crypto: hisilicon/hpre - delete redundant log

2021-04-02 Thread tanghui20
On 2021/4/2 15:19, Herbert Xu wrote: On Sat, Mar 27, 2021 at 04:32:26PM +0800, Hui Tang wrote: 'hpre_cfg_by_dsm' has checked and printed error path, so it is not necessary at all. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 5 + 1 file changed, 1 insertion(+

Re: [PATCH] crypto: hisilicon - check if debugfs opened

2021-03-30 Thread tanghui20
On 2021/3/30 20:23, Greg KH wrote: On Tue, Mar 30, 2021 at 08:09:46PM +0800, tanghui20 wrote: On 2021/3/28 23:09, Greg KH wrote: On Sat, Mar 27, 2021 at 04:33:00PM +0800, Hui Tang wrote: 'xx_debugfs_init' check if debugfs opened. Signed-off-by: Hui Tang --- drivers/crypto

Re: [PATCH] crypto: hisilicon - check if debugfs opened

2021-03-30 Thread tanghui20
On 2021/3/28 23:09, Greg KH wrote: On Sat, Mar 27, 2021 at 04:33:00PM +0800, Hui Tang wrote: 'xx_debugfs_init' check if debugfs opened. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 5 - drivers/crypto/hisilicon/qm.c | 3 +++ drivers/crypto/hisilic

Re: [PATCH -next] crypto: hisilicon/hpre - fix build error without CONFIG_CRYPTO_ECDH

2021-03-24 Thread tanghui20
Thinks, there is a similar patch to yours that was send in advance: https://www.spinics.net/lists/linux-crypto/msg54238.html On 2021/3/24 22:42, 'Wei Yongjun wrote: From: Wei Yongjun GCC reports build error as following: x86_64-linux-gnu-ld: drivers/crypto/hisilicon/hpre/hpre_crypto.o: in fun

Re: [PATCH -next] crypto: hisilicon/hpre: fix link error

2021-03-23 Thread tanghui20
There is a patch similar to yours that was send in advance, as follows: https://www.spinics.net/lists/linux-crypto/msg54238.html On 2021/3/23 15:27, Yang Yingliang wrote: Fix the follow link error by select config CRYPTO_ECC and CRYPTO_ECDH. ERROR: modpost: "ecc_get_curve25519" [drivers/crypto