On 2021/3/26 17:14, Herbert Xu wrote:
On Fri, Mar 19, 2021 at 03:33:07PM +0800, Yang Shen wrote:
+const struct hisi_zip_sqe_ops hisi_zip_ops_v2 = {
+ .sqe_type = 0x3,
+ .fill_addr = hisi_zip_fill_addr,
+ .fill_buf_size = hisi_zip_fill_buf
On 2020/9/4 15:40, Herbert Xu wrote:
On Wed, Aug 26, 2020 at 04:56:40PM +0800, shenyang (M) wrote:
@@ -514,13 +514,16 @@ static int hisi_zip_core_debug_init(struct hisi_qm *qm)
struct debugfs_regset32 *regset;
struct dentry *tmp_d;
char buf[HZIP_BUF_SIZE
any comment?
Thanks,
Yang
On 2020/8/24 11:11, Yang Shen wrote:
This patchset make some clean up:
patch 1:remove useless parameters
patch 4:replace 'sprintf' with 'scnprintf'
patch 7:fix static check warning
and the rest patch fix some coding style
Resend this patch series because it depends on
On 2020/8/24 16:29, David Laight wrote:
From: Yang Shen
Sent: 24 August 2020 04:12
Replace 'sprintf' with 'scnprintf' to avoid overrun.
Signed-off-by: Yang Shen
Reviewed-by: Zhou Wang
---
drivers/crypto/hisilicon/zip/zip_main.c | 11 +++
1 file changed, 7 insertions(+), 4 deletio
On 2020/8/6 15:23, Markus Elfring wrote:
Would you become interested to look if any other software components
would be similarly affected?
Yeah, I'll check the rest and fix if any and send those in a
clean up patch.
Thanks,
Yang
On 2020/8/5 14:04, Markus Elfring wrote:
Thanks for your review. There is only one error branch need to do
something uninit. So I think the jump is not necessary and will
affect code reading.:)
How does this concern fit to the Linux coding style?
https://git.kernel.org/pub/scm/linux/kernel/g
On 2020/8/5 2:34, Markus Elfring wrote:
…
+++ b/drivers/crypto/hisilicon/qm.c
@@ -1420,16 +1420,17 @@ static int qm_dbg_help(struct hisi_qm *qm, char *s)
…
+ s_tmp = s;
presult = strsep(&s, " ");
if (!presult) {
- kfree(s);
+ kfree(s_tmp);
On 2020/7/31 16:28, Herbert Xu wrote:
On Sat, Jul 25, 2020 at 02:06:46PM +0800, Yang Shen wrote:
This patchset fix some bug:
patch 1:clear the debug registers when remove driver
patch 2:intercept invalid input when using decompress
patch 3:replace the return value '-EBUSY' with '-EAGAIN' when
On 2020/7/31 16:20, Herbert Xu wrote:
On Fri, Jul 31, 2020 at 04:15:41PM +0800, shenyang (M) wrote:
Here if the user alloc a tfm of the algorithm the driver registers,
the function 'hisi_qm_wait_task_finish' which be added in patch 10 will
stop to remove the driver until the tf
On 2020/7/31 16:12, Herbert Xu wrote:
On Sat, Jul 25, 2020 at 11:44:36AM +0800, Yang Shen wrote:
From: Shukun Tan
Update debugfs interface parameters
Signed-off-by: Shukun Tan
Signed-off-by: Yang Shen
Reviewed-by: Zhou Wang
---
drivers/crypto/hisilicon/zip/zip_main.c | 55 +
On 2020/7/31 15:57, Herbert Xu wrote:
On Thu, Jul 23, 2020 at 03:19:38PM +0800, Yang Shen wrote:
When the devices are removed or not existing, the corresponding algorithms
which are registered by 'hisi-zip' driver can't be used.
Move 'hisi_zip_register_to_crypto' from 'hisi_zip_init' to
'his
On 2020/7/9 20:02, Herbert Xu wrote:
On Thu, Jul 09, 2020 at 07:05:11PM +0800, shenyang (M) wrote:
Yes, this patch just fixes the bug for 'hisi_zip'. As for 'hisi_hpre'
and 'hisi_sec2', this patch doesn't change the logic.
We have noticed the problem you
On 2020/7/9 13:36, Herbert Xu wrote:
On Wed, Jul 01, 2020 at 03:19:54PM +0800, Yang Shen wrote:
When the devices are removed or not existing, the corresponding algorithms
which are registered by 'hisi-zip' driver can't be used.
Move 'hisi_zip_register_to_crypto' from 'hisi_zip_init' to
'hisi
On 2020/6/29 19:09, Yang Shen wrote:
From: Sihang Chen
Save the string address before pass to strsep, release it at end.
Because strsep will update the string address to point after the
token.
Fixes: c31dc9fe165d("crypto: hisilicon/qm - add DebugFS for xQC and...")
Signed-off-by: Sihang Che
14 matches
Mail list logo
