> -Original Message-
> From: Horia Geanta
> Sent: Tuesday, July 23, 2019 2:38 PM
> To: Vakul Garg ; linux-crypto@vger.kernel.org
> Cc: Aymen Sghaier ;
> herb...@gondor.apana.org.au
> Subject: Re: [PATCH v4] crypto: caam/qi2 - Add printing dpseci fq stats using
&
Add support of printing the dpseci frame queue statistics using debugfs.
Signed-off-by: Vakul Garg
---
Changes since v4:
- Corrected license header commenting style
drivers/crypto/caam/Makefile | 1 +
drivers/crypto/caam/caamalg_qi2.c| 5 +++
drivers/crypto/caam
Add support of printing the dpseci frame queue statistics using debugfs.
Signed-off-by: Vakul Garg
---
Please ignore PATCH v3.
Changes since v2:
- Replaced CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM_DEBUGFS with
CONFIG_DEBUG_FS.
drivers/crypto/caam/Makefile | 1 +
drivers
> -Original Message-
> From: Horia Geanta
> Sent: Monday, July 22, 2019 7:55 PM
> To: Vakul Garg ; linux-crypto@vger.kernel.org
> Cc: Aymen Sghaier ;
> herb...@gondor.apana.org.au
> Subject: Re: [PATCH v2] crypto: caam/qi2 - Add printing dpseci fq stats using
> d
Add support of printing the dpseci frame queue statistics using debugfs.
Signed-off-by: Vakul Garg
---
Changes v2 -> v3
- Removed CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM_DEBUGFS
- Moved var 'dfs_root' out of structure 'dpaa2_caam_priv'.
drivers/crypto/caa
> -Original Message-
> From: Horia Geanta
> Sent: Monday, July 22, 2019 7:55 PM
> To: Vakul Garg ; linux-crypto@vger.kernel.org
> Cc: Aymen Sghaier ;
> herb...@gondor.apana.org.au
> Subject: Re: [PATCH v2] crypto: caam/qi2 - Add printing dpseci fq stats using
> d
Add support of printing the dpseci frame queue statistics using debugfs.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/Kconfig | 11 +
drivers/crypto/caam/Makefile | 1 +
drivers/crypto/caam/caamalg_qi2.c| 5 +++
drivers/crypto/caam/caamalg_qi2.h| 2
FQs bloat with large number of frames. In
some situations, it makes kernel crash due to out-of-memory. To prevent
it We increase the napi budget of dpseci driver to a big value so that
caam driver is able to drain its response queues at enough rate.
Signed-off-by: Vakul Garg
---
drivers/crypto/c
Add support of printing the dpseci frame queue statistics using debugfs.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/caamalg_qi2.c | 95 +++
drivers/crypto/caam/caamalg_qi2.h | 3 ++
2 files changed, 98 insertions(+)
diff --git a/drivers/crypto/caam
newly defined function wr_reg32_relaxed().
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/jr.c | 2 +-
drivers/crypto/caam/regs.h | 8
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 4e9b3fca5627..2ce6d7d2ad72 1
write operation. Therefore, the wmb() preceding
wr_reg32() can be safely removed.
Signed-off-by: Vakul Garg
Reviewed-by: Horia Geanta
---
drivers/crypto/caam/jr.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index
This patchset cleans up caam job ring driver.
The patch series needs to be applied after merging below mentioned
patch.
https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg37068.html
Vakul Garg (3):
crypto: caam/jr - Remove spinlock for output job ring
crypto: caam/jr - Removed
For each job ring pair, the output ring is processed exactly by one cpu
at a time under a tasklet context (one per ring). Therefore, there is no
need to protect a job ring's access & its private data structure using a
lock. Hence the lock can be removed.
Signed-off-by: Vakul Garg
Re
For each job ring, the variable 'ringsize' is initialised but never
used. Similarly variables 'inp_ring_write_index' and 'head' always track
the same value and instead of 'inp_ring_write_index', caam_jr_enqueue()
can use 'head' itself. Both these
write operation. Therefore, the wmb() preceding
wr_reg32() can be safely removed.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/jr.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index e95f82778fa1..1de2562d0982
This patchset cleans up caam job ring driver.
The patch series needs to be applied after merging below mentioned
patch.
https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg37068.html
Vakul Garg (3):
crypto: caam/jr - Remove spinlock for output job ring
crypto: caam/jr - Remove
For each job ring pair, the output ring is processed exactly by one cpu
at a time under a tasklet context (one per ring). Therefore, there is no
need to protect a job ring's access & its private data structure using a
lock. Hence the lock can be removed.
Signed-off-by: Vakul Garg
--
For each job ring, the variable 'ringsize' is initialised but never
used. Similarly variables 'inp_ring_read_index' and 'head' always track
the same value and instead of 'inp_ring_read_index', caam_jr_enqueue()
can use 'head' itself. Both these
write operation. Therefore, the wmb() preceding
wr_reg32() can be safely removed.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/jr.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 02f02fa996da..3bd28386eb07
For each job ring, the variable 'ringsize' is initialised but never
used. Similarly variables 'inp_ring_read_index' and 'head' always track
the same value and instead of 'inp_ring_read_index', caam_jr_enqueue()
can use 'head' itself. Both these
For each job ring pair, the output ring is processed exactly by one cpu
at a time under a tasklet context (one per ring). Therefore, there is no
need to protect a job ring's access & its private data structure using a
lock. Hence the lock can be removed.
Signed-off-by: Vakul Garg
---
This patchset cleans up caam job ring driver.
The patch series needs to be applied after merging below mentioned
patch.
https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg37068.html
Vakul Garg (3):
crypto: caam/jr - Remove spinlock for output job ring
crypto: caam/jr - Remove
ing's occupancy registers. This eliminates need of expensive device
register read operations for every job enqueued and dequeued and hence
makes caam_jr_enqueue() and caam_jr_dequeue() faster. The performance of
kernel ipsec improved by about 6% on ls1028 (for frame size 408 bytes).
Signed-off-by:
ing's occupancy registers. This eliminates need of expensive device
register read operations for every job enqueued and dequeued and hence
makes caam_jr_enqueue() and caam_jr_dequeue() faster.
Signed-off-by: Vakul Garg
---
Changes since v1:
- Changed 'i/p' in comment to
> -Original Message-
> From: Horia Geanta
> Sent: Tuesday, March 5, 2019 10:14 PM
> To: Vakul Garg ; linux-crypto@vger.kernel.org
> Cc: Aymen Sghaier ;
> herb...@gondor.apana.org.au; da...@davemloft.net
> Subject: Re: [PATCH] crypto: caam/jr - optimize job ring
ing's occupancy registers. This eliminates need of expensive device
register read operations for every job enqueued and dequeued and hence
makes caam_jr_enqueue() and caam_jr_dequeue() faster.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/intern.h | 1 +
drivers/crypto/caam/jr.c | 12 +
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, August 20, 2018 8:29 PM
> To: linux-crypto@vger.kernel.org
> Cc: herb...@gondor.apana.org.au; Vakul Garg ;
> davejwat...@fb.com; Peter Doliwa ; Ard
> Biesheuvel
> Subject: [PATCH] crypto: arm64/aes-
Hi Ard
Kernel tls selftest ' msg_more' is broken with the latest gcm changes for
optimizing it on cortex a-53.
(I am using David Miller's net-next branch.)
Reverting following commits fixes the problem.
1. crypto: arm64/ghash-ce - implement 4-way aggregation
2. crypto: arm64/ghash-ce - replace
> -Original Message-
> From: bige...@linutronix.de [mailto:bige...@linutronix.de]
> Sent: Wednesday, July 25, 2018 12:33 PM
> To: Vakul Garg
> Cc: Ard Biesheuvel ; linux-
> cry...@vger.kernel.org; herb...@gondor.apana.org.au;
> will.dea...@arm.com; dave.mar...@
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, July 24, 2018 10:42 PM
> To: linux-crypto@vger.kernel.org
> Cc: herb...@gondor.apana.org.au; will.dea...@arm.com;
> dave.mar...@arm.com; Vakul Garg ;
> bige...@linutron
Hi
How does this patchset affect the throughput performance of crypto?
Is it expected to increase?
Regards
Vakul
> -Original Message-
> From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto-
> ow...@vger.kernel.org] On Behalf Of Ard Biesheuvel
> Sent: Saturday, March 10, 2018 8:
> -Original Message-
> From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto-
> ow...@vger.kernel.org] On Behalf Of Atul Gupta
> Sent: Tuesday, March 6, 2018 9:05 PM
> To: davejwat...@fb.com; da...@davemloft.net;
> herb...@gondor.apana.org.au
> Cc: linux-crypto@vger.kernel.org; ne
> -Original Message-
> From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto-
> ow...@vger.kernel.org] On Behalf Of Atul Gupta
> Sent: Thursday, February 8, 2018 3:56 PM
> To: Dave Watson
> Cc: s...@queasysnail.net; herb...@gondor.apana.org.au; linux-
> cry...@vger.kernel.org; ga
> -Original Message-
> From: Dave Watson [mailto:davejwat...@fb.com]
> Sent: Wednesday, January 31, 2018 11:05 PM
> To: Vakul Garg
> Cc: linux-crypto@vger.kernel.org; il...@mellanox.com;
> avia...@mellanox.com; da...@davemloft.net; net...@vger.kernel.org;
> Gilad
> -Original Message-
> From: Dave Watson [mailto:davejwat...@fb.com]
> Sent: Wednesday, January 31, 2018 8:52 PM
> To: Vakul Garg
> Cc: linux-crypto@vger.kernel.org; il...@mellanox.com;
> avia...@mellanox.com; da...@davemloft.net; net...@vger.kernel.org;
> Gilad
.
Signed-off-by: Vakul Garg
---
v1-v2:
- Used crypto_wait_req() to wait for async operation completion
- Passed CRYPTO_TFM_REQ_MAY_BACKLOG to crypto_aead_encrypt
include/net/tls.h | 2 ++
net/tls/tls_sw.c | 8 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/net/tls.h b
Forgot to add 'v2' in subject line.
I will be resending.
-Original Message-----
From: Vakul Garg
Sent: Wednesday, January 31, 2018 9:29 PM
To: linux-crypto@vger.kernel.org
Cc: il...@mellanox.com; avia...@mellanox.com; davejwat...@fb.com;
da...@davemloft.net; net...@vger.kernel.
.
Signed-off-by: Vakul Garg
---
v1-v2:
- Used crypto_wait_req() to wait for async operation completion
- Passed CRYPTO_TFM_REQ_MAY_BACKLOG to crypto_aead_encrypt
include/net/tls.h | 2 ++
net/tls/tls_sw.c | 8 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/net/tls.h b
.
Signed-off-by: Vakul Garg
---
net/tls/tls_sw.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 73d19210dd49..390e6dc7b135 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -39,6 +39,11 @@
#include
+struct
.
Signed-off-by: Vakul Garg
---
net/tls/tls_sw.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 73d19210dd49..390e6dc7b135 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -39,6 +39,11 @@
#include
+struct
This patch fixes a memory leak that appears when caam_jr module is unloaded.
Cc: # 3.13+
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/jr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 1d80bd3..f127f86 100644
--- a/driver
> Sent: Saturday, May 03, 2014 5:40 AM
> > >
> > > On Sun, 27 Apr 2014 11:26:14 -0400
> > > Vakul Garg wrote:
> > >
> > > > @@ -220,6 +220,8 @@ static int aead_null_set_sh_desc(struct
> > > > crypto_aead
> > > *aead)
&g
u Alexandru-B06830
> Subject: Re: [PATCH] crypto: caam - Fix key inlining in AEAD shared
> descriptors
>
> On Sun, 27 Apr 2014 11:26:14 -0400
> Vakul Garg wrote:
>
> > The variable 'keys_fit_inline' is initialised correctly to avoid using
> > its stale
The variable 'keys_fit_inline' is initialised correctly to avoid using
its stale value while creating shared descriptor for decryption and
given-iv-encryption.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/caamalg.c | 15 +--
1 file changed, 13 insertions(+), 2
: Ic8900990d465e9079827b0c7fcacc61766d7efb6
Signed-off-by: Vakul Garg
Reviewed-by: Geanta Neag Horia Ioan-B05471
Reviewed-by: Fleming Andrew-AFLEMING
Tested-by: Fleming Andrew-AFLEMING
---
drivers/crypto/caam/caamalg.c |2 --
drivers/crypto/caam/caamhash.c|2 --
drivers/crypto/caam
-32: Restoring 0xdec5dec0-0xdec5dec3=0xcc
Change-Id: I0c7a1048053e811025d1c3b487940f87345c8f5d
Signed-off-by: Vakul Garg
CC: #3.9
Reviewed-by: Geanta Neag Horia Ioan-B05471
Reviewed-by: Fleming Andrew-AFLEMING
Tested-by: Fleming Andrew-AFLEMING
---
drivers/crypto/caam/caamhash.c |2 +-
1
: Ic8900990d465e9079827b0c7fcacc61766d7efb6
Signed-off-by: Vakul Garg
Reviewed-by: Geanta Neag Horia Ioan-B05471
Reviewed-by: Fleming Andrew-AFLEMING
Tested-by: Fleming Andrew-AFLEMING
---
drivers/crypto/caam/caamalg.c |2 --
drivers/crypto/caam/caamhash.c|2 --
drivers/crypto/caam
-32: Restoring 0xdec5dec0-0xdec5dec3=0xcc
Change-Id: I0c7a1048053e811025d1c3b487940f87345c8f5d
Signed-off-by: Vakul Garg
CC: #3.9
Reviewed-by: Geanta Neag Horia Ioan-B05471
Reviewed-by: Fleming Andrew-AFLEMING
Tested-by: Fleming Andrew-AFLEMING
---
drivers/crypto/caam/caamhash.c |2 +-
1
Herbert Xu gondor.apana.org.au> writes:
>
> On Wed, Jan 26, 2011 at 10:26:33AM +0330, Hamid Nassiby wrote:
> >
> > As you know, I posted my problem again to crypto list and no one
answered.
> > Now I
> > emphasize one aspect of the problem as a concept related to IPSec
protocol,
> > free
> > o
[c029fb38] __device_release_driver+0x68/0x120
[eac47e90] [c02a05c8] driver_detach+0xd8/0xe0
[eac47eb0] [c029f8e0] bus_remove_driver+0xa0/0x110
[eac47ed0] [c00768e4] sys_delete_module+0x144/0x270
[eac47f40] [c000e2f0] ret_from_syscall+0x0/0x3c
Signed-off-by: Vakul Garg
Signed-off-by: Bharat Bhushan
-
4),cbc(des))
(f) authenc(hmac(sha384),cbc(des))
Signed-off-by: Vakul Garg
Reviewed-by: Kim Phillips
Signed-off-by: Andy Fleming
---
drivers/crypto/caam/caamalg.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam
st. If the Random Data Buffer is not enabled, then each IV causes a
separate request, and RNG4 hardware cannot keep up resulting in lower
IPSEC throughput if random IVs are used.
Signed-off-by: Vakul Garg
---
Sorry for repeated sending.
Resending as suggested by Herbert.
Changes in v1: Addressed Ki
st. If the Random Data Buffer is not enabled, then each IV causes a
separate request, and RNG4 hardware cannot keep up resulting in lower
IPSEC throughput if random IVs are used.
Signed-off-by: Vakul Garg
---
Changes in v1: Addressed Kim Philip's comments.
(a) Limit commit message to 75 characters
st. If the Random Data Buffer is not enabled, then each IV causes a
separate request, and RNG4 hardware cannot keep up resulting in lower
IPSEC throughput if random IVs are used.
Signed-off-by: Vakul Garg
---
Changes in v1: Addressed Kim Philip's comments.
(a) Limit commit message to 75 characters
st. If the Random Data Buffer is not enabled, then each IV causes a
separate request, and RNG4 hardware cannot keep up resulting in lower
IPSEC throughput if random IVs are used.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/ctrl.c |3 +++
drivers/crypto/caam/regs.h |4 +++-
2 files
st. If the Random Data Buffer
is not enabled, then each IV causes a separate request, and RNG4 hardware
cannot keep up resulting in lower IPSEC throughput.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/ctrl.c |3 +++
drivers/crypto/caam/regs.h |4 +++-
2 files changed, 6 insertions(+), 1
This new property defines the era of the particular SEC version.
The compatible property in device tree "crypto" node has been updated
not to contain SEC era numbers.
Signed-off-by: Vakul Garg
---
Changes in v1:
1. Marked fsl,sec-era as 'optional'.
Changes in v2:
This new property defines the era of the particular SEC version.
The compatible property in device tree "crypto" node has been updated
not to contain SEC era numbers.
Signed-off-by: Vakul Garg
---
Changelog:
1. Marked fsl,sec-era as 'optional'.
.../devicetree/bind
This new property defines the era of the particular SEC version.
The compatible property in device tree "crypto" node has been updated
not to contain SEC era numbers.
Signed-off-by: Vakul Garg
---
.../devicetree/bindings/crypto/fsl-sec4.txt| 12 +---
1 files
() already sets output buffer in the ahash transform using
ahash_request_set_crypt().
Signed-off-by: Vakul Garg
---
crypto/tcrypt.c | 17 -
1 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index 7ae2130..1414b9f 100644
--- a/crypto
From: Steve Cornelius
Multiple function in asynchronous hashing use a saved-state block,
a.k.a. struct caam_hash_state, which holds a stash of information
between requests (init/update/final). Certain values in this state
block are loaded for processing using an inline-if, and when this
is done,
These patches have been authored by Steve Cornelius.
These patches fix uninitialised variables left in the hashing module.
.
Steve Cornelius (2):
crypto: caam - Fix DMA size in descriptor in ahash_digest()
crypto: caam - improve init for context state saves
drivers/crypto/caam/caamhash.c |
From: Steve Cornelius
Save of DMA size in extended descriptor was missing.
Thus crashes could occur during post-request unmapping.
Signed-off-by: Steve Cornelius
---
drivers/crypto/caam/caamhash.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/crypto/caam/caam
, unbound and then bound again to caam platform driver.
Signed-off-by: Vakul Garg
Signed-off-by: Bharat Bhushan
---
drivers/crypto/caam/intern.h |1 +
drivers/crypto/caam/jr.c |4
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/crypto/caam/intern.h b/drivers
This allows to test & run multiple parallel crypto ahash contexts.
Each of the test vector under the ahash speed test template is started
under a separate kthread.
Signed-off-by: Vakul Garg
---
crypto/tcrypt.c | 164 +++
1 files changed,
"authenc(hmac(sha384),cbc(des3_ede))"
(i) "authenc(hmac(sha512),cbc(des))"
(j) "authenc(hmac(sha512),cbc(des3_ede))"
Signed-off-by: Vakul Garg
---
crypto/testmgr.c | 120 ++
crypto/testmgr.h | 647 +++
Test vectors were generated starting from existing CBC(AES) test vectors
(RFC3602, NIST SP800-38A) and adding HMAC(SHA384) computed with Crypto++ and
double-checked with HashCalc.
Signed-off-by: Vakul Garg
---
crypto/testmgr.c | 12 ++
crypto/testmgr.h | 293
4),cbc(des))
(f) authenc(hmac(sha384),cbc(des))
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/caamalg.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c
index b2a0a07..42420fb 100644
--- a/drivers/c
This allows to test & run multiple parallel crypto ahash contexts.
Each of the test vector under the ahash speed test template is started
under a separate kthread.
Signed-off-by: Vakul Garg
---
crypto/tcrypt.c | 164 +++
1 files changed,
This reverts commit a2c0911c09190125f52c9941b9d187f601c2f7be.
Signed-off-by: Vakul Garg
---
Instead of adding SEC era information in crypto node's compatible, a new
property 'fsl,sec-era' is being introduced into crypto node.
.../devicetree/bindings/crypto/fsl-sec4.txt
The compatible property in device tree "crypto" node has been enhanced
to provide SEC ERA information to the applications.
Signed-off-by: Vakul Garg
---
.../devicetree/bindings/crypto/fsl-sec4.txt|5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Doc
. For ERA-6 and later devices,
it returns ERA directly by reading CCBVID.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/ctrl.c | 29 +
drivers/crypto/caam/ctrl.h |2 +-
drivers/crypto/caam/regs.h |7 +++
3 files changed, 29 insertions(+), 9 deletions
the mapping table.
For ERA-6 and later devices, it returns ERA directly by reading CCBVID.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/ctrl.c | 33 +++--
drivers/crypto/caam/ctrl.h |2 +-
drivers/crypto/caam/regs.h |7 +++
3 files changed, 31
On P5040, SEC-ERA does not print correctly. This is because SEC-VID to SEC-ERA
mapping table does not contain information for P5040. This patch adds this
information.
Signed-off-by: Vakul Garg
---
Please ignore my previous patch which contained internal release prefixes.
drivers/crypto/caam
On P5040, SEC-ERA does not print correctly. This is because SEC-VID to SEC-ERA
mapping table does not contain information for P5040. This patch adds this
information.
Signed-off-by: Vakul Garg
---
drivers/crypto/caam/ctrl.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff
75 matches
Mail list logo
