Re: [PATCH 06/10] crypto: atmel-ecc: Struct headers need to start with keyword 'struct'

2021-03-22 Thread Tudor.Ambarus
On 3/18/21 2:44 PM, Lee Jones wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Fixes the following W=1 kernel build warning(s): > > drivers/crypto/atmel-ecc.c:41: warning: cannot understand function > prototype: 'struct atmel_ecdh_ctx '

Re: [PATCH] crypto: atmel-ecc - fix W=1 "cannot understand" warning

2021-03-22 Thread Tudor.Ambarus
On 3/20/21 10:15 AM, Meng Yu wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Fix kernel-doc warnings due to missing "struct" keyword. > > The warning likes: > drivers/crypto/atmel-ecc.c:40: warning: cannot understand function prototype:

Re: [PATCH v9 3/7] crypto: move curve_id of ECDH from the key to algorithm name

2021-02-24 Thread Tudor.Ambarus
On 2/24/21 3:29 AM, yumeng wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > 在 2021/2/23 18:44, tudor.amba...@microchip.com 写道: >> Hi, >> >> On 2/23/21 9:10 AM, Meng Yu wrote: >>> --- a/drivers/crypto/atmel-ecc.c >>> +++ b/drivers/crypto/atm

Re: [PATCH v9 3/7] crypto: move curve_id of ECDH from the key to algorithm name

2021-02-23 Thread Tudor.Ambarus
Hi, On 2/23/21 9:10 AM, Meng Yu wrote: > --- a/drivers/crypto/atmel-ecc.c > +++ b/drivers/crypto/atmel-ecc.c > @@ -104,7 +104,7 @@ static int atmel_ecdh_set_secret(struct crypto_kpp *tfm, > const void *buf, > return -EINVAL; > } > > - ctx->n_sz = atmel_ecdh_supporte

Re: [PATCH 12/20] crypto: atmel-ecc: Struct headers need to start with keyword 'struct'

2021-02-04 Thread Tudor.Ambarus
On 2/4/21 1:09 PM, Lee Jones wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Fixes the following W=1 kernel build warning(s): > > drivers/crypto/atmel-ecc.c:41: warning: cannot understand function > prototype: 'struct atmel_ecdh_ctx ' >

Re: [PATCH 08/25] crypto: atmel-aes - switch to skcipher API

2019-10-15 Thread Tudor.Ambarus
Hi, Ard, Thanks for working on this. On 10/14/2019 03:18 PM, Ard Biesheuvel wrote: > Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface") > dated 20 august 2015 introduced the new skcipher API which is supposed to > replace both blkcipher and ablkcipher. While all consumers

[PATCH] crypto: atmel-aes - Fix IV handling when req->nbytes < ivsize

2019-10-04 Thread Tudor.Ambarus
From: Tudor Ambarus commit 394a9e044702 ("crypto: cfb - add missing 'chunksize' property") adds a test vector where the input length is smaller than the IV length (the second test vector). This revealed a NULL pointer dereference in the atmel-aes driver, that is caused by passing an incorrect off

Re: [RFC PATCH] akcipher: Introduce verify2 for public key algorithms

2018-12-13 Thread Tudor.Ambarus
Hi, On 12/11/2018 06:59 PM, Vitaly Chikunov wrote: > Current akcipher .verify() just decrypts signature to uncover message > hash, which is then verified in upper level public_key_verify_signature > by memcmp with the expected signature value, which is never passed into > verify(). > > This appro