Re: [PATCH] hwrng: omap3-rom - Fix unused function warnings

2019-10-23 Thread Tony Lindgren
m > > silently. > > > > Fixes: 8d9d4bdc495f ("hwrng: omap3-rom - Use runtime PM instead of custom > > functions") > > Signed-off-by: Arnd Bergmann > > --- > > Reviewed-by: Sebastian Reichel Thanks for fixing these similar issues again: Reviewwed-by: Tony Lindgren

Re: [PATCH 05/25] crypto: omap - switch to skcipher API

2019-10-15 Thread Tony Lindgren
pher code in the near future. Adding Tero to loop as I think he was the last one to update this code. Regards, Tony > Cc: Tony Lindgren > Cc: linux-o...@vger.kernel.org > Signed-off-by: Ard Biesheuvel > --- > drivers/crypto/omap-aes.c | 208 +- > drivers/crypto

[PATCH 7/7] hwrng: omap3-rom - Use devm hwrng and runtime PM

2019-09-14 Thread Tony Lindgren
This allows us to simplify things more for probe and exit. Cc: Aaro Koskinen Cc: Adam Ford Cc: Pali Rohár Cc: Sebastian Reichel Cc: Tero Kristo Suggested-by: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/char/hw_random/omap3-rom-rng.c | 42 ++ 1 file

[PATCH 6/7] hwrng: omap3-rom - Use runtime PM instead of custom functions

2019-09-14 Thread Tony Lindgren
() becomes very simple and we don't need the old functions for omap3_rom_rng_idle() and omap3_rom_rng_get_random(). We can now also get rid of pr_fmt as we're using dev_err instead. Cc: Aaro Koskinen Cc: Adam Ford Cc: Pali Rohár Cc: Sebastian Reichel Cc: Tero Kristo Signed-off-by: Ton

[PATCH 2/7] hwrng: omap3-rom - Fix missing clock by probing with device tree

2019-09-14 Thread Tony Lindgren
gether with the fix. Cc: devicet...@vger.kernel.org Cc: Aaro Koskinen Cc: Adam Ford Cc: Pali Rohár Cc: Rob Herring Cc: Sebastian Reichel Cc: Tero Kristo Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases") Reported-by: Aaro Koskinen Signed-off-by: Tony Lind

[PATCH 4/7] hwrng: omap3-rom - Initialize default quality to get data

2019-09-14 Thread Tony Lindgren
Sebastian Reichel Cc: Tero Kristo Signed-off-by: Tony Lindgren --- drivers/char/hw_random/omap3-rom-rng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/omap3-rom-rng.c b/drivers/char/hw_random/omap3-rom-rng.c --- a/drivers/char/hw_random/omap3-rom-rng.c +++ b/dr

[PATCH 1/7] ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS device

2019-09-14 Thread Tony Lindgren
Rohár Cc: Sebastian Reichel Cc: Tero Kristo Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/pdata-quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c --- a/arch/arm/mach-omap2/pdata-quirks.c

[PATCHv2 0/7] Non-urgent fixes and improvments for omap3-rom-rng

2019-09-14 Thread Tony Lindgren
) Regards, Tony Changes since v1: - Use clk_prepare_enable() as pointed out by Sebastian - Simplify runtime PM changes patch - Add a new patch for devm changes as suggested by Sebastian Tony Lindgren (7): ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS device hwrng: omap3-rom - F

[PATCH 5/7] hwrng: omap3-rom - Update to use standard driver data

2019-09-14 Thread Tony Lindgren
patch. Cc: Aaro Koskinen Cc: Adam Ford Cc: Pali Rohár Cc: Sebastian Reichel Cc: Tero Kristo Signed-off-by: Tony Lindgren --- drivers/char/hw_random/omap3-rom-rng.c | 45 +- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/drivers/char/hw_random/omap3-ro

[PATCH 3/7] hwrng: omap3-rom - Call clk_disable_unprepare() on exit only if not idled

2019-09-14 Thread Tony Lindgren
Cc: Pali Rohár Cc: Sebastian Reichel Cc: Tero Kristo Fixes: 1c6b7c2108bd ("hwrng: OMAP3 ROM Random Number Generator support") Signed-off-by: Tony Lindgren --- drivers/char/hw_random/omap3-rom-rng.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char

Re: [PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng

2019-09-14 Thread Tony Lindgren
* Sebastian Reichel [190914 13:06]: > Hi, > > On Fri, Sep 13, 2019 at 03:09:16PM -0700, Tony Lindgren wrote: > > Here are fixes and improvments for omap3-rom-rng that's been broken for > > a while. > > > > The first four patches get it working, and then th

Re: [PATCH 3/6] hwrng: omap3-rom - Call clk_prepare() on init and exit only

2019-09-14 Thread Tony Lindgren
* Sebastian Reichel [190914 13:01]: > Hi, > > On Fri, Sep 13, 2019 at 03:09:19PM -0700, Tony Lindgren wrote: > > Also, we should not call prepare and unprepare except during init, and > > only call enable and disable during use. > > Why? Usually clk_(un)prepare() is

[PATCH 1/6] ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS device

2019-09-13 Thread Tony Lindgren
Rohár Cc: Tero Kristo Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/pdata-quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c --- a/arch/arm/mach-omap2/pdata-quirks.c +++ b/arch/arm/mach-

[PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng

2019-09-13 Thread Tony Lindgren
Hi all, Here are fixes and improvments for omap3-rom-rng that's been broken for a while. The first four patches get it working, and then the last two patches add support for runtime PM. Regards, Tony Tony Lindgren (6): ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS d

[PATCH 3/6] hwrng: omap3-rom - Call clk_prepare() on init and exit only

2019-09-13 Thread Tony Lindgren
sable during use. Cc: Aaro Koskinen Cc: Adam Ford Cc: Pali Rohár Cc: Tero Kristo Fixes: 1c6b7c2108bd ("hwrng: OMAP3 ROM Random Number Generator support") Signed-off-by: Tony Lindgren --- drivers/char/hw_random/omap3-rom-rng.c | 24 ++-- 1 file changed, 18 i

[PATCH 6/6] hwrng: omap3-rom - Use runtime PM instead of custom functions

2019-09-13 Thread Tony Lindgren
() becomes very simple and we don't need the old functions for omap3_rom_rng_idle() and omap3_rom_rng_get_random(). Signed-off-by: Tony Lindgren --- drivers/char/hw_random/omap3-rom-rng.c | 127 +++-- 1 file changed, 77 insertions(+), 50 deletions(-) diff --git a/drivers

[PATCH 4/6] hwrng: omap3-rom - Initialize default quality to get data

2019-09-13 Thread Tony Lindgren
Similar to commit 62f95ae805fa ("hwrng: omap - Set default quality") we need to initialize the default quality for the RNG to be used. The symptoms of this problem is that doing hd /dev/random does not produce much data at all. Signed-off-by: Tony Lindgren --- drivers/char/hw_random

[PATCH 2/6] hwrng: omap3-rom - Fix missing clock by probing with device tree

2019-09-13 Thread Tony Lindgren
gether with the fix. Cc: devicet...@vger.kernel.org Cc: Aaro Koskinen Cc: Adam Ford Cc: Pali Rohár Cc: Rob Herring Cc: Tero Kristo Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases") Reported-by: Aaro Koskinen Signed-off-by: Tony Lindgren --- ..

[PATCH 5/6] hwrng: omap3-rom - Update to use standard driver data

2019-09-13 Thread Tony Lindgren
ff-by: Tony Lindgren --- drivers/char/hw_random/omap3-rom-rng.c | 51 +- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/drivers/char/hw_random/omap3-rom-rng.c b/drivers/char/hw_random/omap3-rom-rng.c --- a/drivers/char/hw_random/omap3-rom-rng.c +++ b/drivers

Re: [PATCHv2 00/27] crypto: fixes for omap family of devices

2016-06-22 Thread Tony Lindgren
* Tero Kristo [160622 06:27]: > Hi, > > Changes compared to v1 of the series: > > - dropped first patch from the series (crypto: omap-aes: Fix registration of > algorithms) as it was queued by Herbert already > - modified the second (now first) patch of the series to use runtime auto- > susp

Re: [PATCH 23/28] ARM: dts: DRA7: Add DT node for DES IP

2016-06-22 Thread Tony Lindgren
* Tero Kristo [160621 10:58]: > > Do you want to pick-up the DTS changes from this revision of series as is or > shall I repost those also? I think the series would require a re-ordering of > posting the DTS changes before the hwmod data. I'll pick the dts changes from this series into omap-for-

Re: [PATCH 23/28] ARM: dts: DRA7: Add DT node for DES IP

2016-06-10 Thread Tony Lindgren
* Tero Kristo [160601 02:09]: > From: Joel Fernandes > > DRA7xx SoCs have a DES3DES IP. Add DT data for the same. Are these dts changes safe to apply separately or do they cause issues like extra warnings during boot? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels

2015-05-26 Thread Tony Lindgren
* Peter Ujfalusi [150526 06:28]: > Switch to use ma_request_slave_channel_compat_reason() to request the DMA > channels. In case of error, return the error code we received including > -EPROBE_DEFER > > Signed-off-by: Peter Ujfalusi > CC: Greg Kroah-Hartman > --- > drivers/tty/serial/8250/8250

Re: [PATCH 07/10] ARM: dts: n9/n950: Enable omap crypto support

2015-03-19 Thread Tony Lindgren
* Pavel Machek [150228 08:45]: > On Thu 2015-02-26 14:49:57, Pali Rohár wrote: > > Harmattan system on Nokia N9 and N950 devices uses omap crypto support. > > Bootloader on those devices is known that it enables HW crypto support. > > This patch just include omap36xx.dtsi directly, so aes and sham

Re: [PATCH 06/10] ARM: dts: omap3: Add missing dmas for crypto

2015-03-16 Thread Tony Lindgren
* Pavel Machek [150228 08:49]: > On Thu 2015-02-26 14:49:56, Pali Rohár wrote: > > This patch adds missing dma DTS definitions for omap aes and sham drivers. > > Without it kernel drivers do not work. > > > > Signed-off-by: Pali Rohár > > Acked-by: PavelMachek Applying this into omap-

Re: [PATCH 00/10] omap3 crypto fixes

2015-03-06 Thread Tony Lindgren
* Pali Rohár [150306 11:16]: > On Friday 06 March 2015 19:36:32 Tony Lindgren wrote: > > * Pali Rohár [150226 05:54]: > > > This patch series fix crypto support for omap3 devices which > > > use DT. > > > > > > It enables AES and SHAM on N9/N950 and

Re: [PATCH 00/10] omap3 crypto fixes

2015-03-06 Thread Tony Lindgren
* Pali Rohár [150226 05:54]: > This patch series fix crypto support for omap3 devices which use DT. > > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is still disabled > for N900. > > Pali Rohár (10): > ARM: OMAP2+: Return correct error values from device and hwmod > ARM: OMAP3:

Re: [PATCH 07/10] ARM: dts: n9/n950: Enable omap crypto support

2015-02-27 Thread Tony Lindgren
* Pali Rohár [150227 08:05]: > On Friday 27 February 2015 16:43:20 Tony Lindgren wrote: > > * Pali Rohár [150226 05:54]: > > > Harmattan system on Nokia N9 and N950 devices uses omap > > > crypto support. Bootloader on those devices is known that > > > it e

Re: [PATCH 07/10] ARM: dts: n9/n950: Enable omap crypto support

2015-02-27 Thread Tony Lindgren
* Pali Rohár [150226 05:54]: > Harmattan system on Nokia N9 and N950 devices uses omap crypto support. > Bootloader on those devices is known that it enables HW crypto support. > This patch just include omap36xx.dtsi directly, so aes and sham is enabled. Let's also remove omap36xx-hs.dtsi with th

Re: Nokia N900: omap aes is broken

2015-02-24 Thread Tony Lindgren
* Pali Rohár [150224 09:52]: > On Tuesday 24 February 2015 18:37:34 Tony Lindgren wrote: > > * Pali Rohár [150224 09:42]: > > > On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote: > > > > * Pali Rohár [150218 16:03]: > > > > > ---

Re: Nokia N900: omap aes is broken

2015-02-24 Thread Tony Lindgren
* Pali Rohár [150224 09:42]: > On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote: > > * Pali Rohár [150218 16:03]: > > > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > > > @@ -3938,8 +3938,9 @@

Re: Nokia N900: omap aes is broken

2015-02-24 Thread Tony Lindgren
* Pali Rohár [150218 16:03]: > On Wednesday 18 February 2015 22:02:30 Pali Rohár wrote: > > On Wednesday 18 February 2015 13:21:03 Pali Rohár wrote: > > > Hello, > > > > > > I tried to test OMAP AES driver on Nokia N900 with special > > > Nokia bootloader which enable L3 firewall for OMAP AES HW

Re: [PATCH v4 7/8] crypto: omap-sham: Add code to use dmaengine API

2012-11-20 Thread Tony Lindgren
* Mark A. Greer [121119 10:58]: > @@ -27,6 +29,10 @@ > #include > #include > #include > +#ifndef OMAP_SHAM_DMA_PRIVATE > +#include > +#include > +#endif > #include > #include > #include I think you should be able to drop the OMAP_SHAM_DMA_PRIVATE from the include after I'll post one

Re: [PATCH 4/7] crypto: omap-aes: Remove cpu_is/omap_type check from driver

2012-11-20 Thread Tony Lindgren
* Mark A. Greer [121119 11:06]: > From: "Mark A. Greer" > > The omap-aes driver should not check the CPU class or the > type of OMAP device its on. The platform code should do > that instead. Similar patch for this one too should be queued already. Regards, Tony > Signed-off-by: Mark A. Gr

Re: [PATCH v4 5/8] crypto: omap-sham: Remove cpu_is/omap_type check from driver

2012-11-20 Thread Tony Lindgren
* Mark A. Greer [121119 10:58]: > From: "Mark A. Greer" > > The omap-sham driver should not check the CPU class or the > type of OMAP device its on. The platform code should do > that instead. I think I already have a similar patch queued in linux next. Regards, Tony > CC: Paul Walmsley >

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Tony Lindgren
* Paul Walmsley [121109 09:13]: > On Fri, 9 Nov 2012, Mark A. Greer wrote: > > > On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote: > > > > > Why not using macros as it was before? > > > > > > OMAP24XX_SEC_SHA1MD5_BASE > > > > I am following the precedent set in the existing code

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-17 Thread Tony Lindgren
* Tony Lindgren [121015 17:09]: > * Tony Lindgren [121009 17:21]: > > * Péter Ujfalusi [121009 02:03]: > > > On 10/08/2012 07:35 PM, Tony Lindgren wrote: > > > > > > > - omap-dma.c and omap-pcm.c can test the arch locally as > > > > oma

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-15 Thread Tony Lindgren
* Tony Lindgren [121009 17:21]: > * Péter Ujfalusi [121009 02:03]: > > On 10/08/2012 07:35 PM, Tony Lindgren wrote: > > > > > - omap-dma.c and omap-pcm.c can test the arch locally as > > > omap1 and omap2 cannot be compiled together because of &

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-09 Thread Tony Lindgren
* Péter Ujfalusi [121009 02:03]: > On 10/08/2012 07:35 PM, Tony Lindgren wrote: > > > - omap-dma.c and omap-pcm.c can test the arch locally as > > omap1 and omap2 cannot be compiled together because of > > conflicting compiler flags > > > sound/s

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-08 Thread Tony Lindgren
* Tony Lindgren [121008 10:37]: > Drivers should not use cpu_is_omap or cpu_class_is_omap macros, > they should be private to the platform init code. And we'll be > removing plat/cpu.h and only have a private soc.h for the > arch/arm/*omap* code. > > This patch is intended

[PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-08 Thread Tony Lindgren
iams Cc: Peter Ujfalusi Cc: Jarkko Nikula Cc: Liam Girdwood Cc: Mark Brown Cc: linux-crypto@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: alsa-de...@alsa-project.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Tony Lindgren --- drivers/char/hw_random/omap-rng.c |2 -- drivers/cr

Re: [PATCH 3/7] omap-sham: OMAP macros corrected

2010-11-16 Thread Tony Lindgren
* Dmitry Kasatkin [101110 09:20]: > Signed-off-by: Dmitry Kasatkin > --- > arch/arm/mach-omap2/devices.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c > index beac46c..79dbf04 100644 > --- a/arch/ar

Re: [PATCH 1/7] crypto: updates omap sham device related platform code

2010-11-16 Thread Tony Lindgren
* Dmitry Kasatkin [101110 09:20]: > - registration with multi OMAP kernels support > - clocks > > Signed-off-by: Dmitry Kasatkin > --- > arch/arm/mach-omap2/clock2420_data.c |2 +- > arch/arm/mach-omap2/clock2430_data.c |2 +- > arch/arm/mach-omap2/clock3xxx_data.c |

Re: [PATCH 1/5] crypto: omap-aes: change in prevention of OCP bus error

2010-11-16 Thread Tony Lindgren
Hi, * Dmitry Kasatkin [101110 09:18]: > Suggested to use udelay() instead of nop as on the higher > core frequencies it might not be enough time. > > Signed-off-by: Dmitry Kasatkin > --- > drivers/crypto/omap-aes.c | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff

Re: [PATCH 1/1] omap-sham: OMAP macros corrected

2010-05-10 Thread Tony Lindgren
A1MD5_BASE, > >> > > Hi Tony: > > > > If I add this patch to cryptodev, is this going to cause any > > problems for you? > > > > Thbanks, > > > Hi, > > I should not be any problem, because it indeed needs to be like that.

Re: [PATCHv4 0/2] omap-sham: OMAP SHA1/MD5 driver

2010-05-05 Thread Tony Lindgren
* Herbert Xu [100502 20:07]: > On Wed, Apr 28, 2010 at 05:18:05PM +0300, Dmitry Kasatkin wrote: > > Changes to v4: > > - concurrent requests support via queue > > - hmac > > - shash support removed > > > > Dmitry Kasatkin (2): > > crypto: updates omap sham device related platform code > > cry

Re: [PATCH 1/2] sec: omap sha1 & md5 driver

2010-03-17 Thread Tony Lindgren
* Felipe Balbi [100317 10:04]: > On Wed, Mar 17, 2010 at 03:12:50PM +0200, Dmitry Kasatkin wrote: > > Earlier kernel contained omap sha1 and md5 driver, which was not maintained, > > was not ported to new crypto APIs and removed from the source tree. > > > +#include > > +#include > > +#include