Re: [PATCH v4 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

crypto: qat - > not > crypto: qat : > > Regards, > > -- > Giovanni > > On Thu, Mar 18, 2021 at 12:21:05PM -0400, Tong Zhang wrote: > > ADF_STATUS_PF_RUNNING is (only) used and checked by adf_vf2pf_shutdown() > > before calling adf_iov_putmsg

[PATCH v5 2/2] crypto: qat - ADF_STATUS_PF_RUNNING should be set after adf_dev_init

qat] [7.183541] adf_vf2pf_shutdown+0x4d/0x7b [intel_qat] [7.183834] adf_dev_shutdown+0x172/0x2b0 [intel_qat] [7.184127] adf_probe+0x5e9/0x600 [qat_dh895xccvf] Signed-off-by: Tong Zhang Reviewed-by: Andy Shevchenko Fixes: 25c6ffb249f6 ("crypto: qat - check if PF is running") Acked

[PATCH v5 1/2] crypto: qat - don't release uninitialized resources

free_irq+0x202/0x380 [1.801340] Call Trace: [1.801477] adf_vf_isr_resource_free+0x32/0xb0 [intel_qat] [1.801785] adf_vf_isr_resource_alloc+0x14d/0x150 [intel_qat] [1.802105] adf_dev_init+0xba/0x140 [intel_qat] Signed-off-by: Tong Zhang Reviewed-by: Andy Shevchenko Fixes: dd0f368398ea

[PATCH v5 0/2] crypto: qat - fix couple crashes duing error handling

by Andy Shevchenko v4: fix commit log typos v5: fix headline Tong Zhang (2): crypto: qat - don't release uninitialized resources crypto: qat - ADF_STATUS_PF_RUNNING should be set after adf_dev_init drivers/crypto/qat/qat_c3xxxvf/adf_drv.c| 4 ++-- drivers/crypto/qat/qat_c

Re: [PATCH v3 1/2] crypto: qat - dont release uninitialized resources

Thanks! I have fixed typos and resent them as v4. - Tong

[PATCH v4 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

qat] [7.183541] adf_vf2pf_shutdown+0x4d/0x7b [intel_qat] [7.183834] adf_dev_shutdown+0x172/0x2b0 [intel_qat] [7.184127] adf_probe+0x5e9/0x600 [qat_dh895xccvf] Signed-off-by: Tong Zhang Reviewed-by: Andy Shevchenko Fixes: 25c6ffb249f6 ("crypto: qat - check if PF is running") Acked

[PATCH v4 1/2] crypto: qat - don't release uninitialized resources

free_irq+0x202/0x380 [1.801340] Call Trace: [1.801477] adf_vf_isr_resource_free+0x32/0xb0 [intel_qat] [1.801785] adf_vf_isr_resource_alloc+0x14d/0x150 [intel_qat] [1.802105] adf_dev_init+0xba/0x140 [intel_qat] Signed-off-by: Tong Zhang Reviewed-by: Andy Shevchenko Fixes: dd0f368398ea

[PATCH v4 0/2] crypto: qat: fix couple crashes duing error handling

by Andy Shevchenko v4: fix commit log typos Tong Zhang (2): crypto: qat - dont release uninitialized resources crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init drivers/crypto/qat/qat_c3xxxvf/adf_drv.c| 4 ++-- drivers/crypto/qat/qat_c62xvf/adf_drv.c | 4

Re: [PATCH v2 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

Thanks Andy, I have sent v3 with the suggested tag fix. - Tong

[PATCH v3 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

qat] [7.183541] adf_vf2pf_shutdown+0x4d/0x7b [intel_qat] [7.183834] adf_dev_shutdown+0x172/0x2b0 [intel_qat] [7.184127] adf_probe+0x5e9/0x600 [qat_dh895xccvf] Signed-off-by: Tong Zhang Reviewed-by: Andy Shevchenko --- drivers/crypto/qat/qat_c3xxxvf/adf_drv.c| 4 ++-- drivers/crypto/

[PATCH v3 1/2] crypto: qat - dont release uninitialized resources

free_irq+0x202/0x380 [1.801340] Call Trace: [1.801477] adf_vf_isr_resource_free+0x32/0xb0 [intel_qat] [1.801785] adf_vf_isr_resource_alloc+0x14d/0x150 [intel_qat] [1.802105] adf_dev_init+0xba/0x140 [intel_qat] Signed-off-by: Tong Zhang Reviewed-by: Andy Shevchenko --- drivers/crypto

[PATCH v3 0/2] crypto: qat: fix couple crashes duing error handling

by Andy Shevchenko Tong Zhang (2): crypto: qat - dont release uninitialized resources crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init drivers/crypto/qat/qat_c3xxxvf/adf_drv.c| 4 ++-- drivers/crypto/qat/qat_c62xvf/adf_drv.c | 4 ++-- drivers/crypto/qat

Re: [PATCH v2 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

Hi Andy, I am not really sure this reviewed by line should be added by me -- IMHO from my past experience this line is added by the actual person who reviewed it on a per-patch and version basis I can send out another revision adding this Reviewed-by line if you think this is something should be do

Re: [PATCH v2 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

Hi Andy, Complete newbie here, could you please remind me of the tag you are referring to? I am not really familiar with the process. Thanks, - Tong On Fri, Mar 12, 2021 at 10:35 AM Andy Shevchenko wrote: > > On Fri, Mar 12, 2021 at 4:21 PM Tong Zhang wrote: > > > > ADF_ST

Re: [PATCH 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

Hi Andy, Thanks for the suggestion. I have removed excessive lines in the commit log and sent out a v2 patch. Thanks again. - Tong On Fri, Mar 12, 2021 at 3:56 AM Andy Shevchenko wrote: > > On Fri, Mar 12, 2021 at 9:50 AM Tong Zhang wrote: > > > > ADF_STATUS_PF_RUNNING

[PATCH v2 1/2] crypto: qat - dont release uninitialized resources

free_irq+0x202/0x380 [1.801340] Call Trace: [1.801477] adf_vf_isr_resource_free+0x32/0xb0 [intel_qat] [1.801785] adf_vf_isr_resource_alloc+0x14d/0x150 [intel_qat] [1.802105] adf_dev_init+0xba/0x140 [intel_qat] Signed-off-by: Tong Zhang --- drivers/crypto/qat/qat_common/adf_vf_isr.c

[PATCH v2 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

qat] [7.183541] adf_vf2pf_shutdown+0x4d/0x7b [intel_qat] [7.183834] adf_dev_shutdown+0x172/0x2b0 [intel_qat] [7.184127] adf_probe+0x5e9/0x600 [qat_dh895xccvf] Signed-off-by: Tong Zhang --- drivers/crypto/qat/qat_c3xxxvf/adf_drv.c| 4 ++-- drivers/crypto/qat/qat_c62xvf/adf_drv.c

[PATCH v2 0/2] crypto: qat: fix couple crashes duing error handling

There are a couple of issues in qat error handling. Those drivers tries to release resources that is not initialized. This patch series tries to fix crashes caused by incorrect error handling. v2: removed excessive dump in commit log Tong Zhang (2): crypto: qat - dont release uninitialized

[PATCH 1/2] crypto: qat - dont release uninitialized resources

DR6: fffe0ff0 DR7: 0400 Signed-off-by: Tong Zhang --- drivers/crypto/qat/qat_common/adf_vf_isr.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/qat/qat_common/adf_vf_isr.c b/drivers/crypto/qat/qat_common/adf_vf_isr.c index

[PATCH 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

372] == Signed-off-by: Tong Zhang --- drivers/crypto/qat/qat_c3xxxvf/adf_drv.c| 4 ++-- drivers/crypto/qat/qat_c62xvf/adf_drv.c | 4 ++-- drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --gi

[PATCH 0/2] crypto: qat: fix couple crashes duing error handling

There are a couple of issues in qat error handling. Those drivers tries to release resources that is not initialized. This patch series tries to fix crashes caused by incorrect error handling. Tong Zhang (2): crypto: qat - dont release uninitialized resources crypto: qat