Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-04-18 Thread Thomas D.
Hi, Milan Broz wrote: > could you please try backported patches here > https://mbroz.fedorapeople.org/tmp/3.18/ ? This patch set works for me and fixes my reported problem (tested against 3.18.30). Thank you! -Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" i

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-04-18 Thread Thomas D.
Hi, Milan's patches apply against 3.18.30, however I am getting build errors: > * CC [M] fs/fat/namei_vfat.o > * CC [M] crypto/algif_hash.o > * LD [M] fs/isofs/isofs.o > * CC [M] crypto/algif_skcipher.o > * LD [M] fs/fat/fat.o > *crypto/algif_hash.c:350:13: warning: initialization from

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-04-17 Thread Thomas D.
Hi, Sasha, can you please revert commit f857638dd72680e2a8faafef7eebb4534cb39fd1 like Greg did with linux-3.10.101 > commit 1f2493fcd87bd810c608aa7976388157852eadb2 > Author: Greg Kroah-Hartman > Date: Sat Mar 12 21:30:16 2016 -0800 > > Revert: "crypto: af_alg - Disallow bind/setkey/... a

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-02-23 Thread Thomas D.
Hi, I have applied Milan's patch on top of 4.1.18. I can reboot and open all of my LUKS-encrypted disks. "cryptsetup benchmark" also works. However, don't we need all the recent changes from "crypto/algif_skcipher.c", too? -Thomas -- To unsubscribe from this list: send the line "unsubscribe lin

Re: Broken userspace crypto in linux-4.1.18

2016-02-20 Thread Thomas D.
Hi, FYI: v3.10.97, v3.14.61 and 3.18.27 are also affected. v4.3.6 works. Looks like the patch set is only compatible with >=linux-4.3. v3.12.54 works because it doesn't contain the patch in question. -Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body

Re: Broken userspace crypto in linux-4.1.18

2016-02-18 Thread Thomas D.
Hi, Jiri Slaby wrote: >> That breakage was expected and forcasted by Milan Broz a couple of days ago >> on >> this mailing list. > > Could you be more specific? What is "this mailing list"? stable or > crypto? I cannot see anything from Milan on this mailing list aka stable. Cannot speak for St

Re: Broken userspace crypto in linux-4.1.18

2016-02-17 Thread Thomas D.
Hi Willy Tarreau wrote: >> Is there a dependency I missed in 4.1? I don't really see anything that >> could have gone wrong there. > > Or maybe Thomas can run a bisect ? I cannot follow. I did a bisect between 4.1.7 and 4.1.8 as I have written in my first mail. The bad commit was: > commit 0571

Re: Broken userspace crypto in linux-4.1.18

2016-02-17 Thread Thomas D.
Hi, Sasha Levin wrote: > So either the upstream patch is broken, or the 4.1 backport is wrong/missing > dependency/missing fix. > > Any chance you could try 4.5-rc3 and see if that works for you? That'll narrow > it down a lot. 4.5-rc3 works for me. Linux-4.4.0 works, too. -Thomas -- To unsu

Broken userspace crypto in linux-4.1.18

2016-02-17 Thread Thomas D.
Hi, something is broken with crypto in linux-4.1.18. On my system I have two disks (sda and sdb), both encrypted with LUKS (cipher=aes-xts-plain64). My rootfs resides encrypted on sda2 (sda1 is an unencrypted boot partition). sdb has one full encrypted partition (sdb1) mounted in "/backup". Aft