[PATCH] MAINTAINERS: .mailmap: Update Sumit Garg's email address

2025-02-27 Thread Sumit Garg
Update Sumit Garg's email address to @kernel.org. Signed-off-by: Sumit Garg --- .mailmap| 1 + MAINTAINERS | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.mailmap b/.mailmap index a897c16d3bae..4a93909286d8 100644 --- a/.mailmap +++ b/.mailmap @@ -689,6 +

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Sumit Garg
Hi Richard, On Wed, 31 Mar 2021 at 03:34, Richard Weinberger wrote: > > Ahmad, > > On Wed, Mar 17, 2021 at 3:08 PM Ahmad Fatoum wrote: > > keyctl add trusted $KEYNAME "load $(cat ~/kmk.blob)" @s > > Is there a reason why we can't pass the desired backend name in the > trusted key parameters?

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Sumit Garg
On Thu, 1 Apr 2021 at 19:29, Richard Weinberger wrote: > > Sumit, > > - Ursprüngliche Mail - > > Von: "Sumit Garg" > > In this case why would one prefer to use CAAM when you have standards > > compliant TPM-Chip which additionally offers sealing to

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Sumit Garg
On Thu, 1 Apr 2021 at 19:00, Ahmad Fatoum wrote: > > Hello Richard, Sumit, > > On 01.04.21 15:17, Richard Weinberger wrote: > > Sumit, > > > > - Ursprüngliche Mail - > >> Von: "Sumit Garg" > >> IIUC, this would require supp

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Sumit Garg
On Thu, 1 Apr 2021 at 15:36, Ahmad Fatoum wrote: > > Hello Richard, > > On 31.03.21 21:36, Richard Weinberger wrote: > > James, > > > > - Ursprüngliche Mail - > >> Von: "James Bottomley" > >> Well, yes. For the TPM, there's a defined ASN.1 format for the keys: > >> > >> https://git.kerne

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-30 Thread Sumit Garg
On Mon, 29 Mar 2021 at 01:07, Jarkko Sakkinen wrote: > > On Sat, Mar 27, 2021 at 01:41:24PM +0100, David Gstir wrote: > > Hi! > > > > > On 25.03.2021, at 06:26, Sumit Garg wrote: > > > > > > On Wed, 24 Mar 2021 at 19:37, Ahmad Fatoum > > &

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-24 Thread Sumit Garg
On Wed, 24 Mar 2021 at 19:37, Ahmad Fatoum wrote: > > Hello Sumit, > > On 24.03.21 11:47, Sumit Garg wrote: > > On Wed, 24 Mar 2021 at 14:56, Ahmad Fatoum wrote: > >> > >> Hello Mimi, > >> > >> On 23.03.21 19:07, Mimi Zohar wrote: >

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-24 Thread Sumit Garg
On Wed, 24 Mar 2021 at 14:56, Ahmad Fatoum wrote: > > Hello Mimi, > > On 23.03.21 19:07, Mimi Zohar wrote: > > On Tue, 2021-03-23 at 17:35 +0100, Ahmad Fatoum wrote: > >> On 21.03.21 21:48, Horia Geantă wrote: > >>> caam has random number generation capabilities, so it's worth using that > >>> by

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-23 Thread Sumit Garg
On Tue, 23 Mar 2021 at 22:04, Ahmad Fatoum wrote: > > Hello Horia, > > On 21.03.21 21:01, Horia Geantă wrote: > > On 3/16/2021 7:02 PM, Ahmad Fatoum wrote: > >> This patch series builds on top of Sumit's rework to have the CAAM as yet > >> another > >> trusted key backend. > >> > > Shouldn't the

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-17 Thread Sumit Garg
Hi Richard, On Wed, 17 Mar 2021 at 04:45, Richard Weinberger wrote: > > Ahmad, > > On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +struct caam_blob_priv *blobifier; > > Who is using this pointer too? > Othe

Re: [PATCH] hwrng: optee -: Use device-managed registration API

2021-02-03 Thread Sumit Garg
g: optee -:/hwrng: optee:/ With that fixed you can add: Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/char/hw_random/optee-rng.c > b/drivers/char/hw_random/optee-rng.c > index a99d829..135a825 100644 > --- a/drivers/char/hw_random/optee-rng.c > +++ b/drivers/char/h

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-06 Thread Sumit Garg
On Thu, 6 Aug 2020 at 13:44, Jorge Ramirez-Ortiz, Foundries wrote: > > On 06/08/20, Sumit Garg wrote: > > On Thu, 6 Aug 2020 at 12:00, Jorge Ramirez-Ortiz, Foundries > > wrote: > > > > > > On 06/08/20, Sumit Garg wrote: > > > > On Thu, 6 A

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Sumit Garg
On Thu, 6 Aug 2020 at 12:00, Jorge Ramirez-Ortiz, Foundries wrote: > > On 06/08/20, Sumit Garg wrote: > > On Thu, 6 Aug 2020 at 02:08, Jorge Ramirez-Ortiz, Foundries > > wrote: > > > > > > On 05/08/20, Sumit Garg wrote: > > > > Apologies for m

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Sumit Garg
On Thu, 6 Aug 2020 at 02:08, Jorge Ramirez-Ortiz, Foundries wrote: > > On 05/08/20, Sumit Garg wrote: > > Apologies for my delayed response as I was busy with some other tasks > > along with holidays. > > no pb! was just making sure this wasnt falling through some cracks.

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Sumit Garg
Apologies for my delayed response as I was busy with some other tasks along with holidays. On Fri, 24 Jul 2020 at 19:53, Jorge Ramirez-Ortiz, Foundries wrote: > > On 24/07/20, Sumit Garg wrote: > > On Thu, 23 Jul 2020 at 14:16, Jorge Ramirez-Ortiz > > wrote: > > > &

Re: [PATCHv2 1/2] hwrng: optee: handle unlimited data rates

2020-07-24 Thread Sumit Garg
ers/char/hw_random/optee-rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Sounds good to me. FWIW: Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/char/hw_random/optee-rng.c > b/drivers/char/hw_random/optee-rng.c > index 49b2e02537dd..5bc4700c4dae 100644 >

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-07-24 Thread Sumit Garg
On Thu, 23 Jul 2020 at 14:16, Jorge Ramirez-Ortiz wrote: > > The current code waits for data to be available before attempting a > second read. However the second read would not be executed as the > while loop exits. > > This fix does not wait if all data has been read and reads a second > time if

Re: Security Random Number Generator support

2020-06-08 Thread Sumit Garg
Hi Neal, On Fri, 5 Jun 2020 at 14:40, Neal Liu wrote: > > On Fri, 2020-06-05 at 09:09 +0100, Russell King - ARM Linux admin wrote: > > On Fri, Jun 05, 2020 at 03:19:03PM +0800, Neal Liu wrote: > > > On Wed, 2020-06-03 at 17:34 +0800, Russell King - ARM Linux admin wrote: > > > > This kind of thin

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

2019-10-17 Thread Sumit Garg
On Thu, 17 Oct 2019 at 00:40, James Bottomley wrote: > > On Wed, 2019-10-16 at 19:25 +0300, Jarkko Sakkinen wrote: > > On Wed, Oct 16, 2019 at 08:34:12AM -0400, James Bottomley wrote: > > > reversible ciphers are generally frowned upon in random number > > > generation, that's why the krng uses ch

[Patch v8 3/4] KEYS: trusted: Create trusted keys subsystem

2019-10-15 Thread Sumit Garg
Move existing code to trusted keys subsystem. Also, rename files with "tpm" as suffix which provides the underlying implementation. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg Reviewed-by: Jarkko Sakkinen --- crypto/asymmetric_keys/asym_tpm.c| 2 +

[Patch v8 2/4] KEYS: Use common tpm_buf for trusted and asymmetric keys

2019-10-15 Thread Sumit Garg
Switch to utilize common heap based tpm_buf code for TPM based trusted and asymmetric keys rather than using stack based tpm1_buf code. Also, remove tpm1_buf code. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg Reviewed-by: Jarkko Sakkinen Reviewed-by: Jerry Snitselaar --- crypto

[Patch v8 4/4] KEYS: trusted: Move TPM2 trusted keys code

2019-10-15 Thread Sumit Garg
ed-by: Jarkko Sakkinen Signed-off-by: Sumit Garg Reviewed-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 56 -- drivers/char/tpm/tpm.h| 11 -- drivers/char/tpm/tpm2-cmd.c | 307 - include/keys/trusted_

[Patch v8 1/4] tpm: Move tpm_buf code to include/linux/

2019-10-15 Thread Sumit Garg
-by: Sumit Garg Reviewed-by: Jarkko Sakkinen Reviewed-by: Jerry Snitselaar --- crypto/asymmetric_keys/asym_tpm.c | 12 +-- drivers/char/tpm/tpm.h| 212 -- include/keys/trusted.h| 12 +-- include/linux/tpm.h | 212

[Patch v8 0/4] Create and consolidate trusted keys subsystem

2019-10-15 Thread Sumit Garg
only Changes in v3: Move TPM2 trusted keys code to trusted keys subsystem. Changes in v2: Split trusted keys abstraction patch for ease of review. Sumit Garg (4): tpm: Move tpm_buf code to include/linux/ KEYS: Use common tpm_buf for trusted and asymmetric keys KEYS: trusted: Create tr

Re: [Patch v7 0/4] Create and consolidate trusted keys subsystem

2019-10-15 Thread Sumit Garg
On Tue, 15 Oct 2019 at 01:46, Jarkko Sakkinen wrote: > > On Fri, Oct 11, 2019 at 02:05:17PM -0700, Jerry Snitselaar wrote: > > On Fri Oct 11 19, Jarkko Sakkinen wrote: > > > On Mon, Oct 07, 2019 at 10:55:31AM +0530, Sumit Garg wrote: > > > > This patch-set does r

Re: [Patch v7 0/4] Create and consolidate trusted keys subsystem

2019-10-15 Thread Sumit Garg
On Tue, 15 Oct 2019 at 01:04, Jarkko Sakkinen wrote: > > On Fri, Oct 11, 2019 at 03:37:57PM +0300, Jarkko Sakkinen wrote: > > On Mon, Oct 07, 2019 at 10:55:31AM +0530, Sumit Garg wrote: > > > This patch-set does restructuring of trusted keys code to create and > >

Re: [PATCH] hwrng: omap - Fix RNG wait loop timeout

2019-10-14 Thread Sumit Garg
On Mon, 14 Oct 2019 at 17:57, Daniel Thompson wrote: > > On Mon, Oct 14, 2019 at 05:32:45PM +0530, Sumit Garg wrote: > > Existing RNG data read timeout is 200us but it doesn't cover EIP76 RNG > > data rate which takes approx. 700us to produce 16 bytes of output data > &g

[PATCH] hwrng: omap - Fix RNG wait loop timeout

2019-10-14 Thread Sumit Garg
rng: omap - Add device variant for SafeXcel IP-76 found in Armada 8K") Cc: Signed-off-by: Sumit Garg --- drivers/char/hw_random/omap-rng.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c in

[Patch v7 4/4] KEYS: trusted: Move TPM2 trusted keys code

2019-10-06 Thread Sumit Garg
ed-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- drivers/char/tpm/tpm-interface.c | 56 -- drivers/char/tpm/tpm.h| 11 -- drivers/char/tpm/tpm2-cmd.c | 307 - include/keys/trusted_tpm.h| 7 + include/

[Patch v7 2/4] KEYS: Use common tpm_buf for trusted and asymmetric keys

2019-10-06 Thread Sumit Garg
Switch to utilize common heap based tpm_buf code for TPM based trusted and asymmetric keys rather than using stack based tpm1_buf code. Also, remove tpm1_buf code. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- crypto/asymmetric_keys/asym_tpm.c | 107

[Patch v7 1/4] tpm: Move tpm_buf code to include/linux/

2019-10-06 Thread Sumit Garg
-by: Sumit Garg --- crypto/asymmetric_keys/asym_tpm.c | 12 +-- drivers/char/tpm/tpm.h| 215 -- include/keys/trusted.h| 12 +-- include/linux/tpm.h | 215 ++ security/keys/trusted.c

[Patch v7 3/4] KEYS: trusted: Create trusted keys subsystem

2019-10-06 Thread Sumit Garg
Move existing code to trusted keys subsystem. Also, rename files with "tpm" as suffix which provides the underlying implementation. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg Reviewed-by: Jarkko Sakkinen --- crypto/asymmetric_keys/asym_tpm.c| 2 +

[Patch v7 0/4] Create and consolidate trusted keys subsystem

2019-10-06 Thread Sumit Garg
hanges in v2: Split trusted keys abstraction patch for ease of review. Sumit Garg (4): tpm: Move tpm_buf code to include/linux/ KEYS: Use common tpm_buf for trusted and asymmetric keys KEYS: trusted: Create trusted keys subsystem KEYS: trusted: Move TPM2 trusted keys code crypto/asymme

Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

2019-10-03 Thread Sumit Garg
Hi Jarkko, On Wed, 25 Sep 2019 at 06:41, Jarkko Sakkinen wrote: > > On Wed, Sep 18, 2019 at 11:53:08AM +0530, Sumit Garg wrote: > > No worries :). I will send next version of patch-set. > > > > FYI, I will be travelling for Linaro Connect next week so you could >

Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

2019-09-17 Thread Sumit Garg
On Tue, 17 Sep 2019 at 23:45, Jarkko Sakkinen wrote: > > On Tue, Sep 17, 2019 at 09:14:15PM +0300, Jarkko Sakkinen wrote: > > On Mon, Sep 16, 2019 at 04:04:24PM +0530, Sumit Garg wrote: > > > Move TPM2 trusted keys code to trusted keys subsystem. The reason > > > be

[Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

2019-09-16 Thread Sumit Garg
Move TPM2 trusted keys code to trusted keys subsystem. The reason being it's better to consolidate all the trusted keys code to a single location so that it can be maintained sanely. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg Reviewed-by: Jarkko Sakkinen --- drivers/char/tp

[Patch v6 3/4] KEYS: trusted: Create trusted keys subsystem

2019-09-16 Thread Sumit Garg
Move existing code to trusted keys subsystem. Also, rename files with "tpm" as suffix which provides the underlying implementation. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg Reviewed-by: Jarkko Sakkinen --- crypto/asymmetric_keys/asym_tpm.c| 2 +

[Patch v6 2/4] KEYS: Use common tpm_buf for trusted and asymmetric keys

2019-09-16 Thread Sumit Garg
Switch to utilize common heap based tpm_buf code for TPM based trusted and asymmetric keys rather than using stack based tpm1_buf code. Also, remove tpm1_buf code. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- crypto/asymmetric_keys/asym_tpm.c | 107

[Patch v6 1/4] tpm: Move tpm_buf code to include/linux/

2019-09-16 Thread Sumit Garg
-by: Sumit Garg --- crypto/asymmetric_keys/asym_tpm.c | 12 +-- drivers/char/tpm/tpm.h| 214 -- include/keys/trusted.h| 12 +-- include/linux/tpm.h | 214 ++ security/keys/trusted.c

[Patch v6 0/4] Create and consolidate trusted keys subsystem

2019-09-16 Thread Sumit Garg
mmon tpm_buf 3. Keep module name as trusted.ko only Changes in v3: Move TPM2 trusted keys code to trusted keys subsystem. Changes in v2: Split trusted keys abstraction patch for ease of review. Sumit Garg (4): tpm: Move tpm_buf code to include/linux/ KEYS: Use common tpm_buf for trusted

Re: [PATCH] KEYS: asym_tpm: Use common tpm_buf for asymmetric keys

2019-09-15 Thread Sumit Garg
On Fri, 13 Sep 2019 at 19:01, Jarkko Sakkinen wrote: > > On Wed, Sep 11, 2019 at 04:51:50PM +0530, Sumit Garg wrote: > > Switch to utilize common heap based tpm_buf code for TPM based > > asymmetric keys rather than using stack based tpm_buf code. > > > >

[PATCH] KEYS: asym_tpm: Use common tpm_buf for asymmetric keys

2019-09-11 Thread Sumit Garg
Switch to utilize common heap based tpm_buf code for TPM based asymmetric keys rather than using stack based tpm_buf code. Reported-by: kbuild test robot Signed-off-by: Sumit Garg --- crypto/asymmetric_keys/asym_tpm.c | 99 --- 1 file changed, 41 insertions

Re: [RFC/RFT v4 5/5] KEYS: trusted: Add generic trusted keys framework

2019-09-01 Thread Sumit Garg
On Fri, 30 Aug 2019 at 22:54, Jarkko Sakkinen wrote: > > On Fri, Aug 30, 2019 at 08:20:31PM +0300, Jarkko Sakkinen wrote: > > On Fri, Aug 30, 2019 at 02:49:31PM +0530, Sumit Garg wrote: > > > Any comments/feedback on this patch before I send next version of TEE > >

Re: [RFC/RFT v4 5/5] KEYS: trusted: Add generic trusted keys framework

2019-08-30 Thread Sumit Garg
On Tue, 13 Aug 2019 at 13:24, Sumit Garg wrote: > > Current trusted keys framework is tightly coupled to use TPM device as > an underlying implementation which makes it difficult for implementations > like Trusted Execution Environment (TEE) etc. to provide trusked keys > support i

Re: [PATCH v5 4/4] KEYS: trusted: move tpm2 trusted keys code

2019-08-27 Thread Sumit Garg
On Tue, 27 Aug 2019 at 19:47, Jarkko Sakkinen wrote: > > On Wed, Aug 21, 2019 at 06:29:05PM +0530, Sumit Garg wrote: > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * Copyright (C) 2004 IBM Corporation > > + * Copyright (C) 2014 Intel Corporation >

[PATCH v5 4/4] KEYS: trusted: move tpm2 trusted keys code

2019-08-21 Thread Sumit Garg
Move TPM2 trusted keys code to trusted keys subsystem. The reason being it's better to consolidate all the trusted keys code to a single location so that it can be maintained sanely. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- drivers/char/tpm/tpm-chip.c

[PATCH v5 2/4] KEYS: trusted: use common tpm_buf for TPM1.x code

2019-08-21 Thread Sumit Garg
Utilize common heap based tpm_buf code for TPM1.x trusted keys rather than using stack based tpm1_buf code. Also, remove tpm1_buf code. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg Reviewed-by: Jarkko Sakkinen --- include/keys/trusted.h | 37 +-- security/keys

[PATCH v5 3/4] KEYS: trusted: create trusted keys subsystem

2019-08-21 Thread Sumit Garg
Move existing code to trusted keys subsystem. Also, rename files with "tpm" as suffix which provides the underlying implementation. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- crypto/asymmetric_keys/asym_tpm.c| 2 +- incl

[PATCH v5 1/4] tpm: move tpm_buf code to include/linux/

2019-08-21 Thread Sumit Garg
Move tpm_buf code to common include/linux/tpm.h header so that it can be reused via other subsystems like trusted keys etc. Also rename trusted keys TPM 1.x buffer implementation to tpm1_buf to avoid any compilation errors. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- drivers

[PATCH v5 0/4] Create and consolidate trusted keys subsystem

2019-08-21 Thread Sumit Garg
trusted keys code to trusted keys subsystem. Changes in v2: Split trusted keys abstraction patch for ease of review. Sumit Garg (4): tpm: move tpm_buf code to include/linux/ KEYS: trusted: use common tpm_buf for TPM1.x code KEYS: trusted: create trusted keys subsystem KEYS: trusted: move tp

Re: [RFC/RFT v4 4/5] KEYS: trusted: move tpm2 trusted keys code

2019-08-19 Thread Sumit Garg
On Mon, 19 Aug 2019 at 22:37, Jarkko Sakkinen wrote: > > On Tue, Aug 13, 2019 at 01:23:03PM +0530, Sumit Garg wrote: > > Move TPM2 trusted keys code to trusted keys subsystem. The reason > > being it's better to consolidate all the trusted keys code to a single > &g

Re: [RFC/RFT v4 3/5] KEYS: trusted: create trusted keys subsystem

2019-08-19 Thread Sumit Garg
On Mon, 19 Aug 2019 at 22:36, Jarkko Sakkinen wrote: > > On Mon, Aug 19, 2019 at 08:04:58PM +0300, Jarkko Sakkinen wrote: > > On Tue, Aug 13, 2019 at 01:23:02PM +0530, Sumit Garg wrote: > > > Move existing code to trusted keys subsystem. Also, rename files with > &

Re: [RFC/RFT v4 1/5] tpm: move tpm_buf code to include/linux/

2019-08-19 Thread Sumit Garg
On Mon, 19 Aug 2019 at 22:26, Jarkko Sakkinen wrote: > > On Tue, Aug 13, 2019 at 01:23:00PM +0530, Sumit Garg wrote: > > Move tpm_buf code to common include/linux/tpm.h header so that it can > > be reused via other subsystems like trusted keys etc. > > > > Also rena

Re: [RFC/RFT v4 0/5] Add generic trusted keys framework/subsystem

2019-08-19 Thread Sumit Garg
On Mon, 19 Aug 2019 at 22:24, Jarkko Sakkinen wrote: > > On Tue, Aug 13, 2019 at 01:22:59PM +0530, Sumit Garg wrote: > > This patch-set is an outcome of discussion here [1]. It has evolved very > > much since v1 to create, consolidate and generalize trusted keys > >

Re: [RFC/RFT v4 0/5] Add generic trusted keys framework/subsystem

2019-08-15 Thread Sumit Garg
On Thu, 15 Aug 2019 at 20:36, Mimi Zohar wrote: > > On Thu, 2019-08-15 at 18:33 +0530, Sumit Garg wrote: > > Hi Mimi, > > > > On Wed, 14 Aug 2019 at 18:54, Mimi Zohar wrote: > > > > > > Hi Sumit, > > > > > > On Tue, 2019-08-13 at

Re: [RFC/RFT v4 0/5] Add generic trusted keys framework/subsystem

2019-08-15 Thread Sumit Garg
Hi Mimi, On Wed, 14 Aug 2019 at 18:54, Mimi Zohar wrote: > > Hi Sumit, > > On Tue, 2019-08-13 at 13:22 +0530, Sumit Garg wrote: > > This patch-set is an outcome of discussion here [1]. It has evolved very > > much since v1 to create, consolidate and generalize tr

Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code

2019-08-13 Thread Sumit Garg
On Thu, 8 Aug 2019 at 20:46, Jarkko Sakkinen wrote: > > On Thu, Aug 08, 2019 at 06:51:38PM +0530, Sumit Garg wrote: > > It seems to be a functional change which I think requires proper unit > > testing. I am afraid that I don't posses a TPM device to test this and > &

[RFC/RFT v4 3/5] KEYS: trusted: create trusted keys subsystem

2019-08-13 Thread Sumit Garg
Move existing code to trusted keys subsystem. Also, rename files with "tpm" as suffix which provides the underlying implementation. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- crypto/asymmetric_keys/asym_tpm.c | 2 +- include/keys/

[RFC/RFT v4 5/5] KEYS: trusted: Add generic trusted keys framework

2019-08-13 Thread Sumit Garg
o add generic trusted keys framework where underlying implemtations like TPM, TEE etc. could be easily plugged-in. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- include/keys/trusted-type.h | 45 include/keys/trusted_tpm.h | 15 -- security

[RFC/RFT v4 4/5] KEYS: trusted: move tpm2 trusted keys code

2019-08-13 Thread Sumit Garg
Move TPM2 trusted keys code to trusted keys subsystem. The reason being it's better to consolidate all the trusted keys code to a single location so that it can be maintained sanely. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- drivers/char/tpm/tpm-chip.c

[RFC/RFT v4 0/5] Add generic trusted keys framework/subsystem

2019-08-13 Thread Sumit Garg
tpm_buf 3. Keep module name as trusted.ko only Changes in v3: Move TPM2 trusted keys code to trusted keys subsystem. Changes in v2: Split trusted keys abstraction patch for ease of review. Sumit Garg (5): tpm: move tpm_buf code to include/linux/ KEYS: trusted: use common tpm_buf for TPM1.x c

[RFC/RFT v4 1/5] tpm: move tpm_buf code to include/linux/

2019-08-13 Thread Sumit Garg
Move tpm_buf code to common include/linux/tpm.h header so that it can be reused via other subsystems like trusted keys etc. Also rename trusted keys TPM 1.x buffer implementation to tpm1_buf to avoid any compilation errors. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- drivers

[RFC/RFT v4 2/5] KEYS: trusted: use common tpm_buf for TPM1.x code

2019-08-13 Thread Sumit Garg
Utilize common heap based tpm_buf code for TPM1.x trusted keys rather than using stack based tpm1_buf code. Also, remove tpm1_buf code. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- include/keys/trusted.h | 37 +-- security/keys/trusted.c | 98

Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code

2019-08-08 Thread Sumit Garg
On Thu, 8 Aug 2019 at 00:33, Jarkko Sakkinen wrote: > > On Tue, Aug 06, 2019 at 07:07:19PM +0530, Sumit Garg wrote: > > Move TPM2 trusted keys code to trusted keys subsystem. > > Missing a long description. The reason is that it is better consolidate > all trusted keys code

Re: [RFC/RFT v3 1/3] KEYS: trusted: create trusted keys subsystem

2019-08-08 Thread Sumit Garg
On Thu, 8 Aug 2019 at 00:29, Jarkko Sakkinen wrote: > > On Tue, Aug 06, 2019 at 07:07:18PM +0530, Sumit Garg wrote: > > Move existing code to trusted keys subsystem. Also, rename files with > > "tpm" as suffix which provides the underlying implementation. > >

Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code

2019-08-06 Thread Sumit Garg
On Tue, 6 Aug 2019 at 19:13, Greg KH wrote: > > On Tue, Aug 06, 2019 at 07:07:19PM +0530, Sumit Garg wrote: > > Move TPM2 trusted keys code to trusted keys subsystem. > > > > Suggested-by: Jarkko Sakkinen > > Signed-off-by: Sumit Garg > > --- > > drive

[RFC/RFT v3 0/3] KEYS: trusted: Add generic trusted keys framework

2019-08-06 Thread Sumit Garg
[1] https://www.mail-archive.com/linux-doc@vger.kernel.org/msg30591.html Changes in v3: Move TPM2 trusted keys code to trusted keys subsystem. Changes in v2: Split trusted keys abstraction patch for ease of review. Sumit Garg (3): KEYS: trusted: create trusted keys subsystem KEYS: trusted: move tp

[RFC/RFT v3 1/3] KEYS: trusted: create trusted keys subsystem

2019-08-06 Thread Sumit Garg
Move existing code to trusted keys subsystem. Also, rename files with "tpm" as suffix which provides the underlying implementation. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- crypto/asymmetric_keys/asym_tpm.c | 2 +- include/keys/

[RFC/RFT v3 3/3] KEYS: trusted: Add generic trusted keys framework

2019-08-06 Thread Sumit Garg
o add generic trusted keys framework where underlying implemtations like TPM, TEE etc. could be easily plugged-in. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- include/keys/trusted-type.h | 45 include/keys/trusted_tpm.h | 15 -- security/keys/tr

[RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code

2019-08-06 Thread Sumit Garg
Move TPM2 trusted keys code to trusted keys subsystem. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- drivers/char/tpm/tpm-interface.c | 56 - drivers/char/tpm/tpm.h| 224 -- drivers/char/tpm/tpm2-cmd.c | 307

Re: [RFC/RFT v2 1/2] KEYS: trusted: create trusted keys subsystem

2019-08-04 Thread Sumit Garg
On Sat, 3 Aug 2019 at 01:08, Jarkko Sakkinen wrote: > > On Fri, Aug 02, 2019 at 11:20:09AM +0530, Sumit Garg wrote: > > On Thu, 1 Aug 2019 at 22:54, Jarkko Sakkinen > > wrote: > > > > > > On Thu, Jul 18, 2019 at 04:54:45PM +0530, Sumit Garg wrote: > &

Re: [RFC/RFT v2 1/2] KEYS: trusted: create trusted keys subsystem

2019-08-01 Thread Sumit Garg
On Thu, 1 Aug 2019 at 22:54, Jarkko Sakkinen wrote: > > On Thu, Jul 18, 2019 at 04:54:45PM +0530, Sumit Garg wrote: > > Move existing code to trusted keys subsystem. Also, rename files with > > "tpm" as suffix which provides the underlying implementation. > >

[RFC/RFT v2 1/2] KEYS: trusted: create trusted keys subsystem

2019-07-18 Thread Sumit Garg
Move existing code to trusted keys subsystem. Also, rename files with "tpm" as suffix which provides the underlying implementation. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- crypto/asymmetric_keys/asym_tpm.c | 2 +- include/keys/

[RFC/RFT v2 2/2] KEYS: trusted: Add generic trusted keys framework

2019-07-18 Thread Sumit Garg
o add generic trusted keys framework where underlying implemtations like TPM, TEE etc. could be easily plugged-in. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- include/keys/trusted-type.h | 45 include/keys/trusted_tpm.h | 15 -- security/keys/tr

[RFC/RFT v2 0/2] KEYS: trusted: Add generic trusted keys framework

2019-07-18 Thread Sumit Garg
[1] https://www.mail-archive.com/linux-doc@vger.kernel.org/msg30591.html Changes in v2: Split trusted keys abstraction patch for ease of review. Sumit Garg (2): KEYS: trusted: create trusted keys subsystem KEYS: trusted: Add generic trusted keys framework crypto/asymmetric_keys/

Re: [RFC/RFT] KEYS: trusted: Add generic trusted keys framework

2019-07-11 Thread Sumit Garg
On Fri, 12 Jul 2019 at 00:52, Jarkko Sakkinen wrote: > > On Fri, Jul 05, 2019 at 08:02:34PM +0530, Sumit Garg wrote: > > Current trusted keys framework is tightly coupled to use TPM device as > > an underlying implementation which makes it difficult for implementations > >

[RFC/RFT] KEYS: trusted: Add generic trusted keys framework

2019-07-05 Thread Sumit Garg
o add generic trusted keys framework where underlying implemtations like TPM, TEE etc. could be easily plugged-in. Suggested-by: Jarkko Sakkinen Signed-off-by: Sumit Garg --- This patch is an outcome of discussion here [1]. I have tested this framework with trusted keys support provided via TEE

Re: [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static

2019-02-20 Thread Sumit Garg
On Wed, 20 Feb 2019 at 22:03, Greg Kroah-Hartman wrote: > > On Wed, Feb 20, 2019 at 09:55:50PM +0530, Sumit Garg wrote: > > Hi Arnd, > > > > On Wed, 20 Feb 2019 at 21:04, Arnd Bergmann wrote: > > > > > > On Wed, Feb 20, 2019 at 12:17 PM Sumit Garg wro

Re: [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static

2019-02-20 Thread Sumit Garg
Hi Arnd, On Wed, 20 Feb 2019 at 21:04, Arnd Bergmann wrote: > > On Wed, Feb 20, 2019 at 12:17 PM Sumit Garg wrote: > > > > On Wed, 20 Feb 2019 at 16:19, Colin Ian King > > wrote: > > > > > > On 20/02/2019 10:37, Ard Biesheuvel wrote: > > >

Re: [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static

2019-02-20 Thread Sumit Garg
On Wed, 20 Feb 2019 at 16:19, Colin Ian King wrote: > > On 20/02/2019 10:37, Ard Biesheuvel wrote: > > On Wed, 20 Feb 2019 at 11:34, Sumit Garg wrote: > >> > >> On Wed, 20 Feb 2019 at 14:51, Wei Yongjun wrote: > >>> > >>> Fixes the follow

Re: [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static

2019-02-20 Thread Sumit Garg
On Wed, 20 Feb 2019 at 14:51, Wei Yongjun wrote: > > Fixes the following sparse warning: > > drivers/char/hw_random/optee-rng.c:265:35: warning: > symbol 'optee_rng_id_table' was not declared. Should it be static? > I haven't observed this warning during my normal Linux build using gcc. Is there

Re: [PATCH -next] hwrng: Fix unsigned comparison with less than zero

2019-02-18 Thread Sumit Garg
an int. > > Detected by Coccinelle ("Unsigned expression compared with zero: > ret < 0") > > Fixes: 5fe8b1cc6a03 ("hwrng: add OP-TEE based rng driver") > Signed-off-by: YueHaibing Reviewed-by: Sumit Garg > --- > drivers/char/hw_random/optee-rng.c |

Re: [PATCH] hwrng: optee: Initialize some structs using memset instead of braces

2019-02-18 Thread Sumit Garg
7539.da...@davemloft.net/ > > Fixes: 5fe8b1cc6a03 ("hwrng: add OP-TEE based rng driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/369 > Signed-off-by: Nathan Chancellor Reviewed-by: Sumit Garg > --- > drivers/char/hw_random/optee-rng.c | 18

Re: [PATCH v6 0/4] Introduce TEE bus driver framework

2019-02-12 Thread Sumit Garg
On Tue, 12 Feb 2019 at 17:41, Ard Biesheuvel wrote: > > On Tue, 12 Feb 2019 at 13:09, Sumit Garg wrote: > > > > On Tue, 12 Feb 2019 at 16:35, Ard Biesheuvel > > wrote: > > > > > > On Tue, 29 Jan 2019 at 06:50, Sumit Garg wrote: > > > > &

Re: [PATCH v6 0/4] Introduce TEE bus driver framework

2019-02-12 Thread Sumit Garg
On Tue, 12 Feb 2019 at 16:35, Ard Biesheuvel wrote: > > On Tue, 29 Jan 2019 at 06:50, Sumit Garg wrote: > > > > This series introduces a generic TEE bus driver concept for TEE based > > kernel drivers which would like to communicate with TEE based devices/ > > servi

Re: [PATCH v6 3/4] tee: optee: add TEE bus device enumeration support

2019-02-01 Thread Sumit Garg
On Fri, 1 Feb 2019 at 13:58, Jens Wiklander wrote: > > On Tue, Jan 29, 2019 at 11:19:37AM +0530, Sumit Garg wrote: > > OP-TEE provides a pseudo TA to enumerate TAs which can act as devices/ > > services for TEE bus. So implement device enumeration using invoke > > funct

Re: [PATCH v6 0/4] Introduce TEE bus driver framework

2019-01-31 Thread Sumit Garg
On Thu, 31 Jan 2019 at 17:36, Herbert Xu wrote: > > On Thu, Jan 31, 2019 at 09:41:43AM +0100, Jens Wiklander wrote: > > > > I think this patch series is good now. It has received comments which > > has been addressed and have also gathered a few R-B tags. > > > > All patches but "hwrng: add OP-TEE

[PATCH v6 3/4] tee: optee: add TEE bus device enumeration support

2019-01-28 Thread Sumit Garg
ot; device. Signed-off-by: Sumit Garg Reviewed-by: Daniel Thompson --- drivers/tee/optee/Makefile| 1 + drivers/tee/optee/core.c | 4 + drivers/tee/optee/device.c| 155 ++ drivers/tee/optee/optee_private.h | 3 + 4 files ch

[PATCH v6 4/4] hwrng: add OP-TEE based rng driver

2019-01-28 Thread Sumit Garg
rvice. This driver registers on TEE bus to interact with OP-TEE based rng device/service. Signed-off-by: Sumit Garg --- MAINTAINERS| 5 + drivers/char/hw_random/Kconfig | 15 ++ drivers/char/hw_random/Makefile| 1 + drivers/char/hw_random/optee-rng.c

[PATCH v6 0/4] Introduce TEE bus driver framework

2019-01-28 Thread Sumit Garg
amework. 2. Added OP-TEE based device enumeration. 3. Register optee-rng driver as TEE bus driver. 4. Removed DT dependency for optee-rng device UUID. 5. Added supp_nowait flag. Sumit Garg (4): tee: add bus driver framework for TEE based devices tee: add supp_nowait flag in tee_context struct

[PATCH v6 2/4] tee: add supp_nowait flag in tee_context struct

2019-01-28 Thread Sumit Garg
uses TEE internal client interface. Signed-off-by: Sumit Garg Reviewed-by: Daniel Thompson --- drivers/tee/optee/supp.c | 10 +- drivers/tee/tee_core.c | 13 + include/linux/tee_drv.h | 6 ++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/tee

[PATCH v6 1/4] tee: add bus driver framework for TEE based devices

2019-01-28 Thread Sumit Garg
enumeration to be specific to corresponding TEE implementation like OP-TEE etc. Signed-off-by: Sumit Garg Reviewed-by: Daniel Thompson Reviewed-by: Bhupesh Sharma --- drivers/tee/tee_core.c| 54 --- include/linux/mod_devicetable.h | 9

Re: [PATCH v5 4/4] hwrng: add OP-TEE based rng driver

2019-01-27 Thread Sumit Garg
Hi Herbert, On Thu, 24 Jan 2019 at 11:25, Sumit Garg wrote: > > On ARM SoC's with TrustZone enabled, peripherals like entropy sources > might not be accessible to normal world (linux in this case) and rather > accessible to secure world (OP-TEE in this case) only. So this

Re: [PATCH v5 4/4] hwrng: add OP-TEE based rng driver

2019-01-24 Thread Sumit Garg
On Thu, 24 Jan 2019 at 18:01, Daniel Thompson wrote: > > On Thu, Jan 24, 2019 at 11:24:39AM +0530, Sumit Garg wrote: > > On ARM SoC's with TrustZone enabled, peripherals like entropy sources > > might not be accessible to normal world (linux in this case) and rather > &g

Re: [PATCH v5 3/4] tee: optee: add TEE bus device enumeration support

2019-01-24 Thread Sumit Garg
On Thu, 24 Jan 2019 at 15:45, Daniel Thompson wrote: > > On Thu, Jan 24, 2019 at 11:24:38AM +0530, Sumit Garg wrote: > > OP-TEE provides a pseudo TA to enumerate TAs which can act as devices/ > > services for TEE bus. So implement device enumeration using invoke > > funct

Re: [PATCH v5 1/4] tee: add bus driver framework for TEE based devices

2019-01-24 Thread Sumit Garg
On Thu, 24 Jan 2019 at 15:15, Daniel Thompson wrote: > > On Thu, Jan 24, 2019 at 11:24:36AM +0530, Sumit Garg wrote: > > Introduce a generic TEE bus driver concept for TEE based kernel drivers > > which would like to communicate with TEE based devices/services. Also > &g

[PATCH v5 2/4] tee: add supp_nowait flag in tee_context struct

2019-01-23 Thread Sumit Garg
uses TEE internal client interface. Signed-off-by: Sumit Garg --- drivers/tee/optee/supp.c | 10 +- drivers/tee/tee_core.c | 13 + include/linux/tee_drv.h | 6 ++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/tee/optee/supp.c b/drivers/tee/optee

[PATCH v5 0/4] Introduce TEE bus driver framework

2019-01-23 Thread Sumit Garg
on review comments, the scope of this series has increased as follows: 1. Added TEE bus driver framework. 2. Added OP-TEE based device enumeration. 3. Register optee-rng driver as TEE bus driver. 4. Removed DT dependency for optee-rng device UUID. 5. Added supp_nowait flag. Sumit Garg (4): tee: add

[PATCH v5 3/4] tee: optee: add TEE bus device enumeration support

2019-01-23 Thread Sumit Garg
ot; device. Signed-off-by: Sumit Garg --- drivers/tee/optee/Makefile| 1 + drivers/tee/optee/core.c | 4 + drivers/tee/optee/device.c| 153 ++ drivers/tee/optee/optee_private.h | 3 + 4 files changed, 161 insertions(+) create m

[PATCH v5 4/4] hwrng: add OP-TEE based rng driver

2019-01-23 Thread Sumit Garg
rvice. This driver registers on TEE bus to interact with OP-TEE based rng device/service. Signed-off-by: Sumit Garg --- MAINTAINERS| 5 + drivers/char/hw_random/Kconfig | 15 ++ drivers/char/hw_random/Makefile| 1 + drivers/char/hw_random/optee-rng.c

  1   2   >