Re: [PATCH v5 7/7] fs: cifs: switch to RC4 library interface

2019-06-18 Thread Steve French
Acked-by: Steve French On Wed, Jun 12, 2019 at 1:06 PM Ard Biesheuvel wrote: > > The CIFS code uses the sync skcipher API to invoke the ecb(arc4) skcipher, > of which only a single generic C code implementation exists. This means > that going through all the trouble of using scat

Re: [PATCH v2 7/7] fs: cifs: switch to RC4 library interface

2019-06-10 Thread Steve French
On Mon, Jun 10, 2019 at 1:02 PM Ard Biesheuvel wrote: > On Mon, 10 Jun 2019 at 19:54, Steve French wrote: > > Yes - when I tested the GCM code in cifs.ko last week (the two patches > > are currently > > in the cifs-2.6.git for-next branch and thus in linux-next and are

Re: [PATCH v2 7/7] fs: cifs: switch to RC4 library interface

2019-06-10 Thread Steve French
On Mon, Jun 10, 2019 at 11:17 AM Eric Biggers wrote: > > Hi Steve, > > On Sun, Jun 09, 2019 at 05:03:25PM -0500, Steve French wrote: > > Probably harmless to change this code path (build_ntlmssp_auth_blob is > > called at session negotiation time so shouldn't have muc

Re: [PATCH v2 7/7] fs: cifs: switch to RC4 library interface

2019-06-09 Thread Steve French
lists etc buys us > very little, and we're better off just invoking the arc4 library directly. > > Cc: linux-c...@vger.kernel.org > Cc: Steve French > Signed-off-by: Ard Biesheuvel > --- > fs/cifs/Kconfig | 2 +- > fs/cifs/cifsencrypt.c | 50 +--- >

Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack

2016-12-14 Thread Steve French
merged into cifs-2.6.git for-next On Tue, Dec 13, 2016 at 7:07 AM, Jeff Layton wrote: > On Mon, 2016-12-12 at 12:54 -0800, Andy Lutomirski wrote: >> smbencrypt() points a scatterlist to the stack, which is breaks if >> CONFIG_VMAP_STACK=y. >> >> Fix it by switching to crypto_cipher_encrypt_one().