Re: [PATCH] ARM: convert all "mov.* pc, reg" to "bx reg" for ARMv6+ (part1)

2014-07-01 Thread Stephen Warren
iecemeal, and miss some instances, change all > the "mov pc" instances to use the new macro, with the exception of > the "movs" instruction and the kprobes code. This allows us to detect > the "mov pc, lr" case and fix it up - and also gives us the possibilit

[PATCH] crypto: tegra: remove driver

2014-02-18 Thread Stephen Warren
From: Stephen Warren This driver has never been hooked up in any board file, and cannot be instantiated via device tree. I've been told that, at least on Tegra20, the HW is slower at crypto than the main CPU. I have no test-case for it. Hence, remove it. Cc: Varun Wadekar Signed-o

[PATCH] ARM: tegra: remove tegra_chip_uid()

2013-09-16 Thread Stephen Warren
From: Stephen Warren Following commit f5b38c5 "crypto: tegra - use kernel entropy instead of ad-hoc", this function is no longer used. It's also only accurate for Tegra20 and not later SoCs. So, remove it. Signed-off-by: Stephen Warren --- Herbert, this is a patch for the crypto

Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-16 Thread Stephen Warren
On 09/13/2013 05:39 PM, Herbert Xu wrote: > On Fri, Sep 13, 2013 at 10:12:36AM -0600, Stephen Warren wrote: >> >> I'm curious which kernel version it was merged for; it'd be nice to >> remove tegra_chip_uid() from the Tegra tree now since it's unused, but >

Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-13 Thread Stephen Warren
On 09/13/2013 06:23 AM, Herbert Xu wrote: > On Mon, Sep 09, 2013 at 10:02:04AM -0600, Stephen Warren wrote: >> On 09/09/2013 01:35 AM, Linus Walleij wrote: >>> The way I read the Tegra AES RNG is that it has a homebrew >>> algorithm for initializing the 128bit RNG using

Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-09 Thread Stephen Warren
run, can you please comment? Acked-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch] crypto: tegra-aes - bitwise vs logical and

2013-08-20 Thread Stephen Warren
On 08/20/2013 02:54 AM, Dan Carpenter wrote: > The bug here is that: > > while (eng_busy & (!icq_empty) & dma_busy) > > is never true because it's using bitwise instead of logical ANDs. The > other bitwise AND conditions work as intended but I changed them as well > for consistency. > > S

Re: [PATCH] crypto: tegra: remove include of

2012-10-15 Thread Stephen Warren
On 10/15/2012 08:33 AM, Herbert Xu wrote: > On Tue, Oct 02, 2012 at 04:17:40PM -0600, Stephen Warren wrote: >> From: Stephen Warren >> >> Nothing from this file is used, and the file will hopefully be deleted >> soon. >> >> Signed-off-by: Stephen War

[PATCH] crypto: tegra: remove include of

2012-10-02 Thread Stephen Warren
From: Stephen Warren Nothing from this file is used, and the file will hopefully be deleted soon. Signed-off-by: Stephen Warren --- Herbert, if this patch can get into 3.7 (it's late, I know) then that would be great. If not, may I please request an ack so I can take the change throug

RE: [PATCH v8 0/2] crypto: driver for Tegra AES hardware

2011-12-16 Thread Stephen Warren
Varun Wadekar wrote at Friday, December 16, 2011 4:26 AM: > The tegra crypto driver uses the tegra_chip_uid API for the RNG > calculation. If one wants to build tegra-aes as a module, then > tegra_chip_uid needs to be exported. Varun, I notice you didn't CC any of the maintainers of the crypto or

RE: [PATCH v7 2/2] crypto: driver for Tegra AES hardware

2011-11-18 Thread Stephen Warren
Jamie Iles wrote at Friday, November 18, 2011 3:03 AM: > On Fri, Nov 18, 2011 at 11:12:33AM +0530, Varun Wadekar wrote: > > driver supports ecb/cbc/ofb/ansi_x9.31rng modes, > > 128, 192 and 256-bit key sizes > > +static int tegra_aes_probe(struct platform_device *pdev) ... > > + dev_info(dev, "r

RE: [PATCH v1] arm: tegra: export tegra_chip_uid

2011-11-15 Thread Stephen Warren
Varun Wadekar wrote at Monday, November 14, 2011 9:20 PM: > The crypto driver will need this api to use > it in the RNG calculations. In order to build > the crypto driver as a module, tegra_chip_uid > has to be exported. > > Original author: Henning Heinold You should drop that line from the pa

RE: [PATCH v1] crypto: driver for tegra AES hardware

2011-11-15 Thread Stephen Warren
Varun Wadekar wrote at Monday, November 14, 2011 9:11 PM: > >> Why? > > To avoid redundant work; there's little point memset()ing a region that's > > going to be copied over the top of immediately afterwards. > > > > The length used for memset is different from the length being copied > over. I am

RE: [PATCH v3] crypto: driver for tegra AES hardware

2011-11-14 Thread Stephen Warren
vwade...@nvidia.com wrote at Saturday, November 12, 2011 3:43 AM: > driver supports ecb/cbc/ofb/ansi_x9.31rng modes, > 128, 192 and 256-bit key sizes This will fail to build as a module unless your other patch "arm: tegra: export tegra_chip_uid" is also merged. You should mention this fact when po

RE: [PATCH v1] crypto: driver for tegra AES hardware

2011-11-14 Thread Stephen Warren
Varun Wadekar wrote at Saturday, November 12, 2011 3:23 AM: > >> + /* assign new context to device */ > >> + ctx->dd = dd; > >> + dd->ctx = ctx; > >> + > >> + if (ctx->flags & FLAGS_NEW_KEY) { > >> + /* copy the key */ > >> + memset(dd->ivkey_base, 0, AES_HW_KEY_TABLE_LENGTH_B

RE: [PATCH] crypto: driver for tegra AES hardware

2011-11-07 Thread Stephen Warren
Varun Wadekar wrote at Saturday, November 05, 2011 2:12 AM: > >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > Don't you need to call request_mem_region() between get_resource() and > > ioremap()? > > I am remapping the module register space. Used IORESOURCE_IO instead. But you sho

RE: [PATCH] crypto: driver for tegra AES hardware

2011-11-04 Thread Stephen Warren
Varun Wadekar wrote at Friday, November 04, 2011 5:14 AM: > From: Varun Wadekar If you teach git your full name, it'll omit this From: header from the email body, which will be a little more idiomatic: git config --global sendemail.from "Varun Wadekar " > driver supports ecb/cbc/ofb/ansi_x9.31r