Re: [PATCH v10 4/5] tpm: Add a driver for Loongson TPM device

2025-05-28 Thread Stefano Garzarella
On Wed, 28 May 2025 at 11:25, Qunqin Zhao wrote: > > > 在 2025/5/28 下午5:00, Stefano Garzarella 写道: > > On Wed, May 28, 2025 at 04:42:05PM +0800, Qunqin Zhao wrote: > >> > >> 在 2025/5/28 下午3:57, Stefano Garzarella 写道: > >>>> +chip = tpmm_ch

Re: [PATCH v10 4/5] tpm: Add a driver for Loongson TPM device

2025-05-28 Thread Stefano Garzarella
On Wed, May 28, 2025 at 04:42:05PM +0800, Qunqin Zhao wrote: 在 2025/5/28 下午3:57, Stefano Garzarella 写道: +    chip = tpmm_chip_alloc(dev, &tpm_loongson_ops); +    if (IS_ERR(chip)) +    return PTR_ERR(chip); +    chip->flags = TPM_CHIP_FLAG_TPM2 | TPM_CHIP_FLAG_IRQ; Why

Re: [PATCH v10 4/5] tpm: Add a driver for Loongson TPM device

2025-05-28 Thread Stefano Garzarella
On Wed, May 28, 2025 at 05:34:49PM +0800, Qunqin Zhao wrote: 在 2025/5/28 下午5:24, Qunqin Zhao 写道: 在 2025/5/28 下午5:00, Stefano Garzarella 写道: On Wed, May 28, 2025 at 04:42:05PM +0800, Qunqin Zhao wrote: 在 2025/5/28 下午3:57, Stefano Garzarella 写道: +    chip = tpmm_chip_alloc(dev

Re: [PATCH v10 4/5] tpm: Add a driver for Loongson TPM device

2025-05-28 Thread Stefano Garzarella
On Wed, May 28, 2025 at 02:59:43PM +0800, Qunqin Zhao wrote: Loongson Security Engine supports random number generation, hash, symmetric encryption and asymmetric encryption. Based on these encryption functions, TPM2 have been implemented in the Loongson Security Engine firmware. This driver is r

Re: [PATCH v9 4/5] tpm: Add a driver for Loongson TPM device

2025-05-07 Thread Stefano Garzarella
On Wed, 7 May 2025 at 03:35, Qunqin Zhao wrote: > > > 在 2025/5/6 下午10:13, Stefano Garzarella 写道: > > On Tue, May 06, 2025 at 11:19:46AM +0800, Qunqin Zhao wrote: > >> Loongson Security Engine supports random number generation, hash, > >> symmetric encryption an

Re: [PATCH v9 4/5] tpm: Add a driver for Loongson TPM device

2025-05-06 Thread Stefano Garzarella
On Tue, May 06, 2025 at 11:19:46AM +0800, Qunqin Zhao wrote: Loongson Security Engine supports random number generation, hash, symmetric encryption and asymmetric encryption. Based on these encryption functions, TPM2 have been implemented in the Loongson Security Engine firmware. This driver is r

Re: [PATCH v4] tpm: Mask TPM RC in tpm2_start_auth_session()

2025-04-07 Thread Stefano Garzarella
RY: + return -ENOMEM; + default: + return -EFAULT; + } +} I like this and in the future we could reuse it in different places like tpm2_load_context() and tpm2_save_context(). Reviewed-by: Stefano Garzarella BTW for my understading, looking at that code

Re: [PATCH v3] tpm: Mask TPM RC in tpm2_start_auth_session()

2025-04-07 Thread Stefano Garzarella
On Mon, Apr 07, 2025 at 02:30:05PM +0300, Jarkko Sakkinen wrote: On Mon, Apr 07, 2025 at 10:04:09AM +0200, Stefano Garzarella wrote: On Mon, Apr 07, 2025 at 10:20:57AM +0300, Jarkko Sakkinen wrote: > tpm2_start_auth_session() does not mask TPM RC correctly from the callers: > > [

Re: [PATCH v3] tpm: Mask TPM RC in tpm2_start_auth_session()

2025-04-07 Thread Stefano Garzarella
On Mon, Apr 07, 2025 at 10:20:57AM +0300, Jarkko Sakkinen wrote: tpm2_start_auth_session() does not mask TPM RC correctly from the callers: [ 28.766528] tpm tpm0: A TPM error (2307) occurred start auth session Process TPM RCs inside tpm2_start_auth_session(), and map them to POSIX error codes