Re: [PATCH] crypto: arm/sha256-neon - avoid ADRL pseudo instruction

2020-09-16 Thread Stefan Agner
t, the Clang assembler >> > does not implement ADRL at all, and so it is better to get rid of it >> > entirely. >> > >> > So replace the ADRL instruction with a ADR instruction that refers to >> > a nearer symbol, and apply the delta explicitly using an

[PATCH 2/2] crypto: arm/crc32 - avoid warning when compiling with Clang

2018-09-15 Thread Stefan Agner
Fixes: 2a9faf8b7e43 ("crypto: arm/crc32 - enable module autoloading based on CPU feature bits") Signed-off-by: Stefan Agner --- arch/arm/crypto/crc32-ce-glue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/crypto/crc32-ce-glue.c b/arch/arm/crypto/crc3

[PATCH 1/2] cpufeature: avoid warning when compiling with clang

2018-09-15 Thread Stefan Agner
ort for CPU feature based module autoloading") Signed-off-by: Stefan Agner --- include/linux/cpufeature.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/cpufeature.h b/include/linux/cpufeature.h index 986c06c88d81..84d3c81b5978 100644 --- a/include/linux/cp

Re: [PATCH 1/5] crypto: arm/aes-ce - enable module autoloading based on CPU feature bits

2018-09-12 Thread Stefan Agner
On 10.09.2018 00:01, Ard Biesheuvel wrote: > On 10 September 2018 at 08:21, Stefan Agner wrote: >> Hi Ard, >> >> On 21.05.2017 03:23, Ard Biesheuvel wrote: >>> Make the module autoloadable by tying it to the CPU feature bit that >>> describes whether the

Re: [PATCH 1/5] crypto: arm/aes-ce - enable module autoloading based on CPU feature bits

2018-09-09 Thread Stefan Agner
Hi Ard, On 21.05.2017 03:23, Ard Biesheuvel wrote: > Make the module autoloadable by tying it to the CPU feature bit that > describes whether the optional instructions it relies on are implemented > by the current CPU. > This leads to a compiler warning when compiling multi_v7_defconfig/ARM32 us

Re: [PATCH] crypto: arm/speck - fix building in Thumb2 mode

2018-06-19 Thread Stefan Agner
:431: Error: r13 not allowed here > -- `bic sp,#0xf' > > The problem is that the 'bic' instruction can't operate on the 'sp' > register in Thumb2 mode. Fix it by using a temporary register. This > isn't in the main loop, so the performance difference is

Re: [PATCH v3 3/5] crypto: arm/speck - add NEON-accelerated implementation of Speck-XTS

2018-06-17 Thread Stefan Agner
On 17.06.2018 11:40, Ard Biesheuvel wrote: > On 17 June 2018 at 11:30, Ard Biesheuvel wrote: >> On 17 June 2018 at 00:40, Stefan Agner wrote: >>> Hi Eric, >>> >>> On 14.02.2018 19:42, Eric Biggers wrote: >>>> Add an ARM NEON-accelerated implementa

Re: [PATCH v3 3/5] crypto: arm/speck - add NEON-accelerated implementation of Speck-XTS

2018-06-16 Thread Stefan Agner
Hi Eric, On 14.02.2018 19:42, Eric Biggers wrote: > Add an ARM NEON-accelerated implementation of Speck-XTS. It operates on > 128-byte chunks at a time, i.e. 8 blocks for Speck128 or 16 blocks for > Speck64. Each 128-byte chunk goes through XTS preprocessing, then is > encrypted/decrypted (doing

Re: [RFC PATCH] crypto: brcm - explicitly cast cipher to hash type

2018-03-28 Thread Stefan Agner
a agrees to the change, do you want me to send a non-RFC version or can you merge the patch as is? -- Stefan > > -Raveendra > > On Sat, Mar 24, 2018 at 4:32 PM, Stefan Agner wrote: >> In the AES cases enum spu_cipher_type and enum hash_type have >> the same values, so

[RFC PATCH] crypto: brcm - explicitly cast cipher to hash type

2018-03-24 Thread Stefan Agner
umeration type 'enum spu_cipher_type' to different enumeration type 'enum hash_type' [-Wenum-conversion] hash_parms.type = ctx->cipher_type; ~ ~~~~~^~~ Signed-off-by: Stefan Agner --- I am not familar with the IP

[PATCH RESEND] lib/mpi: fix build with clang

2017-08-07 Thread Stefan Agner
x27; Also remove superfluous casts on output operands to avoid warnings such as: warning: invalid use of a cast in an inline asm context requiring an l-value Signed-off-by: Stefan Agner Acked-by: Arnd Bergmann --- I checked the output of gcc with -S switch before and after this change, gcc gen