[PATCH v2] Staging: ccree: Use kcalloc instead of kzalloc

Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocci Signed-off-by: Srishti Sharma --- Changes in v2: - eliminate parentheses around the first argument drivers/staging

[PATCH] Staging: ccree: Use kcalloc instead of kzalloc

Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocci Signed-off-by: Srishti Sharma --- drivers/staging/ccree/ssi_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Tue, Sep 12, 2017 at 2:49 PM, Dan Carpenter wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma >> --- >> drivers/staging/ccree/ss

Re: [PATCH v2] Staging: ccree: Prefer using BIT macro.

On Mon, Sep 11, 2017 at 9:54 PM, Greg KH wrote: > On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote: >> Use BIT(x) instead of using (1<> >> Signed-off-by: Srishti Sharma >> --- >> Changes in v2: >> - Add tab spaces before BIT macro. >>

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 9:45 PM, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall wrote: >> >> >> On Mon, 11 Sep 2017, Srishti Sharma wrote: >> >>> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: >>> > On Mon, Sep 11

[PATCH v2] Staging: ccree: Remove unused variable monitor_lock

Remove the variable monitor_lock as it is not used anywhere. Signed-off-by: Srishti Sharma --- Changes in v2: -The variable that was not to be declared as volatile can be eliminated as it is not being used anywhere. drivers/staging/ccree/ssi_request_mgr.c | 1 - 1 file changed, 1 deletion

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall wrote: > > > On Mon, 11 Sep 2017, Srishti Sharma wrote: > >> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: >> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> >> The use of volatile for t

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma >> --- >> drivers/staging/ccree/ssi_reques

[PATCH] Staging: ccree: Don't use volatile for monitor_lock

The use of volatile for the variable monitor_lock is unnecessary. Signed-off-by: Srishti Sharma --- drivers/staging/ccree/ssi_request_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 10:29 PM, Julia Lawall wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Merge the assignment and return statements to return the value >> directly. Done using coccinelle. > > Coccinelle is not always perfect about pretty printing,

[PATCH v2] Staging: ccree: Merge assignment with return

Merge the assignment and return statements to return the value directly. Done using the following semantic patch by coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- Changes in v2: -Correct coding style problems

[PATCH] Staging: ccree: Merge assignment with return

Merge the assignment and return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- drivers/staging/ccree/ssi_sysfs.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 12:26 PM, Julia Lawall wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Merge the assignment and return statements to return the value >> directly. Done using coccinelle. >> >> @@ >> local idexpression ret; >> expre

[PATCH v4] Staging: ccree: Merge assignment with return

Merge the assignment and the return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- Changes in v4: -Edit commit message so that it respects 80 character limit

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 12:27 PM, Julia Lawall wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall wrote: >> > >> > >> > On Sat, 9 Sep 2017, Srishti Sharma wrote: >> > >> >&

[PATCH v3] Staging: ccree: Merge assignment with return

Merge the assignment and return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- Changes in v3: -Edit commit message so that it respects 80 character limit

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Merge the assignment and return statements to return the value >> directly. Done using coccinelle. >> >> @@ >> local idexpression ret; >> expre

[PATCH v2] Staging: ccree: Merge assignment with return

Merge the assignment and return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- Changes in v2: - Edit commit message so that it respects the 80 character limit

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Return the return value of a function directly, instead of first saving it >> in a variable and then returning it. This change was made using the following > &

[PATCH] Staging: ccree: Merge assignment with return

Return the return value of a function directly, instead of first saving it in a variable and then returning it. This change was made using the following semantic patch by coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma

[PATCH v2] Staging: ccree: Prefer using BIT macro.

Use BIT(x) instead of using (1< --- Changes in v2: - Add tab spaces before BIT macro. drivers/staging/ccree/ssi_cipher.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h index 296b375..c9a83df

[PATCH] Staging: ccree: Prefer using BIT macro.

Use BIT(x) instead of (1< --- drivers/staging/ccree/ssi_cipher.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h index 296b375..6fbcf9d 100644 --- a/drivers/staging/ccree/ssi_cipher.h +++ b/driv

Re: [PATCH v5] Staging: ccree: Remove unused variable.

On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef wrote: > Hi, > > On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma wrote: >> Remove the local variable inflight_counter as it is never used. >> >> Signed-off-by: Srishti Sharma >> --- > > I've been meani

[PATCH v5] Staging: ccree: Remove unused variable.

Remove the local variable inflight_counter as it is never used. Signed-off-by: Srishti Sharma --- Changes in v5: - Correct the format of the subject. drivers/staging/ccree/ssi_cipher.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging

Re: [Outreachy kernel] [PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable.

possible to guess correctly. However, one does not generally include the > extension on a filename. > Yes, they have not used the filename in the subject line . So I'll change it to the required format . Thanks , Srishti > julia > > On Thu, 7 Sep 2017, Srishti Sharma w

[PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable.

Remove local variable inflight_counter, as it is never used. Signed-off-by: Srishti Sharma --- Change in v4: -There is no longer a need to make the comment more comprehensible, as I have deleted the variable associated with it. The v3 of this patch was not based on the original patch, hence

Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

On Thu, Sep 7, 2017 at 3:02 AM, Dan Carpenter wrote: > Always compile your patches. > > CC [M] drivers/staging/ccree/ssi_cipher.o > drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’: > drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable > ‘inflight_counter

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

On Thu, Sep 7, 2017 at 2:56 AM, Julia Lawall wrote: > > > On Thu, 7 Sep 2017, Srishti Sharma wrote: > >> On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall wrote: >> > >> > >> > On Thu, 7 Sep 2017, Srishti Sharma wrote: >> > >> &g

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall wrote: > > > On Thu, 7 Sep 2017, Srishti Sharma wrote: > >> Remove local variable inflight_counter ,as it is never used. > > "counter ,as" -> "counter, as" > >> Signed-off-by: Srishti Sharma >

[PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

Remove local variable inflight_counter ,as it is never used. Signed-off-by: Srishti Sharma --- Changes in v3: - There was no longer a need to make the comment more comprehensible as I have deleted the variable associated with it because it is unused . drivers/staging/ccree/ssi_cipher.c | 5

Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

On Thu, Sep 7, 2017 at 2:29 AM, Dan Carpenter wrote: > On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote: >> Correct spelling of counter in comment . >> >> Signed-off-by: Srishti Sharma >> --- >> drivers/staging/ccree/ssi_cipher.c | 2 +- >

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: ssi_cipher.c: Make comment more comprehensible.

On Thu, Sep 7, 2017 at 2:28 AM, Julia Lawall wrote: > > > On Thu, 7 Sep 2017, Srishti Sharma wrote: > >> Edited comment to make it more comprehensible. >> >> Signed-off-by: Srishti Sharma >> --- >> Changes in v2: >> - Make comment more c

[PATCH v2] Staging: ccree: ssi_cipher.c: Make comment more comprehensible.

Edited comment to make it more comprehensible. Signed-off-by: Srishti Sharma --- Changes in v2: - Make comment more comprehensible , instead of just correcting typos. drivers/staging/ccree/ssi_cipher.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree

[PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

Correct spelling of counter in comment . Signed-off-by: Srishti Sharma --- drivers/staging/ccree/ssi_cipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c index 8d31a93..99232b2 100644 --- a/drivers

Re: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

On Sun, Jun 4, 2017 at 1:49 PM, Greg KH wrote: > On Sun, Jun 04, 2017 at 05:02:08AM +0530, srishti sharma wrote: >> Added * on subsequent lines of a comment block. >> >> Signed-off-by: srishti sharma >> --- >> drivers/staging/ccree/cc_crypto_ctx.h | 2 +- >

[PATCH 4/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block

Added *'s on subsequent lines of a comment block to fix coding style issues. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/

[PATCH 3/4] Staging: ccree: cc_crypto_ctx.h: Fixed * alignment issues in a comment block

Fixed the alignment of * in a comment block. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h index 27a5914..03164624

[PATCH 2/4] Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment block

Fixed trailing */ style issue in a block comment. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h index 6ee51b8

[PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

Added * on subsequent lines of a comment block. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h index ac39d34..6ee51b8

[PATCH 0/4] Fixed comment coding style issues.

This patchset contains a series of comment coding style issues fixes. srishti sharma (4): Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block. Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment block Staging: ccree: cc_crypto_ctx.h

Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.

of them will compile , but the second one is a better representation of it and does not produce an error on running checkpatch.pl . Regards, Srishti On Sat, Jun 3, 2017 at 2:07 PM, Greg KH wrote: > On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sharma wrote: >> Fixed a pointer de

[PATCH] Staging: ccree: ssi_aead.h: Fixed a comment coding style issue.

Fixed a comment coding style issue , block comments use * on subsequent lines. Signed-off-by: srishti sharma --- drivers/staging/ccree/ssi_aead.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/staging/ccree/ssi_aead.h index

[PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.

Fixed a pointer declaration error , the dereferencing operator was misplaced. Signed-off-by: srishti sharma --- drivers/staging/ccree/ssi_aead.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/staging/ccree/ssi_aead.h index

[PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

Fixed a comment coding style issue that generated a warning stating that block comments should align the * on each line. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree

[PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

Fixed a comment coding style issue that generated a warning stating block comments use * on subsequent lines. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h