Re: [PATCH 2/2] crypto: bfin_crc: avoid get physical address of coherence memory by dma_map_single

2014-04-13 Thread Sonic Zhang
Hi Herbert, Could you please review this patch? Thanks Sonic Zhang On Thu, Apr 10, 2014 at 5:02 PM, Marek Vasut wrote: > On Thursday, April 10, 2014 at 10:40:59 AM, Sonic Zhang wrote: >> From: Sonic Zhang >> >> - The 4-byte sg_mid_buf is located in the middle of

Re: [PATCH v3 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

2014-04-13 Thread Sonic Zhang
Hi Herbert, Could you please review this patch? Thanks Sonic Zhang On Fri, Apr 11, 2014 at 5:33 PM, Marek Vasut wrote: > On Friday, April 11, 2014 at 11:30:25 AM, Sonic Zhang wrote: >> From: Sonic Zhang >> >> in case of multiple crc devices are probed. >> Call pl

Re: [PATCH v2] crypt: bfin_crc: access crc registers by readl and writel functions

2014-04-13 Thread Sonic Zhang
Hi Herbert, Could you please review this patch? Thanks Sonic Zhang On Thu, Apr 10, 2014 at 4:01 PM, Marek Vasut wrote: > On Thursday, April 10, 2014 at 08:30:56 AM, Sonic Zhang wrote: >> From: Sonic Zhang >> >> Move architecture independant crc header file out o

[PATCH v3 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

2014-04-11 Thread Sonic Zhang
From: Sonic Zhang in case of multiple crc devices are probed. Call platform_set_drvdata() before adding new CRC device into the list. Signed-off-by: Sonic Zhang --- v3-change: - check list_is_singular() before register the algorithm drivers/crypto/bfin_crc.c | 18 +- 1 file

[PATCH v2 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

2014-04-10 Thread Sonic Zhang
From: Sonic Zhang in case of multiple crc devices are probed. Call platform_set_drvdata() before adding new CRC device into the list. Signed-off-by: Sonic Zhang --- v2-chagnes: - check the CRC list and avoid call crypto_register_ahash() if not empty - move platform_set_drvdata() before adding

Re: [PATCH 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

2014-04-10 Thread Sonic Zhang
Hi Marek, On Thu, Apr 10, 2014 at 4:59 PM, Marek Vasut wrote: > On Thursday, April 10, 2014 at 10:40:58 AM, Sonic Zhang wrote: >> From: Sonic Zhang >> >> in case of multiple crc devices are probed. >> >> Signed-off-by: Sonic Zhang >> --- >> driver

[PATCH 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

2014-04-10 Thread Sonic Zhang
From: Sonic Zhang in case of multiple crc devices are probed. Signed-off-by: Sonic Zhang --- drivers/crypto/bfin_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/bfin_crc.c b/drivers/crypto/bfin_crc.c index cea3e8c..5f5f427 100644 --- a/drivers/crypto

[PATCH 2/2] crypto: bfin_crc: avoid get physical address of coherence memory by dma_map_single

2014-04-10 Thread Sonic Zhang
From: Sonic Zhang - The 4-byte sg_mid_buf is located in the middle of the coherence memory sg_cpu. Don't call dma_map_single to get its physical address. Get the its base physical address from the physical address of sg_cpu instead. - Should set up the dma descriptor data after the 4

[PATCH v2] crypt: bfin_crc: access crc registers by readl and writel functions

2014-04-09 Thread Sonic Zhang
From: Sonic Zhang Move architecture independant crc header file out of the blackfin folder. Signed-off-by: Sonic Zhang --- v2-changes: - avoid combine the IO accessors into each other - use readl/writel other than ioread32/iowrite32 drivers/crypto/bfin_crc.c | 42

Re: [PATCH] crypt: bfin_crc: access crc registers by ioread32 and iowrite32 functions

2014-04-09 Thread Sonic Zhang
Hi Marek, On Thu, Apr 10, 2014 at 1:32 AM, Marek Vasut wrote: > On Thursday, March 27, 2014 at 09:52:33 AM, Sonic Zhang wrote: >> From: Sonic Zhang >> >> Move architecture independant crc header file out of the blackfin folder. >> >> Signed-off-by: Sonic Zhang

Re: [PATCH] crypt: bfin_crc: access crc registers by ioread32 and iowrite32 functions

2014-04-01 Thread Sonic Zhang
Ping On Thu, Mar 27, 2014 at 4:52 PM, Sonic Zhang wrote: > From: Sonic Zhang > > Move architecture independant crc header file out of the blackfin folder. > > Signed-off-by: Sonic Zhang > --- > drivers/crypto/bfin_crc.c | 38 > -

[PATCH] crypt: bfin_crc: access crc registers by ioread32 and iowrite32 functions

2014-03-27 Thread Sonic Zhang
From: Sonic Zhang Move architecture independant crc header file out of the blackfin folder. Signed-off-by: Sonic Zhang --- drivers/crypto/bfin_crc.c | 38 -- .../include/asm => drivers/crypto}/bfin_crc.h | 0 2 files changed, 21 inserti

[PATCH] crypt: bfin_crc: Remove useless SSYNC instruction and cache flush to DMA coherent memory

2014-02-25 Thread Sonic Zhang
From: Sonic Zhang 1) SSYNC instruction is blackfin specific and takes no effect in this driver. 2) DMA descriptor and SG middle buffer are in DMA coherent memory. No need to flush. 3) Turn kzalloc, ioremap and request_irq into managed device APIs respectively. Signed-off-by: Sonic Zhang

[PATCH 2/2 v3] crypto: bfin_crc: CRC hardware driver for BF60x family processors.

2012-06-03 Thread Sonic Zhang
From: Sonic Zhang The CRC peripheral is a hardware block used to compute the CRC of the block of data. This is based on a CRC32 engine which computes the CRC value of 32b data words presented to it. For data words of < 32b in size, this driver pack 0 automatically into 32b data units. T

[PATCH 2/2 v2] crypto: bfin_crc: CRC hardware driver for BF60x family processors.

2012-06-03 Thread Sonic Zhang
From: Sonic Zhang The CRC peripheral is a hardware block used to compute the CRC of the block of data. This is based on a CRC32 engine which computes the CRC value of 32b data words presented to it. For data words of < 32b in size, this driver pack 0 automatically into 32b data units. T

Re: [PATCH 2/2] crypto: bfin_crc: CRC hardware accelerator driver for BF60x family processors.

2012-05-29 Thread Sonic Zhang
PING On Fri, May 25, 2012 at 5:54 PM, Sonic Zhang wrote: > From: Sonic Zhang > > The CRC peripheral is a hardware block used to compute the CRC of the block > of data. This is based on a CRC32 engine which computes the CRC value of 32b > data words presented to it. For data wo

Re: [PATCH 1/2] crypto: Add new test cases for Blackfin CRC crypto driver.

2012-05-29 Thread Sonic Zhang
PING On Fri, May 25, 2012 at 5:54 PM, Sonic Zhang wrote: > From: Sonic Zhang > > Signed-off-by: Sonic Zhang > --- >  crypto/tcrypt.c  |    3 ++ >  crypto/testmgr.c |    9 + >  crypto/testmgr.h |   90 > ++

[PATCH 1/2] crypto: Add new test cases for Blackfin CRC crypto driver.

2012-05-25 Thread Sonic Zhang
From: Sonic Zhang Signed-off-by: Sonic Zhang --- crypto/tcrypt.c |3 ++ crypto/testmgr.c |9 + crypto/testmgr.h | 90 ++ 3 files changed, 102 insertions(+), 0 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index

[PATCH 2/2] crypto: bfin_crc: CRC hardware accelerator driver for BF60x family processors.

2012-05-25 Thread Sonic Zhang
From: Sonic Zhang The CRC peripheral is a hardware block used to compute the CRC of the block of data. This is based on a CRC32 engine which computes the CRC value of 32b data words presented to it. For data words of < 32b in size, this driver pack 0 automatically into 32b data units. T