Re: [PATCH 00/20] Manual replacement of all strlcpy in favor of strscpy

2021-02-22 Thread Shuah Khan
On 2/22/21 8:12 AM, Romain Perier wrote: strlcpy() copy a C-String into a sized buffer, the result is always a valid NULL-terminated that fits in the buffer, howerver it has severals issues. It reads the source buffer first, which is dangerous if it is non NULL-terminated or if the corresponding

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-10-02 Thread Shuah Khan
On 9/29/20 7:42 AM, Shuah Khan wrote: On 9/29/20 7:34 AM, Joe Perches wrote: On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote: On Tue, 29 Sep 2020, Dan Carpenter wrote: The times where commas are used deliberately to replace curly braces are just evil.  Either way the code is cleaner

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-29 Thread Shuah Khan
On 9/29/20 7:34 AM, Joe Perches wrote: On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote: On Tue, 29 Sep 2020, Dan Carpenter wrote: The times where commas are used deliberately to replace curly braces are just evil. Either way the code is cleaner with semi-colons. I also found exaamples