Re: [PATCH] x86: crypto: fix building crc32c with clang ias

2020-07-23 Thread Sedat Dilek
On Thu, Jul 23, 2020 at 9:57 AM Herbert Xu wrote: > > On Wed, May 27, 2020 at 04:17:40PM +0200, Arnd Bergmann wrote: > > The clang integrated assembler complains about movzxw: > > > > arch/x86/crypto/crc32c-pcl-intel-asm_64.S:173:2: error: invalid instruction > > mnemonic 'movzxw' > > > > It seem

Re: x86: crypto: fix building crc32c with clang ias

2020-07-10 Thread Sedat Dilek
el free to add my: Reported-by: Sedat Dilek Tested-by: Sedat Dilek Thanks. Regards, - Sedat - [0] https://lore.kernel.org/patchwork/patch/1248401/ [1] https://marc.info/?l=linux-crypto-vger&m=159437162224847&w=2 [2] https://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH v5] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-07-10 Thread Sedat Dilek
On Thu, Jul 9, 2020 at 2:56 PM Herbert Xu wrote: > > On Fri, Jul 03, 2020 at 04:32:06PM +0200, Sedat Dilek wrote: > > When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) > > from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/binuti

Re: [PATCH] crypto, x86: aesni: add compatibility with IAS

2020-07-03 Thread Sedat Dilek
On Fri, Jul 3, 2020 at 3:00 PM Herbert Xu wrote: > > On Fri, Jul 03, 2020 at 10:36:43AM +0200, Sedat Dilek wrote: > > > > Can you please apply my patch, too? > > Please repost your patch without the 5.7 tag. > Sent out a v5: Changes v4->v5: - Drop "5.7&quo

[PATCH v5] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-07-03 Thread Sedat Dilek
Thanks to Craig and especially Nick for double-checking and his comments. Suggested-by: Craig Topper Suggested-by: Craig Topper Suggested-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Cc: "ClangBuiltLinux" Link: https://github.com/ClangBuiltLinux/linux/issues/1050 Link: https://

Re: [PATCH] crypto, x86: aesni: add compatibility with IAS

2020-07-03 Thread Sedat Dilek
gt; > with IAS. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/1008 > > Reported-by: Sedat Dilek > > Reported-by: Fangrui Song > > Tested-by: Sedat Dilek # build+boot Linux v5.7.5; > > clang v11.0.0-git > > Signed-off-by: Jian Cai

Re: [PATCH 5.7 v2] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-23 Thread Sedat Dilek
On Tue, Jun 23, 2020 at 8:44 PM Nick Desaulniers wrote: > > On Mon, Jun 22, 2020 at 7:56 PM Sedat Dilek wrote: > > > > When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) > > from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/

[PATCH 5.7 v4] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-23 Thread Sedat Dilek
Thanks to Craig and especially Nick for double-checking and his comments. Suggested-by: Craig Topper Suggested-by: Craig Topper Suggested-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Cc: "ClangBuiltLinux" Link: https://github.com/ClangBuiltLinux/linux/issues/1050 Signed-off-by

Re: [PATCH 5.7] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
On Mon, Jun 22, 2020 at 10:33 PM Nick Desaulniers wrote: > > On Mon, Jun 22, 2020 at 8:50 AM Sedat Dilek wrote: > > > > When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) > > from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/

[PATCH 5.7 v3] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
Thanks to Craig and especially Nick for double-checking and his comments. Suggested-by: Craig Topper Suggested-by: Craig Topper Suggested-by: Nick Desaulniers ndesaulni...@google.com Cc: "ClangBuiltLinux" Link: https://github.com/ClangBuiltLinux/linux/issues/1050 Signed-off-by: Sedat

[PATCH 5.7 v2] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
Thanks to Craig and especially Nick for double-checking and his comments. Suggested-by: Craig Topper Suggested-by: Craig Topper Suggested-by: Nick Desaulniers ndesaulni...@google.com Cc: "ClangBuiltLinux" Link: https://github.com/ClangBuiltLinux/linux/issues/1050 Signed-off-by: Sedat

Re: [PATCH 5.7] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
On Mon, Jun 22, 2020 at 5:50 PM Sedat Dilek wrote: > Craig Topper suggested me in ClangBuiltLinux issue #1050: > > > I think the "too many positional arguments" is because the parser isn't able > > to handle the trailing commas. > > > > The "u

[PATCH 5.7] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/binutils I see the following breakage in Debian/testing AMD64: :15:74: error: too many positional arguments PRECOMPUTE 8*3+8(%rsp), %xmm1, %xmm2, %xmm3, %xmm4, %x

Re: crypto: x86/crct10dif-pcl - cleanup and optimizations

2019-07-04 Thread Sedat Dilek
On Wed, Jul 3, 2019 at 8:52 PM Nick Desaulniers wrote: > > On Wed, Jul 3, 2019 at 9:15 AM Eric Biggers wrote: > > Sorry, I am still confused. Are you saying that something still needs to be > > fixed in the kernel code, and if so, why? To reiterate, the byteshift_table > > doesn't actually *nee

Re: crypto: x86/crct10dif-pcl - cleanup and optimizations

2019-07-03 Thread Sedat Dilek
On Mon, Jun 17, 2019 at 8:23 PM Eric Biggers wrote: > > On Mon, Jun 17, 2019 at 11:06:21AM -0700, Nick Desaulniers wrote: > > On Mon, Jun 17, 2019 at 6:35 AM Sedat Dilek wrote: > > > > > > Hi, > > > > > > while digging through a ClangBuiltLinux is

Re: crypto: x86/crct10dif-pcl - cleanup and optimizations

2019-06-17 Thread Sedat Dilek
Hi, while digging through a ClangBuiltLinux issue when linking with LLD linker on x86-64 I checked the settings for... .rodata.cst16 and .rodata.cst32 ...in crypto tree and fell over this change in... commit "crypto: x86/crct10dif-pcl - cleanup and optimizations": -.section .rodata.cst16.SHUF_

Re: [v4.7-6816-g797cee982eef] Call-trace: modprobe | asymmetric-keys?

2016-07-31 Thread Sedat Dilek
On Sat, Jul 30, 2016 at 4:25 PM, Herbert Xu wrote: > On Sat, Jul 30, 2016 at 02:55:12PM +0200, Sedat Dilek wrote: >> [ CC "MODULE SUPPORT" | "ASYMMETRIC KEYS" | "CRYPTO API" maintainers ] >> >> Hi, >> >> with latest Linus Git (v

Re: linux-next: Tree for Apr 11 [ crypto: aesni-intel ]

2013-04-12 Thread Sedat Dilek
On Fri, Apr 12, 2013 at 4:13 AM, Herbert Xu wrote: > On Thu, Apr 11, 2013 at 07:14:31PM +0200, Sedat Dilek wrote: >> On Thu, Apr 11, 2013 at 10:30 AM, Stephen Rothwell >> wrote: >> > Hi all, >> > >> > Changes since 20130410: >> > >> &g

Re: linux-next: Tree for Apr 11 [ crypto: aesni-intel ]

2013-04-11 Thread Sedat Dilek
On Thu, Apr 11, 2013 at 7:14 PM, Sedat Dilek wrote: > On Thu, Apr 11, 2013 at 10:30 AM, Stephen Rothwell > wrote: >> Hi all, >> >> Changes since 20130410: >> >> The tip tree gained conflicts against the net-next and pm trees. >> >> The driver-