Re: [PATCH] hwrng: omap3-rom - Fix unused function warnings

2019-10-23 Thread Sebastian Reichel
PM instead of custom > functions") > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/char/hw_random/omap3-rom-rng.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/hw_random/omap3-rom-

Re: [PATCHv2 0/7] Non-urgent fixes and improvments for omap3-rom-rng

2019-09-16 Thread Sebastian Reichel
/bindings/rng/omap3_rom_rng.txt | 27 +++ > arch/arm/boot/dts/omap3-n900.dts | 6 + > arch/arm/mach-omap2/pdata-quirks.c| 14 +- > drivers/char/hw_random/omap3-rom-rng.c| 168 +++--- > 4 files changed, 139 insertions(+), 76 deletions(-)

Re: [PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng

2019-09-14 Thread Sebastian Reichel
series is Reviewed-by: Sebastian Reichel Assuming you use clk_prepare_enable() in the runtime PM handler, I suggest to add another patch and go all the way to managed resources: devm_add_action() can be used for disabling runtime PM and devm_hwrng_register() can be used to register the hwrng d

Re: [PATCH 3/6] hwrng: omap3-rom - Call clk_prepare() on init and exit only

2019-09-14 Thread Sebastian Reichel
Hi, On Fri, Sep 13, 2019 at 03:09:19PM -0700, Tony Lindgren wrote: > Also, we should not call prepare and unprepare except during init, and > only call enable and disable during use. Why? Usually clk_(un)prepare() is the part saving most power, so I would expect the runtime resume handlers to cal