I've been looking at the patch and it looks like it should work. Having
numbers to backup the performance in the pure-software version and with
HW acceleration would _very_ nice to have.
On 2020-11-07 19:53:32 [+1300], Barry Song wrote:
> index fbb7829..73f04de 100644
> --- a/mm/zswap.c
> +++ b/mm
he value to the caller including
`qman_cb_dqrr' typedef which is used by the dpaa and the crypto driver.
Signed-off-by: Sebastian Andrzej Siewior
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Herbert XS
Cc: "David S. Miller"
Cc: Madalin Bucur
Cc: Jakub Kicins
conveyed in an argument passed by the caller,
which usually knows the context.
Use the `sched_napi' argument passed by the callback. It is set true if
called from the interrupt handler and NAPI should be scheduled.
Signed-off-by: Sebastian Andrzej Siewior
Cc: "Horia Geantă"
Cc: Ay
conveyed in an argument passed by the caller,
which usually knows the context.
Use the `sched_napi' argument passed by the callback. It is set true if
called from the interrupt handler and NAPI should be scheduled.
Signed-off-by: Sebastian Andrzej Siewior
Cc: "Horia Geantă"
Cc: Ay
On 2020-10-31 10:12:15 [-0700], Jakub Kicinski wrote:
> Nit: some networking drivers have a bool napi which means "are we
> running in napi context", the semantics here feel a little backwards,
> at least to me. But if I'm the only one thinking this, so be it.
I renamed it to `sched_napi'.
Sebast
y.
Invoke airo_read_wireless_stats() directly from the callback and remove
the now unused JOB_WSTATS handling.
Signed-off-by: Sebastian Andrzej Siewior
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
---
driver
Sebastian Andrzej Siewior
Cc: Jouni Malinen
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
---
drivers/net/wireless/intersil/hostap/hostap_ioctl.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
t_coex_supported_feature()
None of these have a caller. Welcome to the wonderful world of HALs and
onion layers.
Remove in_interrupt() check.
Signed-off-by: Sebastian Andrzej Siewior
Cc: Ping-Ke Shih
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-wirel...@vger.ker
conveyed in an argument passed by the caller,
which usually knows the context.
Use the `napi' argument passed by the callback. It is set true if
called from the interrupt handler and NAPI should be scheduled.
Signed-off-by: Sebastian Andrzej Siewior
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Andrzej Siewior
Cc: Daniel Drake
Cc: Ulrich Kunitz
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
---
drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 15 ---
1 file changed, 15 deletions(-)
diff --git
context
through a quite large amount of functions.
As this is ancient hardware, avoid the churn and enforce the invocation of
those functions through the JOB machinery.
Signed-off-by: Sebastian Andrzej Siewior
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: l
conveyed in an argument passed by the caller,
which usually knows the context.
Use the `napi' argument passed by the callback. It is set true if
called from the interrupt handler and NAPI should be scheduled.
Signed-off-by: Sebastian Andrzej Siewior
Cc: "Horia Geantă"
Cc: Aymen Sghaier
he value to the caller including
`qman_cb_dqrr' typedef which is used by the dpaa and the crypto driver.
Signed-off-by: Sebastian Andrzej Siewior
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Madalin Bucur
Cc: Jakub Kicins
Andrzej Siewior
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-r...@vger.kernel.org
---
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/mel
code further use list_empty() instead of walking the list
and counting the entries just to check the count for > 0 at the end.
Signed-off-by: Sebastian Andrzej Siewior
Cc: Ping-Ke Shih
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-wirel...@vger.kerne
x27;s pointless to
invoke schedule() if there is no request to reschedule.
Pass the may_sleep condition through the various call chains leading to
issuecommand().
Signed-off-by: Sebastian Andrzej Siewior
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-wirel...@vger.ker
(), tlan_mii_write_reg() and tlan_phy_print() are invoked
from interrupt and other contexts.
Split out the actual function body into helper variants which are called
from interrupt context and make the original functions wrappers which
acquire tlan_priv::lock unconditionally.
Signed-off-by: Sebastian Andrzej Siewior
n the invoked functions (always enabled or debug
option dependent) cover these conditions already, so the BUG_ON()'s do not
really provide additional value.
Just remove them.
Signed-off-by: Sebastian Andrzej Siewior
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicin
Folks,
in the discussion about preempt count consistency across kernel configurations:
https://lore.kernel.org/r/20200914204209.256266...@linutronix.de/
Linus clearly requested that code in drivers and libraries which changes
behaviour based on execution context should either be split up so th
et_rx_mode()
s2io_set_multicast()
s2io_txpic_intr_handle()
s2io_link()
init_tti()
Add a may_sleep argument to wait_for_cmd_complete(), s2io_set_multicast()
and init_tti() and hand the context information in from the call sites.
Signed-off-by: Sebastian Andrzej Siewior
Cc: Jon
replace the warning and the lock assert with lockdep_assert_held().
Signed-off-by: Sebastian Andrzej Siewior
Cc: Rain River
Cc: Zhu Yanjun
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: net...@vger.kernel.org
---
drivers/net/ethernet/nvidia/forcedeth.c | 6 +-
1 file changed, 1
On 2020-09-29 10:02:15 [+], Song Bao Hua (Barry Song) wrote:
> > My point was that there will be a warning at run-time and you don't want
> > that. There are raw_ accessors if you know what you are doing. But…
>
> I have only seen get_cpu_ptr/var() things will disable preemption. I don't
> th
On 2020-09-29 05:14:31 [+], Song Bao Hua (Barry Song) wrote:
> After second thought and trying to make this change, I would like to change
> my mind
> and disagree with this idea. Two reasons:
> 1. while using this_cpu_ptr() without preemption lock, people usually put all
> things bound
> wit
On 2020-08-19 00:31:00 [+1200], Barry Song wrote:
> diff --git a/mm/zswap.c b/mm/zswap.c
> index fbb782924ccc..00b5f14a7332 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -127,9 +129,17 @@ module_param_named(same_filled_pages_enabled,
> zswap_same_filled_pages_enabled,
> * data structures
> *
On 2020-07-09 07:55:22 [+], Song Bao Hua (Barry Song) wrote:
> Hello Sebastian, thanks for your reply and careful review.
Hi,
> I don't think we can simply "forward the result to the caller and let him
> decide".
> Would you like to present some pseudo code?
I provided just some pseudo code
On 2020-07-09 01:32:38 [+], Song Bao Hua (Barry Song) wrote:
> > This looks using the same synchronous mechanism around an asynchronous
> > interface. It works as a PoC.
> >
> > As far as I remember the crypto async interface, the incoming skbs were fed
> > to
> > the async interface and retu
On 2020-07-08 21:45:47 [+], Song Bao Hua (Barry Song) wrote:
> > On 2020-07-08 00:52:10 [+1200], Barry Song wrote:
> > > @@ -127,9 +129,17 @@
> > > +struct crypto_acomp_ctx {
> > > + struct crypto_acomp *acomp;
> > > + struct acomp_req *req;
> > > + struct crypto_wait wait;
> > > + u8 *dstmem;
On 2020-07-08 00:52:10 [+1200], Barry Song wrote:
…
> @@ -127,9 +129,17 @@ module_param_named(same_filled_pages_enabled,
> zswap_same_filled_pages_enabled,
> * data structures
> **/
>
> +struct crypto_acomp_ctx {
> + struct crypto_acomp *acomp;
> + struc
On 2019-09-04 11:49:57 [-0700], Stephen Boyd wrote:
> Can you try this?
yes, works.
Sebastian
On 2019-08-22 15:55:19 [+1000], Herbert Xu wrote:
> Patch applied. Thanks.
[ ff296293b3538 ("random: Support freezable kthreads in
add_hwgenerator_randomness()") ]
and since kthread_freezable_should_stop() has might_sleep() in it, I get
this:
|: do not call blocking ops when !TASK_RUNNING; stat
For spinlocks the type spinlock_t should be used instead of "struct
spinlock".
Use spinlock_t for spinlock's definition.
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/crypto/ux500/cryp/cry
ler didn't
move the task to another CPU.
Guenter managed to do that and the code crashed as expected.
Allocate / free per-CPU memory on each CPU.
Fixes: 71052dcf4be70 ("crypto: scompress - Use per-CPU struct instead multiple
variables")
Reported-by: Guenter Roeck
Signed-off
On 2019-04-12 15:50:56 [+0200], To Guenter Roeck wrote:
> So I have this, let me try to dig further.
I'm such a moron. Patch is coming soon…
> > Guenter
>
Sebastian
On 2019-04-12 06:43:31 [-0700], Guenter Roeck wrote:
> On 4/12/19 1:42 AM, Sebastian Andrzej Siewior wrote:
> > On 2019-04-10 21:07:35 [-0700], Guenter Roeck wrote:
> > > Hi Sebastian,
> > Hi Guenter,
> >
> > > Unfortunately, this patch causes random cr
On 2019-04-10 21:39:34 [-0700], Eric Biggers wrote:
> Well, from a quick read of the patch, it's probably because it uses
> raw_cpu_ptr() instead of per_cpu_ptr() when allocating/freeing the buffers, so
> they are unlikely to actually be allocated for all CPUs.
memory is allocated in crypto_scomp_
On 2019-04-10 21:07:35 [-0700], Guenter Roeck wrote:
> Hi Sebastian,
Hi Guenter,
> Unfortunately, this patch causes random crashes.
…
> This is seen with an arm64 image running on qemu with machine xlnx-zcu102
> and two CPUs, and crypto test options enabled. It happens roughly every
> other boot.
o there is probably no harm.
Signed-off-by: Sebastian Andrzej Siewior
---
crypto/scompress.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/crypto/scompress.c b/crypto/scompress.c
index 6f8305f8c3004..aea1a8e5d1954 100644
--- a/crypto/scompress.c
+++ b/crypto/scompress.c
1795 703 no_dbg-after.o
The overall size increase difference is also negative. The increase in
the data section is only four bytes without lockdep.
Signed-off-by: Sebastian Andrzej Siewior
---
crypto/scompress.c | 137 -
1 file changed, 60
Last user of cdev_list_lock was removed in commit
6422ccc5fbefb ("crypto/chelsio/chtls: listen fails with multiadapt")
Cc: Atul Gupta
Cc: Harsh Jain
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/crypto/chelsio/chtls/chtls_main.c | 1 -
1 file changed, 1 deletion(-)
di
crypto_cfg_mutex was never used since it got introduced in commit
cac5818c25d04 ("crypto: user - Implement a generic crypto statistics")
Cc: Corentin Labbe
Signed-off-by: Sebastian Andrzej Siewior
---
crypto/crypto_user_stat.c | 2 --
1 file changed, 2 deletions(-)
diff --gi
On 2019-01-09 16:59:26 [+0100], Daniel Bristot de Oliveira wrote:
> diff --git a/kernel/padata.c b/kernel/padata.c
> index d568cc56405f..bfcbdeb20ba5 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -295,7 +295,7 @@ static void padata_reorder_timer(struct timer_list *t)
> unsigned
On 2018-10-25 14:05:32 [+], Horia Geanta wrote:
> > Now, what is the problem with the CPU limitation? Is this a HW
> > limitation that you can access the registers from a certain CPU?
> >
> Roy confirmed the CPU limitation should actually be removed, there is nothing
> in
> HW requiring it.
>
43.dfhd2asqktm22...@linutronix.de
> Reported-by: Sebastian Andrzej Siewior
> Signed-off-by: Horia Geantă
Oh. No more usage of set_cpus_allowed_ptr(). Wonderful. Thank you.
Acked-by: Sebastian Andrzej Siewior
for that.
Now that you shifted my attention to qman_delete_cgr_safe().
Could you ple
Hi,
this block:
|int caam_qi_shutdown(struct device *qidev)
| {
| struct cpumask old_cpumask = current->cpus_allowed;
…
| /*
| * QMan driver requires CGRs to be deleted from same CPU from where
they
| * were instantiated. Hence we get the module removal execute f
On 2018-07-24 19:12:20 [+0200], Ard Biesheuvel wrote:
> Vakul reports a considerable performance hit when running the accelerated
> arm64 crypto routines with CONFIG_PREEMPT=y configured, now that thay have
> been updated to take the TIF_NEED_RESCHED flag into account.
just in time. I will try to
On 2018-02-27 19:40:34 [+0100], Greg Kroah-Hartman wrote:
> On Tue, Feb 27, 2018 at 06:33:14PM +0100, Sebastian Andrzej Siewior wrote:
> > On 2018-02-27 11:08:56 [-0600], Gary R Hook wrote:
> > > That issue remains unclear to me: Are probes of PCI devices guaranteed to
> &g
On 2018-02-27 11:08:56 [-0600], Gary R Hook wrote:
> That issue remains unclear to me: Are probes of PCI devices guaranteed to be
> serialized? Observations on my CCPs says that they occur in order, but I
> don't know for certain that serialization is guaranteed.
>
> Is there a definitive statemen
On 2018-02-25 21:04:27 [-0500], Hook, Gary wrote:
> On 2/23/2018 5:33 PM, Sebastian Andrzej Siewior wrote:
> > I don't why we need take a single write lock and disable interrupts
> > while setting up debugfs. This is what what happens when we try anyway:
>
> There is
x650
| worker_thread+0x1d4/0x3a0
| kthread+0xfe/0x130
| ret_from_fork+0x27/0x50
If any locking is required, a simple mutex will do it.
Cc: Gary R Hook
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/crypto/ccp/ccp-debugfs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
dif
RCE_RR_CPU=y.
Again, the preempt_disable() won't work here but lock which was
introduced will help.
In order to keep work-item on the local CPU (and avoid RR) I changed it
to queue_work_on().
Cc: sta...@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior
---
crypto/mcryptd
On 2017-06-19 22:55:37 [+0200], Jason A. Donenfeld wrote:
> On Mon, Jun 19, 2017 at 9:45 AM, Sebastian Andrzej Siewior
> wrote:
> > ehm. You sure? I simply delayed the lock-dropping _after_ the state
> > variable was been modified. So it was basically what your patch did
On 2017-06-17 02:39:40 [+0200], Jason A. Donenfeld wrote:
> On Fri, Jun 16, 2017 at 4:35 PM, Sebastian Andrzej Siewior
> wrote:
> > I wouldn't just push the lock one up as is but move that write part to
> > crng_init to remain within the locked section. Like that:
>
On 2017-06-16 14:12:42 [+0200], Jason A. Donenfeld wrote:
> I actually figured that out myself after sending the initial email, so
> then I wrote a follow-up patch which I attached to this thread. You
> should have received it. Can you take a look?
replied to the patch.
Sebastian
On 2017-06-15 00:45:26 [+0200], Jason A. Donenfeld wrote:
> Odd versions of gcc for the sh4 architecture will actually warn about
> flags being used while uninitialized, so we set them to zero. Non crazy
> gccs will optimize that out again, so it doesn't make a difference.
that is minor
> Next, o
On 2017-06-15 00:33:12 [+0200], Jason A. Donenfeld wrote:
> There's a potential race that I fixed in my v5 of that patch set, but
> Ted only took v4, and for whatever reason has been to busy to submit
> the additional patch I already posted showing the diff between v4&v5.
> Hopefully he actually ge
On 2017-06-08 01:25:55 [+0200], Jason A. Donenfeld wrote:
> It's possible that get_random_{u32,u64} is used before the crng has
> initialized, in which case, its output might not be cryptographically
> secure. For this problem, directly, this patch set is introducing the
> *_wait variety of functio
On 2016-09-26 21:18:21 [-0400], Paul Gortmaker wrote:
>
> ...and so it currently is not being built as a module by anyone.
that is correct.
Acked-by: Sebastian Andrzej Siewior
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior
---
include/linux/padata.h | 2 +-
kernel/padata.c| 92 --
2 files changed, 53 insertions(+), 41 deletions(-)
diff --git a/include/linux/padata.h b/include/linux/padat
Users of rwlocks should include spinlock.h instead including this
header file. The current users of rwlocks_types.h are internal.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/crypto/ccp/ccp-dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/ccp/ccp-dev.c b/drivers
* Sebastian Andrzej Siewior | 2015-02-16 12:18:22 [+0100]:
>Known issues:
>
> - xor / raid_pq
>I had max latency jumping up to 67563us on one CPU while the next
>lower max was 58us. I tracked it down to module's init code of
>xor and raid_pq.
without it:
|drivers/built-in.o:(.data+0x14588): undefined reference to
`crypto_ablkcipher_type'
|drivers/built-in.o:(.data+0x14668): undefined reference to
`crypto_ablkcipher_type'
Not sure when this broke.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/crypto/Kconfig |1
On Wed, Jun 27, 2012 at 02:52:47PM +0800, Herbert Xu wrote:
> > On a side note: do we pull in the blkcipher block mode for each cipher now
> > to
> > gain some extra performance like the openssl project? I was under the
> > impression that is in general not worth it.
>
> You mean normal block cip
[crypto/arc4.ko] undefined!
Signed-off-by: Sebastian Andrzej Siewior
---
On a side note: do we pull in the blkcipher block mode for each cipher now to
gain some extra performance like the openssl project? I was under the
impression that is in general not worth it.
crypto/Kconfig |2 +-
On Wed, Feb 22, 2012 at 09:10:46PM +0100, Nikos Mavrogiannopoulos wrote:
> On 02/22/2012 02:03 PM, Frank wrote:
>
> > Hi,
> >
> > After doing some trials with hardware crypto offloading through usermode
> > interfaces (af_alg and cryptodev) to Marvell CESA accelerated ciphers and
> > hash funct
* Nikos Mavrogiannopoulos | 2010-06-11 09:47:15 [+0200]:
>Sebastian Andrzej Siewior wrote:
>> * Phil Sutter | 2010-06-10 20:22:29 [+0200]:
>
>The problem with right or wrong is that they are only known afterwards.
>For me the right way to go is _to go_. I can see discussions in
* Phil Sutter | 2010-06-10 20:22:29 [+0200]:
>Hello everyone,
Hi Phil,
please take look at [0] and [1]. From README I can tell that those two
posts are different from you have so far.
You might want to take a look at AF_PACKET interface. It does zero copy
via a ring buffer interface of pre-mmaped
* Manuel Lauss | 2010-05-06 17:50:45 [+0200]:
A brief look.
>lightly "tested" with the tcrypt module on Au1200; I have no idea whether
>it really works correctly:
>
># modprobe alchemy-aes
>alg: skcipher: setkey failed on test 2 for ecb-aes-alchemy: flags=20
># modprobe tcrypt mode=10
>alg: s
* Manuel Lauss | 2010-05-05 14:02:15 [+0200]:
>I've written a prototype driver for an AES accelerator; I'd like to test it
>now. Are there any userspace tools available for this?
modprobe tcrypt mode=10
will test varios blockmodes. There is no userland interface for hw
driver atm.
>
>Thanks!
>
* Uri Simchoni | 2010-04-24 21:43:35 [+0300]:
Sorry for the late reply.
>> I enabled list and sg debugging and a flood ping triggered a couple of
>> warning. Could you please look at this?
>Sure.
It seems that everything is working now.
>> IPsec requests authenc(hmac(sha1),cbc(aes)) so right now
* Herbert Xu | 2010-04-26 09:17:11 [+0800]:
>OK that was my fault. Steffen had all the requisite EINPROGRESS
>checks in place but I told him to get rid of them.
>
>This patch should fix it.
Excellent job Herbert, it does solve the problem.
Sebastian
--
To unsubscribe from this list: send the lin
* Sebastian Andrzej Siewior | 2010-04-24 17:12:07 [+0200]:
>For IPSec I use this[0] shell script which sets up a connection. Good for
[0] http://breakpoint.cc/ipsec.sh
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a mess
* Uri Simchoni | 2010-04-22 06:23:12 [+0300]:
>I have some IPSec background but am not familiar with the Linux implementation
>(I'm using the mv_cesa for SSL acceleration through a usermode interface I'm
>working on). Can you point me to the nearest howto? I suppose I could have a
>look.
If it
* L.C. | 2010-04-20 22:45:19 [+0200]:
>Sebastian, here is the OOPS from the latest cryptodev git tree
>(2.6.33), more clue than I thought, it looks?:
No I don't. I look at it this weekend. I need just to setup IPsec in
order to reproduce this, right?
>cut
>fli
* Chihau Chau | 2010-04-15 13:17:59 [-0400]:
>From: Chihau Chau
>
>This fixes some code style issues like:
looks good
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ke
* Herbert Xu | 2010-04-07 17:29:07 [+0800]:
>Sebastian, how about precomputing the IV and provide them directly
>as a hex array?
>
>To test arc4_setup_iv itself, you can add an alg_test_arc4 function
>(like alg_test_crc32) that tests IV generation specifically.
>
>Alternatively, just add an alg_te
* Pavel Roskin | 2010-04-07 02:19:55 [-0400]:
>On Mon, 2010-04-05 at 19:04 +0200, Sebastian Andrzej Siewior wrote:
>
>> +module_init(arc4_init);
>> +module_exit(arc4_exit);
>
>I'm feelings uneasy about using the same module init/exit functions
>names in arc4blk.c
* Herbert Xu | 2010-04-07 08:31:09 [+0800]:
>On Tue, Apr 06, 2010 at 10:30:02PM +0200, Sebastian Andrzej Siewior wrote:
>>
>> Good point. All arc4 users don't care about return value of setkey so I
>> think that I just change void to int add the check for the valid key
&
* Herbert Xu | 2010-04-06 20:44:12 [+0800]:
>On Mon, Apr 05, 2010 at 07:04:06PM +0200, Sebastian Andrzej Siewior wrote:
>>
>> +static void arc4_key_to_iv(const u8 *in_key, u32 key_len, struct arc4_iv
>> *iv)
>> +{
>> +int i, j = 0, k = 0;
>> +
>
This is a pure blkcipher implementation of ARC4. The internal state is
saved within an IV which is supplied by the user. The goal is that the
cipher does not change its internal state now, only the iv changes during
encryption.
Signed-off-by: Sebastian Andrzej Siewior
---
crypto/Kconfig
ecb(arc4) is getting replaced by arc4 which is a blkcipher by itself.
Signed-off-by: Sebastian Andrzej Siewior
---
net/mac80211/Kconfig |3 +--
net/mac80211/wep.c | 11 +++
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
This is a pure blkcipher implementation of ARC4. The internal state is
saved within an IV which is supplied by the user. The goal is that the
cipher does not change its internal state now, only the iv changes during
encryption.
Cc:
Signed-off-by: Sebastian Andrzej Siewior
---
crypto/Kconfig
ecb(arc4) is getting replaced by arc4 which is a blkcipher by itself
Cc:
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/net/Kconfig|3 +--
drivers/net/ppp_mppe.c | 12 ++--
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net
Signed-off-by: Sebastian Andrzej Siewior
---
crypto/testmgr.c | 60 +-
1 files changed, 50 insertions(+), 10 deletions(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 7620bfc..c471e04 100644
--- a/crypto/testmgr.c
+++ b/crypto
ecb(arc4) is getting replaced by arc4 which is a blkcipher by itself. The
required selects are now pulled in by LIB80211_CRYPT_TKIP instead of
selecting it by every driver.
Signed-off-by: Sebastian Andrzej Siewior
---
net/wireless/Kconfig |2 ++
net/wireless
ecb(arc4) is getting replaced by arc4 which is a blkcipher by itself. The
required selects are now pulled in by LIB80211_CRYPT_WEP instead of
selecting it by every driver. Since there is no dependency on ecb and arc4
therr are removed from the idividual driver.
Signed-off-by: Sebastian Andrzej
This patch series converts arc4 into a block cipher and converts all its
users (except those in staging) to use it. The first two patches ensure
that two implementations can coexist, the following patches convert each
user so we remain bisectable.
- lib80211_crypt_tkip was tested with ipw2200
- mac
The blk version of arc4 is comming. The rename ensures that the request
for arc4 loads both modules: this one and the new blk edition.
Cc:
Signed-off-by: Sebastian Andrzej Siewior
---
crypto/Makefile |2 +-
crypto/{arc4.c => arc4cip.c} |1 +
2 files changed, 2 inserti
kip.
the state has been moved from ctx into iv. That way encrypt()/decrypt() can
deliver the same result for a given IV. If the IV is supplied as a plain
key then it wil be converted into a different internal state.
The name is now arc4.
Signed-off-by: Sebastian Andrzej Siewior
* Herbert Xu | 2010-02-22 08:52:17 [+0800]:
>On Mon, Feb 22, 2010 at 08:45:47AM +0800, Herbert Xu wrote:
>>
>> How about this? You extend the IV by one more byte, and use that
>> byte as a boolean flag to indicate whether the IV is valid. All
So I trick the crypto api to allocate more bytes than
* Herbert Xu | 2010-02-16 20:51:25 [+0800]:
>On Fri, Feb 12, 2010 at 09:42:28AM +0100, Sebastian Andrzej Siewior wrote:
>>
>> -static void arc4_crypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
>> +static void arc4_ivsetup(struct arc4_ctx *ctx, u8 *iv)
>> {
&
* Wang, Shane | 2010-02-21 13:32:49 [+0800]:
>--- a/crypto/vmac.cThu Feb 11 00:45:57 2010 -0800
>+++ b/crypto/vmac.cSun Feb 21 02:23:01 2010 -0800
>@@ -42,6 +42,8 @@ const u64 m63 = UINT64_C(0x7ff
> const u64 m63 = UINT64_C(0x7fff); /* 63-bit mask */
> const
* Herbert Xu | 2010-02-15 08:10:08 [+0800]:
>How about we just remove it? It's not on a hot path anyway.
Sure.
>I can do this when integrating the patch so you don't have to
>resend.
Okay, thanks.
>Thanks,
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
t
* Sebastian Andrzej Siewior | 2010-02-12 09:42:28 [+0100]:
>+static void arc4_ivsetup(struct arc4_ctx *ctx, u8 *iv)
> {
>- struct arc4_ctx *ctx = crypto_tfm_ctx(tfm);
>+ if (unlikely(!ctx->new_key))
That should be likely(). Do you want me resend the whole thing?
* Adrian-Ken Rueegsegger | 2010-02-12 10:34:27 [+0100]:
>Hi,
Hi,
>Sebastian Andrzej Siewior schrieb:
>> The name is still ecb(aes) but since this is provided by the blkcipher
>> itself,
>Just to avoid any confusion you meant ecb(arc4) not ecb(aes) here right?
Yes, I do. N
blkcipher itself,
I removed the select statement.
Signed-off-by: Sebastian Andrzej Siewior
---
I had it run with wireless and dm-crypt. No problems so far. Not sure if
it makes sense to rename it to arc4 and strip the ecb prefix. It would
make it consistent with salsa but would require another
* richih.mailingl...@gmail.com | 2010-02-10 02:17:39 [+0100]:
>From: Richard Hartmann
>
>
>Signed-off-by: Richard Hartmann
>---
> crypto/arc4.c |9 -
> 1 files changed, 4 insertions(+), 5 deletions(-)
I've made this whitespace fixes and a few others while re-writting it
yesterday. So
* Herbert Xu | 2010-02-10 07:45:19 [+1100]:
>> Herbert, what happend to the "check for streamcipher" idea you had? Is
>> it gone? On the other hand it wouldn't be probably that bad to have a
>
>Well again whether that should be done is up to the dm-crypt
>maintainers.
Milan liked that afaik.
>> s
* Herbert Xu | 2010-02-09 18:37:18 [+1100]:
>Mikulas Patocka wrote:
>>
>> You should rather add a flag CRYPTO_ALG_CHANGES_STATE to determine that a
>> cipher can't be used to encrypt disks.
>
>No, please see my reply in the previous thread. What we should
>do is fix arc4. I just haven't got a
* Bai Shuwei | 2010-01-28 17:12:46 [+0800]:
> When I add the hardware device driver for crypto, i get the bellow
>error information. My kernel is 2.6.26
>
>[ 319.938922] Call Trace:
>[ 319.938926] [] schedule+0x95/0x635
>[ 319.938934] [] :libfpga:fpga_dma_open+0xa5/0xab
>[ 319.938941] []
* Roel Kluin | 2010-01-29 14:32:56 [+0100]:
>This was already discussed in december/januari but I still cannot find it in
>mainline, was it lost?
Isn't this patch [0] and [1] in Herbert's tree? If so Herbert is
probably going to merge in the next merge window because it is not
urgend enough.
[0]
1 - 100 of 172 matches
Mail list logo
