Re: [PATCH v6 6/9] KVM: selftests: Add library support for interacting with SNP

2025-02-19 Thread Sean Christopherson
On Fri, Feb 14, 2025, Pratik Rajesh Sampat wrote: > On 2/11/25 8:12 PM, Sean Christopherson wrote: > > On Mon, Feb 03, 2025, Pratik R. Sampat wrote: > >> Extend the SEV library to include support for SNP ioctl() wrappers, > >> which aid in launching and inter

Re: [PATCH v6 9/9] KVM: selftests: Add a basic SEV-SNP smoke test

2025-02-18 Thread Sean Christopherson
On Fri, Feb 14, 2025, Pratik Rajesh Sampat wrote: > > > On 2/11/25 8:31 PM, Sean Christopherson wrote: > > On Mon, Feb 03, 2025, Pratik R. Sampat wrote: > >> @@ -217,5 +244,20 @@ int main(int argc, char *argv[]) > >>} > >>} > >

Re: [PATCH v6 9/9] KVM: selftests: Add a basic SEV-SNP smoke test

2025-02-11 Thread Sean Christopherson
On Mon, Feb 03, 2025, Pratik R. Sampat wrote: > @@ -217,5 +244,20 @@ int main(int argc, char *argv[]) > } > } > > + if (kvm_cpu_has(X86_FEATURE_SEV_SNP)) { > + uint64_t snp_policy = snp_default_policy(); > + > + test_snp(snp_policy); > +

Re: [PATCH v6 6/9] KVM: selftests: Add library support for interacting with SNP

2025-02-11 Thread Sean Christopherson
On Mon, Feb 03, 2025, Pratik R. Sampat wrote: > Extend the SEV library to include support for SNP ioctl() wrappers, > which aid in launching and interacting with a SEV-SNP guest. > > Tested-by: Srikanth Aithal > Signed-off-by: Pratik R. Sampat > --- > v5..v6: > > * Collected tags from Srikanth.

Re: [PATCH v6 4/9] KVM: selftests: Add VMGEXIT helper

2025-02-11 Thread Sean Christopherson
On Mon, Feb 03, 2025, Pratik R. Sampat wrote: > Abstract rep vmmcall coded into the VMGEXIT helper for the sev > library. > > No functional change intended. > > Reviewed-by: Pankaj Gupta > Tested-by: Srikanth Aithal > Signed-off-by: Pratik R. Sampat > --- > v5..v6: > > * Collected tags from P

Re: [PATCH v6 2/9] KVM: SEV: Disable SEV on platform init failure

2025-02-11 Thread Sean Christopherson
On Mon, Feb 03, 2025, Pratik R. Sampat wrote: > If the platform initialization sev_platform_init() fails, SEV cannot be > set up and a secure VM cannot be spawned. Therefore, in this case, > ensure that KVM does not set up, nor advertise support for SEV, SEV-ES, > and SEV-SNP. > > Suggested-by: Ni

Re: [PATCH v6 1/9] KVM: SEV: Disable SEV-SNP on FW validation failure

2025-02-11 Thread Sean Christopherson
On Mon, Feb 03, 2025, Pratik R. Sampat wrote: > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 0f04f365885c..b709c2f0945c 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -3040,7 +3040,9 @@ void __init sev_hardware_setup(void) > sev_es_asid_count

Re: [PATCH v11 00/13] Intel SGX1 support

2018-12-11 Thread Sean Christopherson
On Tue, Dec 11, 2018 at 10:10:38AM -0800, Dave Hansen wrote: > On 12/10/18 3:12 PM, Josh Triplett wrote: > >> Or maybe even python/shell scripts? It looked to me like virtual > >> memory will be "interesting" for enclaves. > > Memory management doesn't seem that hard to deal with. > > The problems

Re: [PATCH v11 06/13] crypto: aesni: add minimal build option for SGX LE

2018-06-11 Thread Sean Christopherson
On Fri, 2018-06-08 at 10:27 -0700, Dave Hansen wrote: > On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: > > > > --- a/arch/x86/crypto/aesni-intel_asm.S > > +++ b/arch/x86/crypto/aesni-intel_asm.S > > @@ -45,6 +45,8 @@ > >  #define MOVADQ movaps > >  #define MOVUDQ movups > >   > > +#ifndef