Re: [PATCH 1/2] dt-bindings: rng: bcm2835: document reset support

2021-02-23 Thread Scott Branden
On 2021-02-23 8:36 a.m., Florian Fainelli wrote: > > > On 2/23/2021 8:01 AM, Álvaro Fernández Rojas wrote: >> Some devices may need to perform a reset before using the RNG, such as the >> BCM6368. >> >> Signed-off-by: Álvaro Fernández Rojas > > Since the reset is unique to the 6368, you may wan

Re: [PATCH v2] hwrng: iproc: set quality to 1024

2021-02-22 Thread Scott Branden
00.770; > max=9765625.000)Kibits/s > rngtest: FIPS tests speed: (min=34.742; avg=39.905; max=66.458)Mibits/s > rngtest: Program run time: 97829648 microseconds > > 1000 successes and 0 failures -> 100% success rate > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Scott B

Re: [PATCH v2 2/2] hwrng: iproc-rng200: Move enable/disable in separate function

2020-12-18 Thread Scott Branden
s Brugger > Acked-by: Florian Fainelli Acked-by: Scott Branden > > --- > > Changes in v2: > - rename function to iproc_rng200_enable_set() > - use u32 value instead of uint32_t > > drivers/char/hw_random/iproc-rng200.c | 35 --- > 1 file change

Re: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block.

2020-12-18 Thread Scott Branden
we already set > the enable bit to zero by appling inverted RNG_RBGEN_MASK. > > Signed-off-by: Matthias Brugger Acked-by: Scott Branden > > --- > > Changes in v2: > - fix commit message, dropping Fixes tag > - drop inverted RNT_RBGEN_ENABLE in disable case > > dr

Re: [PATCH 2/2] hwrng: iproc-rng200: Move enable/disable in separate function

2020-12-14 Thread Scott Branden
On 2020-12-14 8:04 a.m., matthias@kernel.org wrote: > From: Matthias Brugger > > We are calling the same code for enable and disable the block in various > parts of the driver. Put that code into a new function to reduce code > duplication. Patch needs to be regenerated after most of PATCH

Re: [PATCH 1/2] hwrng: iproc-rng200: Fix disable of the block.

2020-12-14 Thread Scott Branden
On 2020-12-14 8:04 a.m., matthias@kernel.org wrote: > From: Matthias Brugger > > When trying to disable the block we bitwise or the control > register with value zero. This will leave the block always turned on. > Fix this by setting the corresponding bit to zero. > > Fixes: c83d45d5685f ("

Re: [PATCH 0/2] hwrng: iproc-rng200: Add support for BCM7278

2017-11-02 Thread Scott Branden
| 6 +++--- drivers/char/hw_random/iproc-rng200.c | 1 + 3 files changed, 7 insertions(+), 4 deletions(-) Acked-by: Scott Branden

Re: [PATCH 0/3] hw_random: bcm2835: Add support for Broadcom BCM5301x

2016-06-22 Thread Scott Branden
Patch series looks good. Acked-by: Scott Branden On 16-06-22 05:27 PM, Florian Fainelli wrote: Hi all, This patch series adds support for the Broadcom BCM5301x SoCs random number generator which is the same block as the one found in NSP and BCM2835. Florian Fainelli (3): Documentation

[PATCH v3 0/2] Add support for Broadcom RNG200

2015-03-04 Thread Scott Branden
This series of patchsets contains the Broadcom Random Number Generator driver and device tree binding documentation. Changes from v2: added usleep_range instead of cpu_relax add init and cleanup functions following new hwrng model Changes from v1: added \n to 2 dev_err messages Scott

[PATCH v3 2/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver

2015-03-04 Thread Scott Branden
This adds a driver for random number generator present on Broadcom IPROC devices. Reviewed-by: Ray Jui Signed-off-by: Scott Branden --- drivers/char/hw_random/Kconfig| 13 ++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/iproc-rng200.c | 254

[PATCH v3 1/2] hwrng: iproc-rng200 - Add device tree bindings

2015-03-04 Thread Scott Branden
Documents the IPROC random number generator device tree bindings used in some Broadcom chipsets. Reviewed-by: Ray Jui Signed-off-by: Scott Branden --- .../devicetree/bindings/hwrng/brcm,iproc-rng200.txt | 12 1 file changed, 12 insertions(+) create mode 100644