Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.

2018-12-11 Thread Sagi Grimberg
struct nvme_sgl_desc { __le64 addr; - __le32 length; + __le64 length; __u8rsvd[3]; __u8type; }; Isn't this a device or protocol defined datastructure? You can't just change it like this. You're correct, we can't... [Replied before seeing t

Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.

2018-12-11 Thread Sagi Grimberg
struct nvme_sgl_desc { __le64 addr; - __le32 length; + __le64 length; __u8rsvd[3]; __u8type; }; in what world changing a wire protocol for this make sense? please get rid of this hunk, NVMe will never cross the 32 bit sg element size.

Re: [PATCH v3 0/5] target: Fix several problems related to T10-PI support

2015-04-28 Thread Sagi Grimberg
On 4/28/2015 2:50 AM, Martin K. Petersen wrote: "Sagi" == Sagi Grimberg writes: Sagi> The problem is that the HBA does not have the write_same Sagi> functionality you introduce here, i.e. generate multiple same Sagi> protection fields for a single data block. Adding supp

Re: [PATCH v3 0/5] target: Fix several problems related to T10-PI support

2015-04-26 Thread Sagi Grimberg
On 4/25/2015 5:33 PM, Akinobu Mita wrote: This patchset aims to fix several problems related to T10-PI support. These patches can be applied on top of Sagi's "[v1] Simlify dif_verify routines and fixup fileio protection information code" patchset. Hi Akinobu, I have given this some more thou

Re: [PATCH v3 3/5] target: handle odd SG mapping for data transfer memory

2015-04-26 Thread Sagi Grimberg
: Tim Chen Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Cc: Nicholas Bellinger Cc: Sagi Grimberg Cc: "Martin K. Petersen" Cc: Christoph Hellwig Cc: "James E.J. Bottomley" Cc: target-de...@vger.kernel.org Cc: linux-s...@vger.kernel.or