Re: [PATCH v3 19/29] crypto: mips/poly1305 - incorporate OpenSSL/CRYPTOGAMS optimized implementation

2019-10-11 Thread René van Dorst
Hi Andy, Quoting Andy Polyakov : Hi, On 10/8/19 1:38 PM, Andy Polyakov wrote: Hi Ard, Is it also an option to include my mip32r2 optimized poly1305 version? Below the results which shows a good improvement over the Andy Polyakov version. I swapped the poly1305 assembly file and rename th

Re: [PATCH v3 19/29] crypto: mips/poly1305 - incorporate OpenSSL/CRYPTOGAMS optimized implementation

2019-10-08 Thread René van Dorst
Quoting Andy Polyakov : Hi, On 10/7/19 11:02 PM, René van Dorst wrote: Quoting Ard Biesheuvel : This is a straight import of the OpenSSL/CRYPTOGAMS Poly1305 implementation for MIPS authored by Andy Polyakov, and contributed by him to the OpenSSL project. Formally speaking this is a little

Re: [PATCH v3 19/29] crypto: mips/poly1305 - incorporate OpenSSL/CRYPTOGAMS optimized implementation

2019-10-07 Thread René van Dorst
Quoting Ard Biesheuvel : This is a straight import of the OpenSSL/CRYPTOGAMS Poly1305 implementation for MIPS authored by Andy Polyakov, and contributed by him to the OpenSSL project. The file 'poly1305-mips.pl' is taken straight from this upstream GitHub repository [0] at commit 57c3a63be70b4f6

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-06 Thread René van Dorst
Quoting Ard Biesheuvel : Hi Ard, Thanks a lot for taking the time to double check this. I think it would be nice to be able to expose xchacha12 like we do on other architectures. Note that for xchacha, I also added a hchacha_block() routine based on your code (with the round count as the thi

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-05 Thread René van Dorst
Hi Ard and Jason, Quoting Ard Biesheuvel : On Fri, 4 Oct 2019 at 17:15, René van Dorst wrote: Hi Jason, Quoting "Jason A. Donenfeld" : > On Fri, Oct 4, 2019 at 4:44 PM Ard Biesheuvel > wrote: >> The round count is passed via the fifth function parameter, so it is &

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-04 Thread René van Dorst
Hi Jason, Quoting "Jason A. Donenfeld" : On Fri, Oct 4, 2019 at 4:44 PM Ard Biesheuvel wrote: The round count is passed via the fifth function parameter, so it is already on the stack. Reloading it for every block doesn't sound like a huge deal to me. Please benchmark it to indicate that,