Re: [RFC PATCH] gcm - fix setkey cache coherence issues

2017-06-23 Thread Radu Solea
On Vi, 2017-06-23 at 14:31 +0800, Herbert Xu wrote: > > The crypto API cannot rely on users providing aligned buffers.  So > if your driver has an alignment requirement, it either has to use > the existing crypto API alignmask setting which can cope with some > unaligned inputs, e.g., the IV if yo

Re: [RFC PATCH] gcm - fix setkey cache coherence issues

2017-06-22 Thread Radu Solea
On Jo, 2017-06-22 at 15:53 +0800, Herbert Xu wrote: > On Thu, Jun 22, 2017 at 05:03:44AM +0000, Radu Solea wrote: > > > > I'm adding cacheline_aligned to iv and result. That is done so > > hash, iv and result never share a cache line. > Yes but you're doing i

[RFC PATCH] gcm - fix setkey cache coherence issues

2017-06-21 Thread Radu Solea
issues. Signed-off-by: Radu Solea --- Hi! I've encountered cache coherence issues when using GCM with CAAM and this was one way of fixing them but it has its drawbacks. Another would be to allocate each element instead of all at once, but that only decreases the likelyhood of this happening.