.
Quick glance would work if it is readable. Currently it is not if one is
viewing it in 80 cols screen/window. They do that. Writing return on the same
line does not add specific value IMO.
Up to you; I pointed it out as 80 columns rule makes sense to me.
--
- P J P
47AF CE69 3A90 54AA 9045
+-- On Wed, 4 Oct 2017, Borislav Petkov wrote --+
| On Wed, Oct 04, 2017 at 12:26:11PM +0530, P J P wrote:
| > Each return above needs to be on its own line.
|
| ... because?
It appears to cross 80 columns limit, checkpatch.pl throws warnings. Adding
new line would be consistent with cod
SEV_CMD_RECEIVE_UPDATE_VMSA:return sizeof(struct
sev_data_receive_update_vmsa);
| + case SEV_CMD_LAUNCH_UPDATE_SECRET:return sizeof(struct
sev_data_launch_secret);
| + default:return 0;
| + }
Each return above needs to be on its own line.
--
- P J P
47AF CE69
err;
| +
| + sp->psp_data = psp;
| ...
| +e_err:
| + sp->psp_data = NULL;
Needs to kfree(sp->psp_data) before setting to NULL.
--
- P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
