Re: [PATCH] crypto: virtio/akcipher - Fix stack overflow on memcpy

2024-01-31 Thread Nathan Chancellor
rtio-crypto: implement RSA algorithm") > Link: > https://lore.kernel.org/all/0a194a79-e3a3-45e7-be98-83abd3e1c...@roeck-us.net/ > Signed-off-by: zhenwei pi I can confirm this resolves the warning for me as well. Tested-by: Nathan Chancellor # build I suspect Guenter should have a formal Repo

Re: [PATCH 5.10 000/286] 5.10.209-rc1 review

2024-01-26 Thread Nathan Chancellor
On Fri, Jan 26, 2024 at 03:55:02PM -0800, Guenter Roeck wrote: > Anyway, how did you find that ? Is there a magic trick to find the > actual code causing the warning ? I am asking because we had seen > similar warnings before, and it would help to know how to find the > problematic code. The easie

Re: [PATCH 5.10 000/286] 5.10.209-rc1 review

2024-01-26 Thread Nathan Chancellor
(slimming up the CC list, I don't think this is too relevant to the wider stable community) On Fri, Jan 26, 2024 at 01:01:15PM -0800, Guenter Roeck wrote: > On 1/26/24 12:34, Nathan Chancellor wrote: > > On Fri, Jan 26, 2024 at 10:17:23AM -0800, Guenter Roeck wrote: > > >

[PATCH] crypto: arm/curve25519 - Move '.fpu' after '.arch'

2021-04-09 Thread Nathan Chancellor
clang with and without Debian's patch and GCC. Cc: sta...@vger.kernel.org Fixes: d8f1308a025f ("crypto: arm/curve25519 - wire up NEON implementation") Link: https://github.com/ClangBuiltLinux/continuous-integration2/issues/118 Reported-by: Arnd Bergmann Suggested-by: Arnd Bergmann

Re: [PATCH 1/2] crypto: octeontx2 - fix -Wpointer-bool-conversion warning

2021-02-04 Thread Nathan Chancellor
. > > Fixes: 64506017030d ("crypto: octeontx2 - add LF framework") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- > drivers/crypto/marvell/octeontx2/otx2_cptlf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/

Re: [PATCH] crypto: crypto4xx - Replace bitwise OR with logical OR in crypto4xx_build_pd

2020-11-12 Thread Nathan Chancellor
On Thu, Nov 12, 2020 at 10:21:35PM +0100, Christian Lamparter wrote: > Hello, > > On 12/11/2020 21:07, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/crypto/amcc/crypto4xx_core.c:921:60: warning: operator '?:' has > > lower prece

[PATCH] crypto: crypto4xx - Replace bitwise OR with logical OR in crypto4xx_build_pd

2020-11-12 Thread Nathan Chancellor
_AHASH or CRYPTO_ALG_TYPE_AEAD. Change the operator so that everything works properly. Fixes: 4b5b79998af6 ("crypto: crypto4xx - fix stalls under heavy load") Link: https://github.com/ClangBuiltLinux/linux/issues/1198 Signed-off-by: Nathan Chancellor --- drivers/crypto/amcc/crypto4xx_core.

Re: [PATCH] treewide: Remove stringification from __alias macro definition

2020-10-30 Thread Nathan Chancellor
ion > itself contains a quote character. So avoid these differences by always > using quotes to define the aliased symbol. > > Remove the stringification and add quotes and when necessary a stringification > when existing uses have a ## concatenation. > > Signed-off-by:

[PATCH] crypto: xor - Remove unused variable count in do_xor_speed

2020-10-06 Thread Nathan Chancellor
enchmarking") Link: https://github.com/ClangBuiltLinux/linux/issues/1171 Signed-off-by: Nathan Chancellor --- crypto/xor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crypto/xor.c b/crypto/xor.c index a0badbc03577..eacbf4f93990 100644 --- a/crypto/xor.c +++ b/crypto/

Re: [PATCH 2/2] crypto: sa2ul: fix compiler warning produced by clang

2020-08-25 Thread Nathan Chancellor
On Tue, Aug 25, 2020 at 04:31:06PM +0300, Tero Kristo wrote: > Clang detects a warning for an assignment that doesn't really do > anything. Fix this by removing the offending piece of code. > > Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") > Reported-b

Re: [PATCHv6 2/7] crypto: sa2ul: Add crypto driver

2020-08-21 Thread Nathan Chancellor
On Mon, Jul 13, 2020 at 11:34:22AM +0300, Tero Kristo wrote: > From: Keerthy > > Adds a basic crypto driver and currently supports AES/3DES > in cbc mode for both encryption and decryption. > > Signed-off-by: Keerthy > [t-kri...@ti.com: major re-work to fix various bugs in the driver and to >

Re: [PATCH] x86: crypto: fix building crc32c with clang ias

2020-05-27 Thread Nathan Chancellor
On Wed, May 27, 2020 at 08:24:35PM +0200, Arnd Bergmann wrote: > On Wed, May 27, 2020 at 6:42 PM Nathan Chancellor > wrote: > > > > On Wed, May 27, 2020 at 04:17:40PM +0200, Arnd Bergmann wrote: > > > The clang integrated assembler complains about movzxw: > > &

Re: [PATCH] x86: crypto: fix building crc32c with clang ias

2020-05-27 Thread Nathan Chancellor
tor, see the discussion and result in the issue below. https://github.com/ClangBuiltLinux/linux/issues/1010 Reviewed-by: Nathan Chancellor > --- > arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/crypto/cr

Re: [PATCH] crypto: blake2b - Fix clang optimization for ARMv7-M

2020-05-08 Thread Nathan Chancellor
On Fri, May 08, 2020 at 11:31:07PM +0200, Arnd Bergmann wrote: > On Wed, May 6, 2020 at 7:12 AM Nathan Chancellor > wrote: > > > - > > > +#ifdef CONFIG_CC_IS_CLANG > > > > Given your comment in the bug: > > > > "The code is written to assume

Re: [PATCH] crypto: blake2b - Fix clang optimization for ARMv7-M

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 03:53:45PM +0200, Arnd Bergmann wrote: > When building for ARMv7-M, clang-9 or higher tries to unroll some loops, > which ends up confusing the register allocator to the point of generating > rather bad code and using more than the warning limit for stack frames: > > warnin

Re: [PATCH] Kbuild: disable FORTIFY_SOURCE on clang-10

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 03:02:16PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > On Tue, May 5, 2020 at 2:55 PM Jason A. Donenfeld wrote: > > > > clang-10 has a broken optimization stage that doesn't enable the > > compiler to prove at compile time that certain memcpys are within > > b

Re: [PATCH] crypto: aegis128/simd - build 32-bit ARM for v8 architecture explicitly

2019-10-02 Thread Nathan Chancellor
es the crypto-neon-fp-armv8 > FPU profile we specify. Since neither were actually supported by GCC > versions before 4.8, let's tighten the Kconfig dependencies as well so > we won't run into errors when building with an ancient compiler. > > Signed-off-by: Ard Biesheuvel

Re: [PATCH] crypto: arm64/aegis128 - use explicit vector load for permute vectors

2019-08-19 Thread Nathan Chancellor
does not implement > the vld1q_u8_x4() intrinsic, switch from IS_ENABLED() to a preprocessor > conditional to conditionally include this code. > > Reported-by: Nathan Chancellor > Signed-off-by: Ard Biesheuvel I am not familiar enough with vectors and such to confidently give a re

[PATCH v2] lib/mpi: Eliminate unused umul_ppmm definitions for MIPS

2019-08-12 Thread Nathan Chancellor
ttps://github.com/ClangBuiltLinux/linux/issues/605 Suggested-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- This supersedes the following two patches: https://lore.kernel.org/lkml/20190812033120.43013-4-natechancel...@gmail.com/ https://lore.kernel.org/lkml/20190812033120.43013-5-natechanc

[PATCH] hwrng: optee: Initialize some structs using memset instead of braces

2019-02-18 Thread Nathan Chancellor
-dc7a-a45c-64187ecd9...@amd.com/ [2]: https://lore.kernel.org/lkml/20181128.215241.702406654469517539.da...@davemloft.net/ Fixes: 5fe8b1cc6a03 ("hwrng: add OP-TEE based rng driver") Link: https://github.com/ClangBuiltLinux/linux/issues/369 Signed-off-by: Nathan Chancellor --- drivers/char/

[PATCH] crypto: ux500 - Use proper enum in cryp_set_dma_transfer

2018-12-10 Thread Nathan Chancellor
t, we can just use the proper value from dma_transfer_direction so there is no more conversion. DMA_TO_DEVICE = DMA_MEM_TO_DEV = 1 DMA_FROM_DEVICE = DMA_DEV_TO_MEM = 2 Signed-off-by: Nathan Chancellor --- drivers/crypto/ux500/cryp/cryp_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH] crypto: ux500 - Use proper enum in hash_set_dma_transfer

2018-12-10 Thread Nathan Chancellor
top of this function so we can just use the equivalent value from dma_transfer_direction. DMA_TO_DEVICE = DMA_MEM_TO_DEV = 1 Signed-off-by: Nathan Chancellor --- drivers/crypto/ux500/hash/hash_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ux500/hash/ha

[PATCH] crypto: ccree - avoid implicit enum conversion

2018-10-10 Thread Nathan Chancellor
a problem because these values just represent simple integers for a shift operation, make it clear to Clang that this is okay by making the mode parameter in both functions an int. Link: https://github.com/ClangBuiltLinux/linux/issues/46 Signed-off-by: Nathan Chancellor --- Alternative

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Nathan Chancellor
On Mon, Sep 24, 2018 at 02:42:56PM -0700, Nick Desaulniers wrote: > On Mon, Sep 24, 2018 at 2:22 PM Gary R Hook wrote: > > > > On 09/24/2018 02:40 PM, Nathan Chancellor wrote: > > > On Mon, Sep 24, 2018 at 07:18:23PM +, Gary R Hook wrote: > > >> On 09/24/20

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Nathan Chancellor
On Mon, Sep 24, 2018 at 07:18:23PM +, Gary R Hook wrote: > On 09/24/2018 12:26 PM, Nathan Chancellor wrote: > > Clang emits a warning about this construct: > > > > drivers/crypto/ccp/sp-platform.c:36:36: warning: tentative array > > definition assumed to have o

[PATCH] crypto: ccp: Remove forward declaration

2018-09-24 Thread Nathan Chancellor
and move the initializations up so that they can be used in sp_get_of_version and sp_get_acpi_version. Reported-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- drivers/crypto/ccp/sp-platform.c | 53 +++- 1 file changed, 25 insertions(+), 28 deletions(-) diff