Re: [PATCH] crypto: aesni-intel - avoid IPsec re-ordering

2014-11-12 Thread Ming Liu
On 11/12/2014 07:48 PM, Steffen Klassert wrote: On Wed, Nov 12, 2014 at 06:41:28PM +0800, Ming Liu wrote: On 11/12/2014 04:41 PM, Steffen Klassert wrote: On Wed, Nov 12, 2014 at 01:49:31PM +0800, Ming Liu wrote: } @@ -147,11 +149,9 @@ static void cryptd_queue_worker(struct work_struct *work

Re: [PATCH] crypto: aesni-intel - avoid IPsec re-ordering

2014-11-12 Thread Ming Liu
On 11/12/2014 07:43 PM, Steffen Klassert wrote: On Wed, Nov 12, 2014 at 06:41:30PM +0800, Ming Liu wrote: On 11/12/2014 04:51 PM, Herbert Xu wrote: On Wed, Nov 12, 2014 at 09:41:38AM +0100, Steffen Klassert wrote: Can't we just use cryptd unconditionally to fix this reordering proble

Re: [PATCH] crypto: aesni-intel - avoid IPsec re-ordering

2014-11-12 Thread Ming Liu
On 11/12/2014 04:41 PM, Steffen Klassert wrote: On Wed, Nov 12, 2014 at 01:49:31PM +0800, Ming Liu wrote: So far, the encryption/decryption are asynchronously processed in softirq and cryptd which would result in a implicit order of data, therefore leads IPSec stack also out of order while

Re: [PATCH] crypto: aesni-intel - avoid IPsec re-ordering

2014-11-12 Thread Ming Liu
equests already in it, this will let the net poll functions return pretty fast, and lead too many hw interrupts triggered in a certain period. //Ming Liu Cheers, -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kerne

[PATCH] crypto: aesni-intel - avoid IPsec re-ordering

2014-11-11 Thread Ming Liu
ued elements before processing a new one. To prevent cryptd_flush_queue() being accessed from software interrupts, local_bh_disable/enable needs to be relocated in several places. Signed-off-by: Ming Liu --- I was told that I need resend this patch with git, so here it is: I've figured out a n

Re: HELP: IPsec reordering issue

2014-11-11 Thread Ming Liu
test, would you please review it? the best, thank you On 08/14/2014 04:47 PM, Herbert Xu wrote: On Sun, Aug 03, 2014 at 05:57:06PM +0800, Ming Liu wrote: Please review this attached patch instead, the original one has a problem causing the kernel crash. Thanks for the patch. I think it would bett

Re: HELP: IPsec reordering issue

2014-08-03 Thread Ming Liu
On 07/31/2014 02:23 PM, Herbert Xu wrote: On Thu, Jul 31, 2014 at 11:07:26AM +0800, Ming Liu wrote: And we've figure out a patch as the attached, the basic idea is just queue the packets if "irq_fpu_usable()" is not usable or if there are already few packets queued for decryptio

Re: HELP: IPsec reordering issue

2014-07-30 Thread Ming Liu
On 07/31/2014 02:23 PM, Herbert Xu wrote: On Thu, Jul 31, 2014 at 11:07:26AM +0800, Ming Liu wrote: And we've figure out a patch as the attached, the basic idea is just queue the packets if "irq_fpu_usable()" is not usable or if there are already few packets queued for decryptio

HELP: IPsec reordering issue

2014-07-30 Thread Ming Liu
ec doesn't guarantee order at all. Appreciate it very much! the best, thank you >From eb0fe7074c61b4e57456c578db897928eb951db9 Mon Sep 17 00:00:00 2001 From: Ming Liu Date: Thu, 31 Jul 2014 09:11:51 +0800 Subject: [PATCH] crypto: aesni-intel - avoid encrypt/decrypt re-ordering on particular cpu So