ipher (for example "chacha20"
> > > + or "ctr(aes)").
> >
> > You should check with the dm-integrity maintainers how likely it is that
> > people
> > are using salsa20 with dm-integrity. It's possible that people are using
> > it,
> > especially since the documentation says that dm-integrity can use a stream
> > cipher and specifically gives salsa20 as an example.
> >
>
> Good point - cc'ed them now.
>
No problem here, if others don't find utility in salsa20 then
dm-integrity certainly isn't the hold-out.
Acked-by: Mike Snitzer
Mike
(checksums_onstack))) {
> + r = -EINVAL;
> + goto error;
> + }
> + }
>
> __bio_for_each_segment(bv, bio, iter, dio->orig_bi_iter) {
> unsigned pos;
Given the length of the kmalloc() just prior to this new WARN_ON() line
I'm not seeing why you've elected to split the WARN_ON across multiple
lines.
But that style nit aside:
Acked-by: Mike Snitzer
On Wed, Jan 10 2018 at 9:32am -0500,
Mikulas Patocka wrote:
>
>
> On Wed, 27 Dec 2017, Herbert Xu wrote:
>
> > On Tue, Dec 26, 2017 at 02:21:53PM +0200, Gilad Ben-Yossef wrote:
> > >
> > > See how SKCIPHER_REQUEST_ON_STACK is being used with an asymmetric
> > > skcipher
> > > in drivers/md/
On Wed, May 10 2017 at 9:37am -0400,
Gilad Ben-Yossef wrote:
> On Wed, May 10, 2017 at 11:49 AM, Neeraj Soni wrote:
> > Hi Keith,
> >
> > Request based dm (dm-req-crypt) is being used for Disk Encryption solution
> > in Android used by Google. Also as i mentioned reverting this fix improves
>
On Thu, Apr 06 2017 at 5:29am -0400,
Herbert Xu wrote:
> On Fri, Mar 10, 2017 at 02:44:26PM +0100, Ondrej Mosnacek wrote:
> > Hi all,
> >
> > I was tasked to post a summary the whole dm-crypt IV generation
> > problem and all the suggested solutions along with their drawbacks, so
> > here it go
On Fri, Mar 10 2017 at 8:44am -0500,
Ondrej Mosnacek wrote:
> Hi all,
>
> I was tasked to post a summary the whole dm-crypt IV generation
> problem and all the suggested solutions along with their drawbacks, so
> here it goes...
Thanks for the summary.
...
> 2. Restrict the keycount paramete
Comments inlined.
In general the most concerning bit is the need for memory allocation in
the IO path (see comment/question below near call to sg_alloc_table).
In DM targets we make heavy use of .ctr preallocated memory and/or
per-bio-data to avoid memory allocations in the IO path.
On Wed, May 2
On Mon, Apr 18 2016 at 1:31am -0400,
Baolin Wang wrote:
> Hi Herbert,
>
> On 15 April 2016 at 21:48, Herbert Xu wrote:
> > On Tue, Mar 15, 2016 at 03:47:58PM +0800, Baolin Wang wrote:
> >> Now some cipher hardware engines prefer to handle bulk block by merging
> >> requests
> >> to increase t
