Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-16 Thread Michał Mirosław
work in the kernel. > [0] > https://github.com/terrelln/linux/commit/ac2ee65dcb7318afe426ad08f6a844faf3aebb41 I looks like you could remove a bit more dead code by noting __GNUC__ >= 4 (gcc-4.9 is currently the oldest supported [1]). [1] Documentation/process/changes.rst Best Regards Michał Mirosław

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
On Thu, Dec 03, 2020 at 03:59:21AM +, Nick Terrell wrote: > On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote: > > On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: > >> On Dec 2, 2020, at 5:16 PM, Michał Mirosław > >> wrote: > >>> On Wed,

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: > > > > On Dec 2, 2020, at 5:16 PM, Michał Mirosław wrote: > > > > On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote: > >> From: Nick Terrell > >> > >> This patch: >

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
put, struct zstd_in_buffer *input) > +{ > + ZSTD_outBuffer o; > + ZSTD_inBuffer i; > + size_t ret; > + > + memcpy(&o, output, sizeof(o)); > + memcpy(&i, input, sizeof(i)); > + ret = ZSTD_compressStream(cstream, &o, &i); > + memcpy(output, &o, sizeof(o)); > + memcpy(input, &i, sizeof(i)); > + return ret; > +} Is all this copying necessary? How is it different from type-punning by direct pointer cast? Best Regards Michał Mirosław

Re: [dm-devel] [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

2014-09-15 Thread Michał Mirosław
sh = (struct shash_desc *)__desc > + char shash##__desc[] or similar? Otherwise it won't work if you use this macro twice in the same block. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to