Re: [v2 PATCH] crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()

2020-06-12 Thread Mauricio Faria de Oliveira
Hi Herbert, On Wed, Jun 10, 2020 at 11:28 AM Mauricio Faria de Oliveira wrote: > > On Tue, Jun 9, 2020 at 9:21 PM Herbert Xu wrote: > > > > On Tue, Jun 09, 2020 at 12:17:32PM -0300, Mauricio Faria de Oliveira wrote: > > > > > > Per your knowledge/exper

Re: [v2 PATCH] crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()

2020-06-10 Thread Mauricio Faria de Oliveira
On Tue, Jun 9, 2020 at 9:21 PM Herbert Xu wrote: > > On Tue, Jun 09, 2020 at 12:17:32PM -0300, Mauricio Faria de Oliveira wrote: > > > > Per your knowledge/experience with the crypto subsystem, the changed code > > paths are not hot enough to suffer from such implica

Re: [v2 PATCH] crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()

2020-06-09 Thread Mauricio Faria de Oliveira
Hi Herbert, On Mon, Jun 8, 2020 at 3:49 AM Herbert Xu wrote: > > On Fri, Jun 05, 2020 at 01:16:57PM -0300, Mauricio Faria de Oliveira wrote: > > This patch fixes a regression from commit 37f96694cf73 ("crypto: af_alg > > - Use bh_lock_sock in sk_destruct"), which

[PATCH] crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()

2020-06-05 Thread Mauricio Faria de Oliveira
[1] https://docs.varnish-software.com/varnish-cache-plus/vmods/total-encryption/ Fixes: 37f96694cf73 ("crypto: af_alg - Use bh_lock_sock in sk_destruct") Reported-by: Brian Moyles Signed-off-by: Mauricio Faria de Oliveira --- crypto/af_alg.c | 117 +++