Re: [PATCH 1/2] hwrng: iproc-rng200: Fix disable of the block.

2020-12-18 Thread Matthias Brugger
On 14/12/2020 18:45, Scott Branden wrote: > > > On 2020-12-14 8:04 a.m., matthias@kernel.org wrote: >> From: Matthias Brugger >> >> When trying to disable the block we bitwise or the control >> register with value zero. This will leave the block always

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Matthias Brugger
default: dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", urb->status); - fallthrough; - case 0: break; } Reviewed-by: Matthias Brugger

Re: [PATCH v2 1/3] dt-bindings: rng: add MediaTek MT7622 Hardware Random Generator bindings

2017-06-13 Thread Matthias Brugger
(-) Reviewed-by: Matthias Brugger diff --git a/Documentation/devicetree/bindings/rng/mtk-rng.txt b/Documentation/devicetree/bindings/rng/mtk-rng.txt index a6d62a2..366b99b 100644 --- a/Documentation/devicetree/bindings/rng/mtk-rng.txt +++ b/Documentation/devicetree/bindings/rng/mtk-rng.txt @@ -2,7

Re: [PATCH 1/4] dt-bindings: rng: add generic bindings for MediaTek SoCs

2017-06-07 Thread Matthias Brugger
On 07/06/17 15:20, Sean Wang wrote: On Tue, 2017-06-06 at 13:07 +0200, Matthias Brugger wrote: On 31/05/17 20:44, sean.w...@mediatek.com wrote: From: Sean Wang Add the generic binding for allowing the support of RNG on MediaTek SoCs such as MT7622. Signed-off-by: Sean Wang

Re: [PATCH 1/4] dt-bindings: rng: add generic bindings for MediaTek SoCs

2017-06-06 Thread Matthias Brugger
On 31/05/17 20:44, sean.w...@mediatek.com wrote: From: Sean Wang Add the generic binding for allowing the support of RNG on MediaTek SoCs such as MT7622. Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/rng/mtk-rng.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH 2/2] crypto: mediatek - update DT binding documentation

2017-05-26 Thread Matthias Brugger
On 26/05/17 11:43, Ryder Lee wrote: This patch removes unnecessary clock in binding file. Signed-off-by: Ryder Lee --- In the driver clocks are get by name, so this change does not break backwards compatibility. Reviewed-by: Matthias Brugger Documentation/devicetree/bindings/crypto

Re: [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant

2017-05-19 Thread Matthias Brugger
On 19/05/17 08:53, Corentin Labbe wrote: This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- Reviewed-by: Matthias Brugger drivers/crypto/mediatek/mtk-sha.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

Re: [PATCH] crypto: arm64/crc32 - merge CRC32 and PMULL instruction based drivers

2017-02-02 Thread Matthias Brugger
Biesheuvel --- This is a meaningful patch by itself imho, but also fixes the issue reported by Matthias where their v4.8 based GCC does not understand the -mcpu=generic+crc command line option, resulting in failed builds. This patch fixes the issue, thanks. Tested-by: Matthias Brugger arch

Re: [PATCH v1 2/2] crypto: mediatek - add DT bindings documentation

2016-12-09 Thread Matthias Brugger
On 08/12/16 10:19, Ryder Lee wrote: Hello, On Mon, 2016-12-05 at 11:18 +0100, Matthias Brugger wrote: On 05/12/16 08:01, Ryder Lee wrote: Add DT bindings documentation for the crypto driver Signed-off-by: Ryder Lee --- .../devicetree/bindings/crypto/mediatek-crypto.txt | 32

Re: [PATCH v1 2/2] crypto: mediatek - add DT bindings documentation

2016-12-05 Thread Matthias Brugger
On 05/12/16 08:01, Ryder Lee wrote: Add DT bindings documentation for the crypto driver Signed-off-by: Ryder Lee --- .../devicetree/bindings/crypto/mediatek-crypto.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/crypto/m