Re: [PATCH V3 1/2] evm: Don't deadlock if a crypto algorithm is unavailable

2018-06-12 Thread Matthew Garrett
On Fri, Jun 8, 2018 at 2:57 PM Matthew Garrett wrote: > > When EVM attempts to appraise a file signed with a crypto algorithm the > kernel doesn't have support for, it will cause the kernel to trigger a > module load. If the EVM policy includes appraisal of kernel modules this &g

[PATCH V3 1/2] evm: Don't deadlock if a crypto algorithm is unavailable

2018-06-08 Thread Matthew Garrett
rypto initialisation is complete, this triggers a deadlock. Add a CRYPTO_NOLOAD flag and skip module loading if it's set, and add that flag in the EVM case in order to fail gracefully with an error message instead of deadlocking. Signed-off-by: Matthew Garrett --- crypto/api.c

Support additional signature types in EVM

2018-06-08 Thread Matthew Garrett
Same as V2, but rebased on next-integrity

[PATCH V3 2/2] evm: Allow non-SHA1 digital signatures

2018-06-08 Thread Matthew Garrett
s for validation. Signed-off-by: Matthew Garrett --- security/integrity/evm/evm.h| 10 -- security/integrity/evm/evm_crypto.c | 47 +++-- security/integrity/evm/evm_main.c | 19 +++- 3 files changed, 45 insertions(+), 31 deletions(-) diff --git a/sec

[PATCH V2 2/2] evm: Allow non-SHA1 digital signatures

2018-06-06 Thread Matthew Garrett
s for validation. Signed-off-by: Matthew Garrett --- security/integrity/evm/evm.h| 10 -- security/integrity/evm/evm_crypto.c | 47 +++-- security/integrity/evm/evm_main.c | 19 +++- 3 files changed, 45 insertions(+), 31 deletions(-) diff --git a/sec

[PATCH V2 1/2] evm: Don't deadlock if a crypto algorithm is unavailable

2018-06-06 Thread Matthew Garrett
rypto initialisation is complete, this triggers a deadlock. Add a CRYPTO_NOLOAD flag and skip module loading if it's set, and add that flag in the EVM case in order to fail gracefully with an error message instead of deadlocking. Signed-off-by: Matthew Garrett --- crypto/api.c

Re: [PATCH 1/2] evm: Don't deadlock if a crypto algorithm is unavailable

2018-06-04 Thread Matthew Garrett
On Sat, Jun 2, 2018 at 8:54 AM Herbert Xu wrote: > > On Fri, Jun 01, 2018 at 04:02:43PM -0700, Matthew Garrett wrote: > > Trying to instantiate a non-existent crypto algorithm will cause the > > kernel to trigger a module load. If EVM appraisal is enabled, this will > > i

[PATCH 2/2] evm: Allow non-SHA1 digital signatures

2018-06-01 Thread Matthew Garrett
s for validation. Signed-off-by: Matthew Garrett --- security/integrity/evm/evm.h| 10 -- security/integrity/evm/evm_crypto.c | 47 +++-- security/integrity/evm/evm_main.c | 19 +++- 3 files changed, 45 insertions(+), 31 deletions(-) diff --git a/sec

[PATCH 1/2] evm: Don't deadlock if a crypto algorithm is unavailable

2018-06-01 Thread Matthew Garrett
ng if it's set, and add that flag in the EVM case. Signed-off-by: Matthew Garrett --- crypto/api.c| 2 +- include/linux/crypto.h | 5 + security/integrity/evm/evm_crypto.c | 3 ++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/cryp

Re: [RFC PATCH 00/18 v3] Signature verification of hibernate snapshot

2013-09-01 Thread Matthew Garrett
On Sun, Sep 01, 2013 at 06:40:41PM +0200, Florian Weimer wrote: > * Matthew Garrett: > > > On Sun, Sep 01, 2013 at 12:41:22PM +0200, Florian Weimer wrote: > > > >> But if you don't generate fresh keys on every boot, the persistent > >> keys are mor expose

Re: [RFC PATCH 00/18 v3] Signature verification of hibernate snapshot

2013-09-01 Thread Matthew Garrett
different UEFI applications, so if anyone gets a generic UEFI variable > dumper (or setter) signed by the trusted key, this cryptographic > validation of hibernate snapshots is bypassable. If anyone can execute arbitrary code in your UEFI environment then you've already lost. -- Matth

Re: [PATCH 10/18] efi: Enable secure boot lockdown automatically when enabled in firmware

2013-08-25 Thread Matthew Garrett
On Sun, Aug 25, 2013 at 06:22:43PM +0200, Pavel Machek wrote: > On Thu 2013-08-22 19:01:49, Lee, Chun-Yi wrote: > > From: Matthew Garrett > > > > The firmware has a set of flags that indicate whether secure boot is enabled > > and enforcing. Use them to indicate whe

Re: [RFC 1/1] ima: digital signature verification using asymmetric keys

2013-01-29 Thread Matthew Garrett
the initramfs containing the bootsplash theme and users expecting to be able to change that without having to generate crypto keys, but that's probably not a showstopper. But realistically, the first three problems make it unlikely that most distributions will be willing to depend on or