Re: [patch] s390/crypto: unlock on error in prng_tdes_read()

On Fri, 18 Nov 2016 14:11:00 +0300 Dan Carpenter wrote: > We added some new locking but forgot to unlock on error. > > Fixes: 57127645d79d ("s390/zcrypt: Introduce new SHA-512 based Pseudo Random > Generator.") > Signed-off-by: Dan Carpenter > > diff --git a/arch/s390/crypto/prng.c b/arch/s39

Re: [PATCH] s390/crypto: initialize ret to zero to avoid returning garbage value

On Mon, 5 Sep 2016 17:21:18 +0100 Colin King wrote: > From: Colin Ian King > > static analysis with cppcheck detected that ret is not initialized > and hence garbage is potentially being returned in the case where > prng_data->ppnows.reseed_counter <= prng_reseed_limit. > > Signed-off-by: Col

[PATCH] crypto/xor: skip speed test if the xor function is selected automatically

: Martin Schwidefsky --- crypto/xor.c | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/crypto/xor.c b/crypto/xor.c index 35d6b3a..b8975d9 100644 --- a/crypto/xor.c +++ b/crypto/xor.c @@ -109,6 +109,18 @@ calibrate_xor_blocks(void

[PATCH] hwrng: correct error check of kthread_run call

The kthread_run() function can return two different error values but the hwrng core only checks for -ENOMEM. If the other error value -EINTR is returned it is assigned to hwrng_fill and later used on a kthread_stop() call which naturally crashes. Signed-off-by: Martin Schwidefsky --- drivers

Re: crypto: sha-s390 - Switch to shash

On Wed, 2009-01-28 at 14:56 +1100, Herbert Xu wrote: > On Mon, Jan 19, 2009 at 09:55:17AM +1100, Herbert Xu wrote: > > > > Could you let me if this patch breaks s390? > > > > commit 0fe7dddf02811152d7e58747bfe419ec0f43ea4e > > Author: Herbert Xu > > Date: Sun Jan 18 20:33:33 2009 +1100 > > >