On Thu, Jul 23, 2020 at 08:08:43AM +0200, Christoph Hellwig wrote:
> The __user doesn't make sense when casting to an integer type, just
> switch to a uintptr_t cast which also removes the need for the __force.
Feel free to add my:
Reviewed-by: Luc Van Oostenryck
-- Luc
On Mon, Jul 20, 2020 at 02:47:15PM +0200, Christoph Hellwig wrote:
> The __user doesn't make sense when casting to an integer type.
>
> Signed-off-by: Christoph Hellwig
> ---
> net/bpfilter/bpfilter_kern.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bpfilter/bpf
On Thu, Jul 09, 2020 at 10:09:37PM +1000, Herbert Xu wrote:
> On Thu, Jul 09, 2020 at 11:51:10AM +0300, Ard Biesheuvel wrote:
> >
> > That looks like a sparse bug to me. Since when is it not allowed to
> > pass a non-const value as a const parameter?
> >
> > I.e., you can pass a u64[] to a functio
On Thu, Mar 22, 2018 at 11:16:55AM -0600, Logan Gunthorpe wrote:
> Sparse produces a few warnings of the form:
>
> lib/iomap.c:84:9: warning: cast to restricted __be16
>
> (The kbuild robot has recently started running such checks)
Reviewed-by: Luc Van Oostenryck
and code analysis tools alike.
>
> Signed-off-by: Logan Gunthorpe
> Cc: Philippe Ombredanne
> Cc: Thomas Gleixner
> Cc: Kate Stewart
> Cc: Greg Kroah-Hartman
> Cc: Luc Van Oostenryck
> ---
> lib/iomap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
)
> +#define mmio_write32be(val, port) \
> + __raw_writel((u32 __force)cpu_to_be32(val), port)
> #endif
I think that in this sort of replacement, it's better to not split
the lines (even if larger than 80, that's it).
-- Luc Van Oostenryck
