Re: [PATCH v2 4/4] ARM64: dts: amlogic: adds crypto hardware node

2019-10-16 Thread Kevin Hilman
t; + interrupts = , > + ; > + clocks = <&clkc CLKID_BLKMV>; > + clock-names = "blkmv"; > + status = "okay"; > + }; Looks good. I'll apply this via the amlogic tree as soon as Herbet applies the driver part. Reviewed-by: Kevin Hilman Kevin

Re: [PATCH -next 06/13] hwrng: meson - use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread Kevin Hilman
YueHaibing writes: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing Reviewed-by: Kevin Hilman

Re: [PATCH v3 1/3] clk: meson-gxbb: expose clock CLKID_RNG0

2017-03-22 Thread Kevin Hilman
Herbert Xu writes: > On Thu, Mar 16, 2017 at 11:24:31AM -0700, Kevin Hilman wrote: >> Hi Herbert, >> >> Herbert Xu writes: >> >> > On Wed, Feb 22, 2017 at 07:55:24AM +0100, Heiner Kallweit wrote: >> >> Expose clock CLKID_RNG0 which is

Re: [PATCH v3 1/3] clk: meson-gxbb: expose clock CLKID_RNG0

2017-03-17 Thread Kevin Hilman
Herbert Xu writes: > On Thu, Mar 16, 2017 at 11:24:31AM -0700, Kevin Hilman wrote: >> Hi Herbert, >> >> Herbert Xu writes: >> >> > On Wed, Feb 22, 2017 at 07:55:24AM +0100, Heiner Kallweit wrote: >> >> Expose clock CLKID_RNG0 which is

Re: [PATCH v3 1/3] clk: meson-gxbb: expose clock CLKID_RNG0

2017-03-16 Thread Kevin Hilman
Hi Herbert, Herbert Xu writes: > On Wed, Feb 22, 2017 at 07:55:24AM +0100, Heiner Kallweit wrote: >> Expose clock CLKID_RNG0 which is needed for the HW random number generator. >> >> Signed-off-by: Heiner Kallweit > > All patches applied. Thanks. Actually, can you just apply [PATCH 4/4] to y

Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS

2016-10-20 Thread Kevin Hilman
uevent MODALIAS to user-space will always be the OF one. > > Signed-off-by: Javier Martinez Canillas Acked-by: Kevin Hilman > --- > > drivers/char/hw_random/meson-rng.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/char/hw_random/meson-rng.c >

Re: [RESEND PATCH 0/2] hw_random: Add Amlogic Meson SoCs Random Generator driver

2016-06-15 Thread Kevin Hilman
Neil Armstrong writes: > NOTE: This is a resent of the DT Bindings and DTSI patches based on the > Amlogic DT 64bit > GIT pull request from Kevin Hilman at [1]. > > Changes since v2 at > http://lkml.kernel.org/r/1465546915-24229-1-git-send-email-narmstr...@baylibre.com

Re: [PATCH v2 0/3] hw_random: Add Amlogic Meson SoCs Random Generator driver

2016-06-13 Thread Kevin Hilman
Hi Herbert, Herbert Xu writes: > On Fri, Jun 10, 2016 at 10:21:52AM +0200, Neil Armstrong wrote: >> Add support for the Amlogic Meson SoCs Hardware Random generator as a >> hw_random char driver. >> The generator is a single 32bit wide register. >> Also adds the Meson GXBB SoC DTSI node and cor

Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node

2016-06-13 Thread Kevin Hilman
Hi Neil, Neil Armstrong writes: > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 832815d..835362

Re: [PATCH v2] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-05-29 Thread Kevin Hilman
Joel A Fernandes writes: > Calling runtime PM API for every block causes serious perf hit to > crypto operations that are done on a long buffer. > As crypto is performed on a page boundary, encrypting large buffers can > cause a series of crypto operations divided by page. The runtime PM API > is

Re: [PATCH v2] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-05-14 Thread Kevin Hilman
> Doing aes-128-cbc for 3s on 1024 size blocks: 11538 aes-128-cbc's in 0.05s > Doing aes-128-cbc for 3s on 8192 size blocks: 4857 aes-128-cbc's in 0.03s > > While at it, also drop enter and exit pr_debugs, in related code. tracers > can be used for that. > > Teste

Re: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-05-13 Thread Kevin Hilman
Hi Joel, "Fernandes, Joel A" writes: > Hi Kevin, > Thanks for your review. > >> -Original Message----- >> From: Kevin Hilman [mailto:khil...@linaro.org] >> Sent: Monday, May 13, 2013 11:36 AM >> To: Fernandes, Joel A >> Cc: linux-crypto@vg

Re: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-05-13 Thread Kevin Hilman
Joel A Fernandes writes: > Calling runtime PM API for every block causes serious perf hit to > crypto operations that are done on a long buffer. > As crypto is performed on a page boundary, encrypting large buffers can > cause a series of crypto operations divided by page. The runtime PM API > is

Re: [PATCH v3 5/7] crypto: omap-sham: Convert to use pm_runtime API

2012-11-13 Thread Kevin Hilman
Hi Mark, "Mark A. Greer" writes: > From: "Mark A. Greer" > > Convert the omap-sham crypto driver to use the > pm_runtime API instead of the clk API. > > CC: Kevin Hilman > CC: Paul Walmsley > CC: Dmitry Kasatkin > Signed-off-by: Mark A. G

Re: [PATCH v2 5/7] crypto: omap-sham: Convert to use pm_runtime API

2012-10-25 Thread Kevin Hilman
Hi Mark, "Mark A. Greer" writes: > From: "Mark A. Greer" > > Convert the omap-sham crypto driver to use the > pm_runtime API instead of the clk API. > > CC: Kevin Hilman > CC: Paul Walmsley > CC: Dmitry Kasatkin > Signed-off-by: Mark A. G