On Sat, 5 Dec 2020, Thomas Gleixner wrote:
> Corentin,
>
> On Sat, Dec 05 2020 at 19:43, Corentin Labbe wrote:
> > On Fri, Dec 04, 2020 at 09:58:21PM +0100, Thomas Gleixner wrote:
> >> Can you please replace the debug patch with the one below and try again?
> >> That stops the trace right on th
kernel test robot
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba
commit: b76f0ea013125358d1b4ca147a6f9b6883dd2493 coccinelle: misc: add
excluded_middle.cocci script
:: branch
On Sat, 17 Oct 2020, Joe Perches wrote:
> On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote:
> > From: Tom Rix
> >
> > This is a upcoming change to clean up a new warning treewide.
> > I am wondering if the change could be one mega patch (see below) or
> > normal patch per file about 10
On Sat, 3 Oct 2020, Konstantin Ryabitsev wrote:
> On Sat, Oct 03, 2020 at 11:40:48AM -0700, Joe Perches wrote:
> > (Adding tools and Konstantin Ryabitsev)
> >
> > There seems to be some mismatch between b4's use of the
> > cover letter to a patch series and what maintainers that
> > apply a sub
On Tue, 29 Sep 2020, Joe Perches wrote:
> On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote:
> > On Tue, 29 Sep 2020, Dan Carpenter wrote:
> > > The times where commas are used deliberately to replace curly braces are
> > > just evil. Either way the code
On Tue, 29 Sep 2020, Dan Carpenter wrote:
> On Tue, Sep 29, 2020 at 02:20:00PM +0200, Ard Biesheuvel wrote:
> > On Sun, 27 Sep 2020 at 21:56, Julia Lawall wrote:
> > >
> > > These patches replace commas by semicolons.
> >
> >
> > Why?
&g
On Tue, 29 Sep 2020, Mark Brown wrote:
> On Tue, Sep 29, 2020 at 01:46:19PM +0200, Julia Lawall wrote:
> > On Tue, 29 Sep 2020, Mark Brown wrote:
>
> > > Feel free to submit patches to b4. Ideally things like this wouldn't be
> > > being sent as seri
On Tue, 29 Sep 2020, Ard Biesheuvel wrote:
> On Sun, 27 Sep 2020 at 21:56, Julia Lawall wrote:
> >
> > These patches replace commas by semicolons.
>
>
> Why?
Among the complete 5000 lines of changes there is one probable bug where
an if branch ends with a comma and t
On Tue, 29 Sep 2020, Mark Brown wrote:
> On Mon, Sep 28, 2020 at 05:45:24PM -0700, Joe Perches wrote:
> > On Mon, 2020-09-28 at 20:35 +0100, Mark Brown wrote:
>
> > > [1/1] regmap: debugfs: use semicolons rather than commas to separate
> > > statements
> > > commit: 7f4a122d0b50b40c64d24
Replace commas with semicolons. What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-by: Julia Lawall
---
drivers/crypto/atmel-tdes.c |2 +-
1 file changed, 1
Replace commas with semicolons. What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-by: Julia Lawall
---
drivers/char/hw_random/iproc-rng200.c |8
1
Replace commas with semicolons. What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-by: Julia Lawall
---
drivers/char/hw_random/mxc-rnga.c |6 +++---
1 file
Replace commas with semicolons. What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-by: Julia Lawall
---
drivers/crypto/amcc/crypto4xx_alg.c |2 +-
drivers
These patches replace commas by semicolons. This was done using the
Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below.
This semantic patch ensures that commas inside for loop headers will not be
transformed. It also doesn't touch macro definitions.
Coccinelle ensures that brace
Replace commas with semicolons. What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-by: Julia Lawall
---
drivers/char/hw_random/stm32-rng.c |8
1 file
Hello,
priv can't be kfreed because it was allocated with a devm function.
julia
-- Forwarded message --
Date: Mon, 3 Aug 2020 21:16:25 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: [crypto:master 164/167] drivers
From: kernel test robot
PTR_ERR should normally access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: 5b8516f3bedb ("crypto: sa2ul: Add crypto driver")
CC: Keerthy
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
t
api/devm_platform_ioremap_resource.cocci
Fixes: 28b8a60c6c83 ("crypto: amlogic: Add crypto accelerator for amlogic GXL")
CC: Corentin Labbe
Signed-off-by: kbuild test robot
Signed-off-by: Julia Lawall
---
url:
https://github.com/0day-ci/linux/commits/Corentin-Labbe/crypto-add-a
crypto4xx")
> Signed-off-by: Wen Yang
> Cc: Herbert Xu
> Cc: "David S. Miller"
> Cc: Thomas Gleixner
> Cc: Greg Kroah-Hartman
> Cc: Allison Randal
> Cc: Armijn Hemel
> Cc: Julia Lawall
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-ker...@vger.ker
Failure of of_device_is_available implies that the device node
should be put, if it is not used otherwise.
---
arch/arm/mach-omap2/display.c|4 +++-
arch/powerpc/platforms/83xx/usb.c|4 +++-
drivers/bus/arm-cci.c
any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
//
Fixes: 5343e674f32fb ("crypto4xx: integrate ppc4xx-rng into crypto4xx")
Signed-off-by: Julia Lawall
---
drivers/crypto/amcc/crypto4xx_trng.c |
On Sat, 31 Mar 2018, Varsha Rao wrote:
> On Sat, Mar 31, 2018 at 11:48 AM, Julia Lawall wrote:
> > On Thu, 29 Mar 2018, Varsha Rao wrote:
> >
> >> On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote:
> >> >
> >> > On Wed, 2018-03-28 at 23:27,
On Thu, 29 Mar 2018, Varsha Rao wrote:
> On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote:
> >
> > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote:
> > > This patch fixes the clang warning of extraneous parentheses, with the
> > > following coccinelle script.
> > >
> > > @@
> > > identifier i;
On Fri, 30 Mar 2018, Joe Perches wrote:
> On Thu, 2018-03-29 at 21:03 +0530, Varsha Rao wrote:
> > On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote:
> > >
> > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote:
> > > > This patch fixes the clang warning of extraneous parentheses, with the
> > >
ctx is dereferenced on line 258 but has been freed on line 229.
julia
-- Forwarded message --
Date: Sun, 18 Mar 2018 18:05:25 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v11 crypto 01/12] tls: support for Inline tls record
CC: kbuild
Please check the indentation on line 1655.
thanks,
julia
-- Forwarded message --
Date: Sun, 18 Mar 2018 18:15:36 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v11 crypto 12/12] crypto: chtls - Makefile Kconfig
CC: kbuild-...@01.org
In
On Sun, 31 Dec 2017, Himanshu Jha wrote:
> On Sun, Dec 31, 2017 at 07:46:09AM -0800, Joe Perches wrote:
> > On Sun, 2017-12-31 at 17:54 +0530, Himanshu Jha wrote:
> > > Use dma_zalloc_coherent for allocating zeroed
> > > memory and remove unnecessary memset function.
> > >
> > > Done using Cocci
On Tue, 14 Nov 2017, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in pr_err error message text
>
> Signed-off-by: Colin Ian King
> ---
> drivers/crypto/nx/nx-842-powernv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/n
On Thu, 14 Sep 2017, Srishti Sharma wrote:
> Use kcalloc instead of kzalloc to check for overflow before
> multiplication. Done using the following semantic patch by
> coccinelle.
>
> http://coccinelle.lip6.fr/rules/kzalloc.cocci
>
> Signed-off-by: Srishti Sharma
A
On Thu, 14 Sep 2017, Srishti Sharma wrote:
> Use kcalloc instead of kzalloc to check for overflow before
> multiplication. Done using the following semantic patch by
> coccinelle.
>
> http://coccinelle.lip6.fr/rules/kzalloc.cocci
>
> Signed-off-by: Srishti Sharma
> ---
> drivers/staging/ccree/
On Mon, 11 Sep 2017, Srishti Sharma wrote:
> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote:
> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
> >> The use of volatile for the variable monitor_lock is unnecessary.
> >>
> >> Signed-off-by: Srishti Sharma
> >> ---
> >> drivers
On Mon, 11 Sep 2017, Srishti Sharma wrote:
> The use of volatile for the variable monitor_lock is unnecessary.
You need to give more evidence of why this is the case. How is the
variable used? I guess this comes from checkpatch, but checkpatch has
only a local view of things, and doesn't know
; Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> Changes in v4:
> -Edit commit message so that it respects 80 character limit
> -Remove unneeded blank lines
> -Remove declarations of variables that are not used
>
> drivers/staging/ccree/ssi_aead.c | 15 +
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> Merge the assignment and return statements to return the value
> directly. Done using coccinelle.
Coccinelle is not always perfect about pretty printing, so you have to
watch out for it.
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall wrote:
> >
> >
> > On Sat, 9 Sep 2017, Srishti Sharma wrote:
> >
> >> Merge the assignment and return statements to return the value
> >> directly. D
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> Merge the assignment and return statements to return the value
> directly. Done using coccinelle.
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
> ---
> Changes in
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> Merge the assignment and return statements to return the value
> directly. Done using coccinelle.
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
> ---
> Changes in
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall wrote:
> >
> >
> > On Sat, 9 Sep 2017, Srishti Sharma wrote:
> >
> >> Return the return value of a function directly, instead of first saving it
> >> in a va
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> Return the return value of a function directly, instead of first saving it in
> a variable and then returning it. This change was made using the following
Your commit message should respect the 80 character limit. The above is
one very long line.
>
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Remove the local variable inflight_counter as it is never used.
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> Changes in v5:
> - Correct the format of the subject.
> drivers/staging/ccree/ssi_cipher.c | 3
One last detail. The subject line above is not in the same format as that
of all of the other subject lines one commits affecting this file. You
can use git log --oneline to see what others have done. It is not really
possible to guess correctly. However, one does not generally include the
exte
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall wrote:
> >
> >
> > On Thu, 7 Sep 2017, Srishti Sharma wrote:
> >
> >> Remove local variable inflight_counter ,as it is never used.
> >
> > "counter
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Remove local variable inflight_counter ,as it is never used.
"counter ,as" -> "counter, as"
> Signed-off-by: Srishti Sharma
> ---
> Changes in v3:
> - There was no longer a need to make the comment more comprehensible as
>I have deleted the var
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Edited comment to make it more comprehensible.
>
> Signed-off-by: Srishti Sharma
> ---
> Changes in v2:
> - Make comment more comprehensible , instead of just correcting typos.
> drivers/staging/ccree/ssi_cipher.c | 4 +++-
> 1 file changed, 3 inser
On Wed, 6 Sep 2017, Srishti Sharma wrote:
>
>
> On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma
> wrote:
> Correct spelling of counter in comment .
>
> Signed-off-by: Srishti Sharma
> ---
> drivers/staging/ccree/ssi_cipher.c | 2 +-
> 1 file
Please check whether a lock is needed before line 303.
julia
-- Forwarded message --
Date: Mon, 19 Jun 2017 17:34:11 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [cryptodev:master 77/100] drivers/crypto/ccp/ccp-debugfs.c:303:3-9:
preceding lock
Please check whether an unlock is needed before line 454.
julia
-- Forwarded message --
Date: Wed, 24 May 2017 12:16:29 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH 2/2] crypto: engine - Permit to enqueue skcipher request
CC: kbuild
build test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v11 4/5] LRNG - enable compile
CC: kbuild-...@01.org
In-Reply-To: <2619717.m11260e...@positron.chronox.de>
TO: "Stephan Müller"
CC: linux-ker...@vger.kernel.org
CC: linux-crypto@vger.kernel.org, "Jason
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
CC: Stephan Müller
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
Not very important, but the code can be a little simpler.
lrng_base.c |5 +
1 file changed, 1
It looks like &udev->cmdr_lock should be released at line 512 if it has
not been released otherwise. The lock was taken at line 438.
julia
-- Forwarded message --
Date: Fri, 14 Apr 2017 22:21:44 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subj
The first argument to list_for_each_entry cannot be NULL.
Generated by: scripts/coccinelle/iterators/itnull.cocci
CC: Harsh Jain
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
This code comes from the following git tree:
url:
https://github.com/0day-ci/linux/commits/Harsh-Jain
The ccp_actions structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/crypto/ccp/ccp-dev-v3.c |2 +-
drivers/crypto/ccp/ccp-dev.h|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Dma_pool_zalloc combines dma_pool_alloc and memset 0. The semantic patch
that makes this transformation is as follows: (http://coccinelle.lip6.fr/)
//
@@
type T;
T *d;
expression e;
statement S;
@@
d =
-dma_pool_alloc
+dma_pool_zalloc
(...);
- memset(d, 0, sizeof(*d));
//
Signed-off-by: Julia Lawall
---
drivers/crypto/marvell/tdma.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/marvell/tdma.c b/drivers/crypto/marvell/tdma.c
index 7642798..0ad8f1e 100644
--- a/drivers/crypto/marvell
Maybe the goto on line 1726 needs a preceding mutex_unlock?
julia
On Mon, 25 Jan 2016, kbuild test robot wrote:
> Hi Herbert,
>
> [auto build test WARNING on net/master]
> [also build test WARNING on v4.4 next-20160122]
> [if your patch is applied to the wrong git tree, please drop us a note to
On Fri, 25 Dec 2015, Herbert Xu wrote:
> On Fri, Dec 25, 2015 at 07:54:48AM +0100, Julia Lawall wrote:
> > Lines 766, 767 don't look correct at all.
>
> Thanks Julia. I have sent an updated patch in the original thread.
> I wonder why I haven't received the origin
Lines 766, 767 don't look correct at all.
julia
On Thu, 24 Dec 2015, kbuild test robot wrote:
> In-Reply-To: <20151224093902.ga8...@gondor.apana.org.au>
>
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving the system]
> Hi Herbert,
>
> [auto build tes
The drbg_state_ops structures are never modified, so declare them as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
crypto/drbg.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/crypto/drbg.c b/crypto/drbg.c
index a7c2314..ab6ef1d 100644
This pci_error_handlers structure is never modified, like all the other
pci_error_handlers structures, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
There are no dependencies between these patches.
drivers/crypto/qat/qat_common/adf_aer.c |2
Constify never-modified pci_error_handlers structures.
---
drivers/crypto/qat/qat_common/adf_aer.c |2 +-
drivers/misc/genwqe/card_base.c |2 +-
drivers/net/ethernet/cavium/liquidio/lio_main.c |2 +-
drivers/net/ethernet/sfc/efx.c |2 +-
d
These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on
static functions.
This was done using the following semantic patch:
(http://coccinelle.lip6.fr/)
//
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f
From: Julia Lawall
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
//
Signed-off-by: Julia Lawall
---
arch/x86
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. The complete semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier x;
local idexpression e;
type
From: Julia Lawall
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr
From: Julia Lawall
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr
From: Julia Lawall
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr
From: Julia Lawall
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr
From: Julia Lawall
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. The complete semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier x;
local idexpression e;
type
From: Julia Lawall
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr
From: Julia Lawall
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr
From: Julia Lawall
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr
On Wed, 19 Nov 2014, Konstantin Khlebnikov wrote:
> On Wed, Nov 19, 2014 at 12:41 PM, Julia Lawall wrote:
> >> +// Comments: There are false positives in crypto/ where they are
> >> actually freed.
> >
> > I didn't really understand this comment. I ran th
> +// Comments: There are false positives in crypto/ where they are
> actually freed.
I didn't really understand this comment. I ran the semantic patch and got
around 10 results, but it wasn't clear to me how to see which were false
positives.
I would suggest to extend the rule a little bit to i
On Mon, 17 Nov 2014, Konstantin Khlebnikov wrote:
> Structures allocated by crypto_alloc_* must be freed using crypto_free_*.
>
> Signed-off-by: Konstantin Khlebnikov
> ---
> scripts/coccinelle/free/crypto_free.cocci | 45
> +
> 1 file changed, 45 insertions(+)
>
gt; >
> > With the help of Coccinelle, we can figure out and fix such occurences
> > in the crypto subsytem as well. Julia Lawall provided the following
> > Coccinelle program:
> >
> > @@
> > type T;
> > identifier x;
> > @@
> >
>
From: Julia Lawall
Adjust alignment and replace commas by semicolons in automatically
generated code.
Signed-off-by: Julia Lawall
---
arch/x86/crypto/camellia_glue.c | 48
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/arch/x86
From: Julia Lawall
Adjust alignment and replace commas by semicolons in automatically
generated code.
Signed-off-by: Julia Lawall
---
crypto/camellia_generic.c | 48 +++---
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/crypto
On Wed, 14 Aug 2013, Herbert Xu wrote:
> On Sat, Aug 10, 2013 at 07:34:36PM +0200, Julia Lawall wrote:
> > From: Julia Lawall
> >
> > Adjust alignment in automatically generated code. If this code
> > will not be regenerated in the future, it may as well look
From: Julia Lawall
Adjust alignment in automatically generated code. If this code
will not be regenerated in the future, it may as well look nice.
Signed-off-by: Julia Lawall
---
This patch was generated from the result of the previous one, which
replaced commas by semicolons.
arch/x86
From: Julia Lawall
Adjust alignment in automatically generated code. If this code
will not be regenerated in the future, it may as well look nice.
Signed-off-by: Julia Lawall
---
This patch was generated from the result of the previous one, which
replaced commas by semicolons.
crypto
On Sat, 10 Aug 2013, Joe Perches wrote:
> On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote:
> > Replace a comma between expression statements by a semicolon.
> []
> > This patch is separate from the others because the code appears to be
> > machine-generated.
&g
From: Julia Lawall
Replace a comma between expression statements by a semicolon.
A simplified version of the semantic patch that performs this
transformation is as follows: (http://coccinelle.lip6.fr/)
//
@r@
expression e1,e2,e;
type T;
identifier i;
@@
e1
-,
+;
e2;
//
This patch is
From: Julia Lawall
Replace a comma between expression statements by a semicolon.
A simplified version of the semantic patch that performs this
transformation is as follows: (http://coccinelle.lip6.fr/)
//
@r@
expression e1,e2,e;
type T;
identifier i;
@@
e1
-,
+;
e2;
//
This patch is
From: Julia Lawall
Replace PTR_ERR followed by ERR_PTR by ERR_CAST, to be more concise.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression err,x;
@@
- err = PTR_ERR(x);
if (IS_ERR(x))
-return ERR_PTR(err
ERR_CAST is more concise than PTR_ERR followed by ERR_PTR. Using it
also occasionally removes the need for an err variable.
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.o
From: Julia Lawall
Delete successive tests to the same location. The code tested the result
of a previous allocation, that itself was already tested. It is changed to
test the result of the most recent allocation.
A simplified version of the semantic match that finds this problem is as
From: Julia Lawall
The data referenced by an interrupt handler should not be freed before the
interrupt is ended. The handler is bfin_crypto_crc_handler. It may refer
to crc->regs, which is released by the iounmap.
Furthermore, the second argument to all calls to free_irq is incorrect.
From: Julia Lawall
Move the err_request_irq error label up to reflect that tasklet_init and
irq_of_parse_and_map have taken place.
Signed-off-by: Julia Lawall
---
drivers/crypto/amcc/crypto4xx_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/amcc
From: Julia Lawall
The function is called with locks held and thus should not use GFP_KERNEL.
The semantic patch that makes this report is available
in scripts/coccinelle/locks/call_kern.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
//
Signed-off-by: Julia Lawall
---
drivers/crypto/caam/caamalg.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c
i
From: Julia Lawall
Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more
clear what is the purpose of the operation, which otherwise looks like a
no-op.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
type T;
T x;
identifier f
From: Julia Lawall
Memset should be given the size of the structure, not the size of the pointer.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
type T;
T *x;
expression E;
@@
memset(x, E, sizeof(
+ *
x))
//
Signed-off-by: Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]>
ARRAY_SIZE is more concise to use when the size of an array is divided by
the size of its type or the size of its first element.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
//
@i@
@@
#include
@d
From: Julia Lawall <[EMAIL PROTECTED]>
Normally, kzalloc returns NULL or a valid pointer value, not a value to be
tested using IS_ERR.
Signed-off-by: Julia Lawall <[EMAIL PROTECTED]>
---
diff -u -p a/crypto/cryptd.c b/crypto/cryptd.c
--- a/crypto/cryptd.c 2008-04-16 13:27:56.000
From: Julia Lawall <[EMAIL PROTECTED]>
Normally, kzalloc returns NULL or a valid pointer value, not a value to be
tested using IS_ERR.
Signed-off-by: Julia Lawall <[EMAIL PROTECTED]>
---
diff -u -p a/crypto/cryptd.c b/crypto/cryptd.c
--- a/crypto/cryptd.c 2008-04-16 13:27:56.000
96 matches
Mail list logo
