Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-10-02 Thread John Garry
On 21/09/2019 11:26, Zhou Wang wrote: On 2019/9/20 22:16, John Garry wrote: On 20/09/2019 14:36, Arnd Bergmann wrote: On Fri, Sep 20, 2019 at 3:26 PM Arnd Bergmann wrote: On Fri, Sep 20, 2019 at 10:34 AM John Garry wrote: + if (!IS_ENABLED(CONFIG_ARM64)) { + memcpy_toio

Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-09-20 Thread John Garry
On 20/09/2019 14:36, Arnd Bergmann wrote: On Fri, Sep 20, 2019 at 3:26 PM Arnd Bergmann wrote: On Fri, Sep 20, 2019 at 10:34 AM John Garry wrote: + if (!IS_ENABLED(CONFIG_ARM64)) { + memcpy_toio(fun_base, src, 16); + wmb(); + return

Re: [PATCH 2/2] [v2] crypto: hisilicon - allow compile-testing on x86

2019-09-20 Thread John Garry
On 19/09/2019 15:09, Arnd Bergmann wrote: To avoid missing arm64 specific warnings that get introduced in this driver, allow compile-testing on all 64-bit architectures. The only actual arm64 specific code in this driver is an open- coded 128 bit MMIO write. On non-arm64 the same can be done usi

[PATCH 1/2] crypto: hisilicon - Fix NULL dereference for same dst and src

2018-11-05 Thread John Garry
- SEC security accelerator driver") Reviewed-by: Jonathan Cameron Signed-off-by: John Garry --- drivers/crypto/hisilicon/sec/sec_algs.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/hisilicon/sec/sec_algs.c b/drivers/crypto/hisilicon/sec/

[PATCH 2/2] crypto: hisilicon - Fix reference after free of memories on error path

2018-11-05 Thread John Garry
r") Reviewed-by: Jonathan Cameron Signed-off-by: John Garry --- drivers/crypto/hisilicon/sec/sec_algs.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/hisilicon/sec/sec_algs.c b/drivers/crypto/hisilicon/sec/sec_algs.c index 32c6c02..

[PATCH 0/2] crypto: hisilicon - A couple of fixes

2018-11-05 Thread John Garry
This patchset fixes a couple of issues I discovered while attempting to bringup the driver. John Garry (2): crypto: hisilicon - Fix NULL dereference for same dst and src crypto: hisilicon - Fix reference after free of memories on error path drivers/crypto/hisilicon/sec/sec_algs.c | 31

Re: [PATCH v2 17/21] scsi: hisi_sas: Remove depends on HAS_DMA in case of platform dependency

2018-03-16 Thread John Garry
bin Murphy Acked-by: John Garry