gt;> Tested-by: Joachim Eastwood
>
> Thanks Joachim. Looks like in my hurry, I missed proper
> acknowledgement of your report. adding the following for patchworks to
> pickup.
>
> Reported-by: Joachim Eastwood
>
Acked-by: Joel Fernandes
Regards,
-Joel
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/07/2014 11:54 PM, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han
Acked-by: Joel Fernandes
--
To unsubscribe from this list: send the line "unsubscribe linux-cr
dev_err(dev, "can't ioremap\n");
> - err = -ENOMEM;
> + dd->io_base = devm_ioremap_resource(dev, res);
> + if (IS_ERR(dd->io_base)) {
> + err = PTR_ERR(dd->io_base);
> goto err_res;
> }
> dd-
HIGHMEM pages may not be mapped so we must kmap them before accessing.
This resolves a random OOPs error that was showing up during OpenSSL SHA tests.
Signed-off-by: Joel Fernandes
---
v2: Don't check for HIGHMEM, already done by kmap/unmap
v3: Use atomic as call can happen in irq co
On 03/05/2014 01:11 AM, Herbert Xu wrote:
> On Wed, Mar 05, 2014 at 04:18:12AM +, Fernandes, Joel wrote:
>>
>>
>>> On Mar 4, 2014, at 8:00 PM, "Herbert Xu"
>>> wrote:
>>>
>>>> On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Ferna
HIGHMEM pages may not be mapped so we must kmap them before accessing.
This resolves a random OOPs error that was showing up during OpenSSL SHA tests.
Signed-off-by: Joel Fernandes
Cc: Herbert Xu
---
v2 changes:
- don't check for HIGHMEM, kmap/kunmap do them anyway (Thanks He
On 02/27/2014 05:34 AM, Jingoo Han wrote:
> Make omap_des_copy_needed(), omap_des_copy_sgs(), because these
> functions are used only in this file.
>
> Signed-off-by: Jingoo Han
Ok with me,
Acked-by: Joel Fernandes
> ---
> drivers/crypto/omap-des.c |4 ++--
> 1 file
Gentle ping for this fix patch. Could it be accepted for -rc? Thanks.
-Joel
On 01/28/2014 05:43 PM, Joel Fernandes wrote:
> HIGHMEM pages may not be mapped so we must kmap them before accessing.
> This resolves a random OOPs error that was showing up during OpenSSL SHA
> tests.
>
Here are revised patches for omap-des driver addressing review comments at:
https://lkml.org/lkml/2013/8/30/116
Joel Fernandes (2):
crypto: omap-des: Add omap-des driver for OMAP4/AM43xx
crypto: omap-des: Add config and build options
drivers/crypto/Kconfig| 11 +
drivers/crypto
Add config and build options for the omap-des driver.
Signed-off-by: Joel Fernandes
---
drivers/crypto/Kconfig | 11 +++
drivers/crypto/Makefile |1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 13857f5..8e38000 100644
functionality is
verified at different page length alignments.
Signed-off-by: Joel Fernandes
---
v2 changes:
Address review comments from Rajendra at: https://lkml.org/lkml/2013/8/30/116
drivers/crypto/omap-des.c | 1218 +
1 file changed, 1218
HIGHMEM pages may not be mapped so we must kmap them before accessing.
This resolves a random OOPs error that was showing up during OpenSSL SHA tests.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-sham.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a
On 10/30/2013 06:09 AM, Jussi Kivilinna wrote:
> On 30.10.2013 02:11, Joel Fernandes wrote:
>> Hi,
>>
>> Some tests such as test 5 in AES CTR mode in crypto/testmgr.h have a
>> unaligned
>> input buffer size such as 499 which is not aligned to any > 0 pow
Hi,
Some tests such as test 5 in AES CTR mode in crypto/testmgr.h have a unaligned
input buffer size such as 499 which is not aligned to any > 0 power of 2.
Due to this, omap-aes driver, and I think atmel-aes too error out when
encryption is requested for these buffers.
pr_err("request size is n
NIST vectors for CTR mode in testmgr.h assume the entire IV as the counter. To
get correct results that match the output of these vectors, we need to set the
counter length correctly.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
map_des_dev *dd,
>> +struct device *dev, struct resource *res)
>> +{
>> +return -EINVAL;
>> +}
>> +#endif
>> +
>> +static int omap_des_get_res_pdev(struct omap_des_dev *dd,
>> +struct platform_device *pdev, struct resource *re
On 08/29/2013 06:27 PM, Joel Fernandes wrote:
> Add omap-des driver with platform data for OMAP4. Support added for DES
> ECB and CBC modes.
>
> Where possible, code is reused from omap-aes driver with changes made for
> adjusting key size, block size, removing non-existent encrypt
.
Tests have been conducted with the CRYPTO test manager, and functionality
is verified at different page length alignments.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-des.c | 1192 +
1 file changed, 1192 insertions(+)
create mode 100644 drivers
OMAP DES module supports 3DES operation where 3 64-bit keys are used to
perform a DES encrypt-decrypt-encrypt (ede) operation on a buffer.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-des.c | 53 ---
1 file changed, 50 insertions(+), 3
OMAP4 and AM437x SoCs have a DES3DES module which is capable of performing DES
encrypt/decrypt and 3DES ede encrypt/decrypt operations. Following patch series
adds support for the same.
Tests have been performed with crypto/testmgr and all tests are successful.
Joel Fernandes (3):
crypto: omap
Add config and build options for the newly added omap-des driver.
Signed-off-by: Joel Fernandes
---
drivers/crypto/Kconfig | 11 +++
drivers/crypto/Makefile | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index e289afa..119a8e5
On 08/20/2013 07:57 AM, Lokesh Vutla wrote:
> Hi Joel,
>
> On Sunday 18 August 2013 08:12 AM, Joel Fernandes wrote:
>> In early version of this driver, assumptions were made such as DMA layer
>> requires contiguous buffers etc. Due to this, new buffers were allocated,
>&
On 08/17/2013 11:22 PM, Joe Perches wrote:
> On Sat, 2013-08-17 at 21:42 -0500, Joel Fernandes wrote:
>> When DEBUG is enabled, these macros can be used to print variables in integer
>> and hex format, and clearly display which registers, offsets and values are
>> being rea
copy data into the buffer, and copy data out of it on completion.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 86 +++--
1 file changed, 83 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
used later.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 26b802b..e369e6e 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -164,6 +164,8
For AM437x SoC, ARCH_OMAP2 and ARCH_OMAP3 is not enabled in the defconfig. We
follow same thing as SHA driver, and add depends on ARCH_OMAP2PLUS so that the
config is selectable for AES driver on AM437x SoC builds.
Signed-off-by: Joel Fernandes
---
drivers/crypto/Kconfig |2 +-
1 file
mprovement of atleast ~20% seen with encrypting a
buffer size of 8K (1800 ops/sec vs 1400 ops/sec). Improvement will be higher
for much larger blocks though such benchmarking is left as an exercise for the
reader. Also DMA usage is much more simplified and coherent with rest of the
code.
Signed-of
We initialize the scatter gather walk lists needed for PIO mode and avoid all
DMA paths such as mapping/unmapping buffers by checking for the pio_only flag.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 43 ++-
1 file changed, 30
Earlier functions that did a similar sync are replaced by the dma_sync_sg_*
which can operate on entire SG list.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index
e driver as of now that
requires a do-while loop, but there is code that will break if a do-while loop
is used in the macro so we ignore the checkpatch error in this case.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 22 +-
1 file changed, 21 insertions(+), 1
mode.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 28 +++-
1 file changed, 23 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 62b3260..d214dbf 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers
omap_aes_device.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 90 -
1 file changed, 90 deletions(-)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 5e034a1..bbdd1c3 100644
--- a/drivers/crypto/omap-aes.c
+++ b
Use devm_kzalloc instead of kzalloc. With this change, there is no need to
call kfree in error/exit paths.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
The debug patch: "crypto: omap-aes: Add useful debug macros" will generate
a checkpatch error, which cannot be fixed. Refer to patch for error message
and reasons for why cannot be fixed, thanks.
Joel Fernandes (14):
crypto: scatterwalk: Add support for calculating number of SG
el
errors.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 90 +
1 file changed, 90 insertions(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 9a964e8..889dc99 100644
--- a/drivers/crypto/omap-aes.c
+++ b
Keeps request_irq exit/error code paths simpler.
Suggested-by: Lokesh Vutla
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 6a4ac4a..ab449b5
Crypto layer only passes nbytes to encrypt but in omap-aes driver we need to
know number of SG elements to pass to dmaengine slave API. We add function for
the same to scatterwalk library.
Signed-off-by: Joel Fernandes
---
crypto/scatterwalk.c | 22 ++
include
Add IRQ information to pdata and helper macros. These are required
for PIO-mode support.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index bbdd1c3..9a964e8 100644
On 08/15/2013 01:23 AM, Dmitry Kasatkin wrote:
> On 15/08/13 06:12, Joel Fernandes wrote:
>> On 08/14/2013 07:47 PM, Joe Perches wrote:
>>> On Wed, 2013-08-14 at 18:40 -0500, Joel Fernandes wrote:
>>>> On 08/14/2013 06:29 PM, Joe Perches wrote:
>>>>
On 08/15/2013 12:58 AM, Dmitry Kasatkin wrote:
> On 15/08/13 02:30, Joel Fernandes wrote:
>> On 08/14/2013 06:12 PM, Joel Fernandes wrote:
>>> This patch series is a rewrite of the DMA portion of omap-aes driver
>>> and also adds support for PIO mode. Both these modes,
On 08/14/2013 07:47 PM, Joe Perches wrote:
> On Wed, 2013-08-14 at 18:40 -0500, Joel Fernandes wrote:
>> On 08/14/2013 06:29 PM, Joe Perches wrote:
>>> On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote:
>>>> When DEBUG is enabled, these macros can be used to p
On 08/14/2013 06:29 PM, Joe Perches wrote:
> On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote:
>> When DEBUG is enabled, these macros can be used to print variables
>> in integer and hex format, and clearly display which registers,
>> offsets and values are being rea
On 08/14/2013 06:12 PM, Joel Fernandes wrote:
> This patch series is a rewrite of the DMA portion of omap-aes driver
> and also adds support for PIO mode. Both these modes, give better
> performance than before.
>
> Earlier, only a single SG was used for DMA purpose, and the SG-lis
When DEBUG is enabled, these macros can be used to print variables
in integer and hex format, and clearly display which registers,
offsets and values are being read/written , including printing the
names of the offsets and their values.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap
Add IRQ information to pdata and helper macros. These are
required for PIO-mode support.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 71da52b..c057eac 100644
errors.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 90 +
1 file changed, 90 insertions(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index c057eac..891455b 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers
mode.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 28 +++-
1 file changed, 23 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 54f2729..34e3b77 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers
We initialize the scatter gather walk lists needed for PIO mode
and avoid all DMA paths such as mapping/unmapping buffers by
checking for the pio_only flag.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 43 ++-
1 file changed, 30
y improves performance (atleast 35% seen with
encrypting a buffer size of 8K (2800 ops/sec vs 1800 ops/sec).
Also DMA usage is much more simplified and coherent with rest
of the code.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 147 -
1 file c
Earlier functions that did a similar sync are replaced by
the dma_sync_sg_* which can operate on entire SG list.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index
Crypto layer only passes nbytes to encrypt but in omap-aes driver we
need to know number of SG elements to pass to dmaengine slave API.
We add function for the same to scatterwalk library.
Signed-off-by: Joel Fernandes
---
crypto/scatterwalk.c | 22 ++
include
conds (647168 bytes)
Future work in this direction would be to dynamically change between
PIO/DMA mode based on the block size.
Joel Fernandes (10):
crypto: scatterwalk: Add support for calculating number of SG
elements
crypto: omap-aes: Add useful debug macros
crypto: omap-aes: Populate numb
omap_aes_device.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c | 90 -
1 file changed, 90 deletions(-)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index df2f867..71da52b 100644
--- a/drivers/crypto/omap-aes.c
+++ b
used later.
Signed-off-by: Joel Fernandes
---
drivers/crypto/omap-aes.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 3838e0a..b7189a8 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -171,6 +171,8
Hi,
I am working on a driver for OMAP 3DES hardware similar to OMAP AES
(drivers/crypto/omap-aes). The hardware is similar in many ways and a lot of it
can be reused from first look.
Can anyone comment if its ok to add to omap-aes, calling it
drivers/crypto/omap-aesdes. That will ensure maximum r
55 matches
Mail list logo
