Re: [PATCH] crypto: s5p-sss: fix multiplatform build

2014-05-11 Thread Jingoo Han
gt; Cc: Tomasz Figa > Cc: > Cc: Vladimir Zapolskiy > Cc: Herbert Xu I checked that these machine specific headers are unnecessary. Thanks! Reviewed-by: Jingoo Han Best regards, Jingoo Han > --- > Please apply on top of the other s5p-sss patches > > diff --git a/drivers/crypt

[PATCH V2] crypto: omap-des - use devm_ioremap_resource()

2014-04-07 Thread Jingoo Han
Use devm_ioremap_resource() because devm_request_and_ioremap() is obsoleted by devm_ioremap_resource(). Signed-off-by: Jingoo Han --- Changes since v1: - remove unnecessary error message, because devm_ioremap_resource() already prints one in all failure cases. drivers/crypto/omap-des.c

[PATCH] crypto: omap-des - use devm_ioremap_resource()

2014-04-02 Thread Jingoo Han
Use devm_ioremap_resource() because devm_request_and_ioremap() is obsoleted by devm_ioremap_resource(). Signed-off-by: Jingoo Han --- drivers/crypto/omap-des.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c

[PATCH] crypto: omap-des - make local functions static

2014-02-27 Thread Jingoo Han
Make omap_des_copy_needed(), omap_des_copy_sgs(), because these functions are used only in this file. Signed-off-by: Jingoo Han --- drivers/crypto/omap-des.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c index

[PATCH 3/3] crypto: omap-sham - Use SIMPLE_DEV_PM_OPS macro

2014-02-27 Thread Jingoo Han
Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler. Signed-off-by: Jingoo Han --- drivers/crypto/omap-sham.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index a727a6a..4e2067d 100644 --- a/drivers

[PATCH 2/3] crypto: omap-des - Use SIMPLE_DEV_PM_OPS macro

2014-02-27 Thread Jingoo Han
Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler. Signed-off-by: Jingoo Han --- drivers/crypto/omap-des.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c index 006d914..758919e 100644 --- a/drivers

[PATCH 1/3] crypto: omap-aes - Use SIMPLE_DEV_PM_OPS macro

2014-02-27 Thread Jingoo Han
Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler. Signed-off-by: Jingoo Han --- drivers/crypto/omap-aes.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index dde41f1d..cb98fa5 100644 --- a/drivers

[PATCH 1/4] crypto: picoxcell - Use devm_ioremap_resource()

2014-02-11 Thread Jingoo Han
Use devm_ioremap_resource() in order to make the code simpler, and remove redundant return value check of platform_get_resource() because the value is checked by devm_ioremap_resource(). Signed-off-by: Jingoo Han --- drivers/crypto/picoxcell_crypto.c | 16 +--- 1 file changed, 5

[PATCH 4/4] crypto: tegra-aes - Use devm_ioremap_resource()

2014-02-11 Thread Jingoo Han
Use devm_ioremap_resource() in order to make the code simpler, and remove redundant return value check of platform_get_resource() because the value is checked by devm_ioremap_resource(). Signed-off-by: Jingoo Han --- drivers/crypto/tegra-aes.c | 20 +++- 1 file changed, 3

[PATCH 3/4] crypto: s5p-sss - Use devm_ioremap_resource()

2014-02-11 Thread Jingoo Han
Use devm_ioremap_resource() in order to make the code simpler, and remove redundant return value check of platform_get_resource() because the value is checked by devm_ioremap_resource(). Signed-off-by: Jingoo Han --- drivers/crypto/s5p-sss.c | 13 - 1 file changed, 4 insertions

[PATCH 2/4] crypto: sahara - Use devm_ioremap_resource()

2014-02-11 Thread Jingoo Han
Use devm_ioremap_resource() in order to make the code simpler, and remove redundant return value check of platform_get_resource() because the value is checked by devm_ioremap_resource(). Signed-off-by: Jingoo Han --- drivers/crypto/sahara.c | 19 +++ 1 file changed, 3

[PATCH 1/4] crypto: picoxcell - Use devm_ioremap_resource()

2014-02-11 Thread Jingoo Han
>From c0c9c31eba90635cac93f3d5e5311beb10afafb7 Mon Sep 17 00:00:00 2001 From: Jingoo Han Date: Wed, 12 Feb 2014 13:08:54 +0900 Subject: [PATCH 1/4] crypto: picoxcell - Use devm_ioremap_resource() Use devm_ioremap_resource() in order to make the code simpler, and remove redundant return va

[PATCH 2/2] crypto: crypto4xx - Staticize local symbols

2013-08-09 Thread Jingoo Han
_command_1' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/crypto/amcc/crypto4xx_alg.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/amcc/crypto4xx_alg.c b/drivers/crypto/amcc/crypto4xx_alg.c index a33

[PATCH 1/2] crypto: sahara - Staticize local symbol

2013-08-09 Thread Jingoo Han
This local symbol is used only in this file. Fix the following sparse warnings: drivers/crypto/sahara.c:420:6: warning: symbol 'sahara_watchdog' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/crypto/sahara.c |2 +- 1 file changed, 1 insertion(+),

[PATCH] crypto: picoxcell - replace strict_strtoul() with kstrtoul()

2013-06-01 Thread Jingoo Han
The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used. Signed-off-by: Jingoo Han --- drivers/crypto/picoxcell_crypto.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/picoxcell_crypto.c b

[PATCH 2/2] crypto: s5p-sss: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/crypto/s5p-sss.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 4b31432..cf149b1 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -647,7 +647,6 @@ static int s5p_aes_probe

[PATCH 1/2] crypto: mv_cesa: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/crypto/mv_cesa.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c index ce6290e..3374a3e 100644 --- a/drivers/crypto/mv_cesa.c +++ b/drivers/crypto/mv_cesa.c @@ -1146,7 +1146,6 @@ err_unmap_reg: err

[PATCH v2] crypto: s5p-sss - Use devm_clk_get()

2013-01-09 Thread Jingoo Han
Use devm_clk_get() rather than clk_get() to make cleanup paths more simple. Signed-off-by: Jingoo Han --- Changes since v1: - modified the commit message drivers/crypto/s5p-sss.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers

[PATCH] crypto: s5p-sss - Use devm_clk_get()

2013-01-08 Thread Jingoo Han
The devm_ functions allocate memory that is released when a driver detaches. This patch uses devm_clk_get() for these functions. These make the code smaller and a bit simpler Signed-off-by: Jingoo Han --- drivers/crypto/s5p-sss.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions