Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-23 Thread Jerome Glisse
On Wed, Oct 23, 2019 at 09:42:27AM +0200, Jean-Philippe Brucker wrote: > On Fri, Oct 18, 2019 at 08:01:44PM +0800, zhangfei@foxmail.com wrote: [...] > > > > +static int uacce_fops_mmap(struct file *filep, struct vm_area_struct > > > > *vma) > > > > +{ > > > > + struct uacce_queue *q =

Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-23 Thread Jerome Glisse
On Wed, Oct 16, 2019 at 07:28:02PM +0200, Jean-Philippe Brucker wrote: [...] > > +static struct uacce_qfile_region * > > +uacce_create_region(struct uacce_queue *q, struct vm_area_struct *vma, > > + enum uacce_qfrt type, unsigned int flags) > > +{ > > + struct uacce_qfile_region *q

Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-22 Thread Jerome Glisse
On Wed, Oct 16, 2019 at 04:34:32PM +0800, Zhangfei Gao wrote: > From: Kenneth Lee > > Uacce (Unified/User-space-access-intended Accelerator Framework) targets to > provide Shared Virtual Addressing (SVA) between accelerators and processes. > So accelerator can access any data structure of the mai

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-19 Thread Jerome Glisse
On Mon, Nov 19, 2018 at 02:26:38PM -0700, Jason Gunthorpe wrote: > On Mon, Nov 19, 2018 at 03:26:15PM -0500, Jerome Glisse wrote: > > On Mon, Nov 19, 2018 at 01:11:56PM -0700, Jason Gunthorpe wrote: > > > On Mon, Nov 19, 2018 at 02:46:32PM -0500, Jerome Glisse wrote: > >

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-19 Thread Jerome Glisse
On Mon, Nov 19, 2018 at 01:11:56PM -0700, Jason Gunthorpe wrote: > On Mon, Nov 19, 2018 at 02:46:32PM -0500, Jerome Glisse wrote: > > > > ?? How can O_DIRECT be fine but RDMA not? They use exactly the same > > > get_user_pages flow, right? Can we do what O_DIRECT does i

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-19 Thread Jerome Glisse
On Mon, Nov 19, 2018 at 12:27:02PM -0700, Jason Gunthorpe wrote: > On Mon, Nov 19, 2018 at 02:17:21PM -0500, Jerome Glisse wrote: > > On Mon, Nov 19, 2018 at 11:53:33AM -0700, Jason Gunthorpe wrote: > > > On Mon, Nov 19, 2018 at 01:42:16PM -0500, Jerome Glisse wrote: > >

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-19 Thread Jerome Glisse
On Mon, Nov 19, 2018 at 07:19:04PM +, Christopher Lameter wrote: > On Mon, 19 Nov 2018, Jerome Glisse wrote: > > > > IIRC this is solved in IB by automatically calling > > > madvise(MADV_DONTFORK) before creating the MR. > > > > > > MADV_DONTFORK &g

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-19 Thread Jerome Glisse
On Mon, Nov 19, 2018 at 11:53:33AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 19, 2018 at 01:42:16PM -0500, Jerome Glisse wrote: > > On Mon, Nov 19, 2018 at 11:27:52AM -0700, Jason Gunthorpe wrote: > > > On Mon, Nov 19, 2018 at 11:48:54AM -0500, Jerome Glisse wrote: > > &g

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-19 Thread Jerome Glisse
On Mon, Nov 19, 2018 at 11:27:52AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 19, 2018 at 11:48:54AM -0500, Jerome Glisse wrote: > > > Just to comment on this, any infiniband driver which use umem and do > > not have ODP (here ODP for me means listening to mmu notifier so

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-19 Thread Jerome Glisse
On Mon, Nov 19, 2018 at 12:48:01PM +0200, Leon Romanovsky wrote: > On Mon, Nov 19, 2018 at 05:19:10PM +0800, Kenneth Lee wrote: > > On Mon, Nov 19, 2018 at 05:14:05PM +0800, Kenneth Lee wrote: > > > On Thu, Nov 15, 2018 at 04:54:55PM +0200, Leon Romanovsky wrote: > > > > On Thu, Nov 15, 2018 at 04:

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-21 Thread Jerome Glisse
On Fri, Sep 21, 2018 at 06:03:14PM +0800, Kenneth Lee wrote: > On Sun, Sep 16, 2018 at 09:42:44PM -0400, Jerome Glisse wrote: > > > > So i want to summarize issues i have as this threads have dig deep into > > details. For this i would like to differentiate two cases first

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-20 Thread Jerome Glisse
On Thu, Sep 20, 2018 at 01:55:43PM +0800, Kenneth Lee wrote: > On Tue, Sep 18, 2018 at 09:03:14AM -0400, Jerome Glisse wrote: > > On Tue, Sep 18, 2018 at 02:00:14PM +0800, Kenneth Lee wrote: > > > On Mon, Sep 17, 2018 at 08:37:45AM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-18 Thread Jerome Glisse
On Tue, Sep 18, 2018 at 02:00:14PM +0800, Kenneth Lee wrote: > On Mon, Sep 17, 2018 at 08:37:45AM -0400, Jerome Glisse wrote: > > On Mon, Sep 17, 2018 at 04:39:40PM +0800, Kenneth Lee wrote: > > > On Sun, Sep 16, 2018 at 09:42:44PM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-17 Thread Jerome Glisse
On Mon, Sep 17, 2018 at 04:39:40PM +0800, Kenneth Lee wrote: > On Sun, Sep 16, 2018 at 09:42:44PM -0400, Jerome Glisse wrote: > > So i want to summarize issues i have as this threads have dig deep into > > details. For this i would like to differentiate two cases first the ea

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-16 Thread Jerome Glisse
So i want to summarize issues i have as this threads have dig deep into details. For this i would like to differentiate two cases first the easy one when relying on SVA/SVM. Then the second one when there is no SVA/SVM. In both cases your objectives as i understand them: [R1]- expose a common user

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-14 Thread Jerome Glisse
On Fri, Sep 14, 2018 at 06:50:55AM +, Tian, Kevin wrote: > > From: Jerome Glisse > > Sent: Thursday, September 13, 2018 10:52 PM > > > [...] > > AFAIK, on x86 and PPC at least, all PCIE devices are in the same group > > by default at boot or at least a

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-14 Thread Jerome Glisse
On Fri, Sep 14, 2018 at 11:12:01AM +0800, Kenneth Lee wrote: > On Thu, Sep 13, 2018 at 10:51:50AM -0400, Jerome Glisse wrote: > > On Thu, Sep 13, 2018 at 04:32:32PM +0800, Kenneth Lee wrote: > > > On Tue, Sep 11, 2018 at 09:40:14AM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-13 Thread Jerome Glisse
On Thu, Sep 13, 2018 at 04:32:32PM +0800, Kenneth Lee wrote: > On Tue, Sep 11, 2018 at 09:40:14AM -0400, Jerome Glisse wrote: > > On Tue, Sep 11, 2018 at 02:40:43PM +0800, Kenneth Lee wrote: > > > On Mon, Sep 10, 2018 at 11:33:59PM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-11 Thread Jerome Glisse
On Tue, Sep 11, 2018 at 02:40:43PM +0800, Kenneth Lee wrote: > On Mon, Sep 10, 2018 at 11:33:59PM -0400, Jerome Glisse wrote: > > On Tue, Sep 11, 2018 at 10:42:09AM +0800, Kenneth Lee wrote: > > > On Mon, Sep 10, 2018 at 10:54:23AM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-10 Thread Jerome Glisse
On Tue, Sep 11, 2018 at 10:42:09AM +0800, Kenneth Lee wrote: > On Mon, Sep 10, 2018 at 10:54:23AM -0400, Jerome Glisse wrote: > > On Mon, Sep 10, 2018 at 11:28:09AM +0800, Kenneth Lee wrote: > > > On Fri, Sep 07, 2018 at 12:53:06PM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-10 Thread Jerome Glisse
On Mon, Sep 10, 2018 at 11:28:09AM +0800, Kenneth Lee wrote: > On Fri, Sep 07, 2018 at 12:53:06PM -0400, Jerome Glisse wrote: > > On Fri, Sep 07, 2018 at 12:01:38PM +0800, Kenneth Lee wrote: > > > On Thu, Sep 06, 2018 at 09:31:33AM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-07 Thread Jerome Glisse
On Fri, Sep 07, 2018 at 06:55:45PM +0100, Jean-Philippe Brucker wrote: > On 07/09/2018 17:53, Jerome Glisse wrote: > > So there is no reasons to do that under VFIO. Especialy as in your example > > it is not a real user space device driver, the userspace portion only knows >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-07 Thread Jerome Glisse
On Fri, Sep 07, 2018 at 12:01:38PM +0800, Kenneth Lee wrote: > On Thu, Sep 06, 2018 at 09:31:33AM -0400, Jerome Glisse wrote: > > Date: Thu, 6 Sep 2018 09:31:33 -0400 > > From: Jerome Glisse > > To: Kenneth Lee > > CC: Alex Williamson , Kenneth Lee > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-06 Thread Jerome Glisse
On Thu, Sep 06, 2018 at 05:45:32PM +0800, Kenneth Lee wrote: > On Tue, Sep 04, 2018 at 10:15:09AM -0600, Alex Williamson wrote: > > Date: Tue, 4 Sep 2018 10:15:09 -0600 > > From: Alex Williamson > > To: Jerome Glisse > > CC: Kenneth Lee , Jonathan Corbet , > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-04 Thread Jerome Glisse
On Mon, Sep 03, 2018 at 08:51:57AM +0800, Kenneth Lee wrote: > From: Kenneth Lee > > WarpDrive is an accelerator framework to expose the hardware capabilities > directly to the user space. It makes use of the exist vfio and vfio-mdev > facilities. So the user application can send request and DMA

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-13 Thread Jerome Glisse
On Mon, Aug 13, 2018 at 05:29:31PM +0800, Kenneth Lee wrote: > > I made a quick change basing on the RFCv1 here: > > https://github.com/Kenneth-Lee/linux-kernel-warpdrive/commits/warpdrive-v0.6 > > I just made it compilable and not test it yet. But it shows how the idea is > going to be. > > T

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-10 Thread Jerome Glisse
On Fri, Aug 10, 2018 at 11:39:13AM +0800, Kenneth Lee wrote: > On Thu, Aug 09, 2018 at 10:46:13AM -0400, Jerome Glisse wrote: > > Date: Thu, 9 Aug 2018 10:46:13 -0400 > > From: Jerome Glisse > > To: Kenneth Lee > > CC: Kenneth Lee , "Tian, Kevin" > >

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-09 Thread Jerome Glisse
On Thu, Aug 09, 2018 at 04:03:52PM +0800, Kenneth Lee wrote: > On Wed, Aug 08, 2018 at 11:18:35AM -0400, Jerome Glisse wrote: > > On Wed, Aug 08, 2018 at 09:08:42AM +0800, Kenneth Lee wrote: > > > 在 2018年08月06日 星期一 11:32 下午, Jerome Glisse 写道: > > > > On Mon, Au

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-08 Thread Jerome Glisse
On Wed, Aug 08, 2018 at 09:08:42AM +0800, Kenneth Lee wrote: > > > 在 2018年08月06日 星期一 11:32 下午, Jerome Glisse 写道: > > On Mon, Aug 06, 2018 at 11:12:52AM +0800, Kenneth Lee wrote: > > > On Fri, Aug 03, 2018 at 10:39:44AM -0400, Jerome Glisse wrote: > > > > On F

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-06 Thread Jerome Glisse
On Mon, Aug 06, 2018 at 11:12:52AM +0800, Kenneth Lee wrote: > On Fri, Aug 03, 2018 at 10:39:44AM -0400, Jerome Glisse wrote: > > On Fri, Aug 03, 2018 at 11:47:21AM +0800, Kenneth Lee wrote: > > > On Thu, Aug 02, 2018 at 10:22:43AM -0400, Jerome Glisse wrote: > > > >

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-03 Thread Jerome Glisse
On Fri, Aug 03, 2018 at 03:20:43PM +0100, Alan Cox wrote: > > If we are going to have any kind of general purpose accelerator API then > > > it has to be able to implement things like > > > > Why is the existing driver model not good enough ? So you want > > a device with function X you look int

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-03 Thread Jerome Glisse
On Fri, Aug 03, 2018 at 11:47:21AM +0800, Kenneth Lee wrote: > On Thu, Aug 02, 2018 at 10:22:43AM -0400, Jerome Glisse wrote: > > Date: Thu, 2 Aug 2018 10:22:43 -0400 > > From: Jerome Glisse > > To: Kenneth Lee > > CC: "Tian, Kevin" , Hao Fang , > &

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-02 Thread Jerome Glisse
On Thu, Aug 02, 2018 at 11:10:00AM +0100, Alan Cox wrote: > > One motivation I guess, is that most accelerators lack of a > > well-abstracted high level APIs similar to GPU side (e.g. OpenCL > > clearly defines Shared Virtual Memory models). VFIO mdev > > might be an alternative common interface

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-02 Thread Jerome Glisse
On Thu, Aug 02, 2018 at 12:05:57PM +0800, Kenneth Lee wrote: > On Thu, Aug 02, 2018 at 02:33:12AM +, Tian, Kevin wrote: > > Date: Thu, 2 Aug 2018 02:33:12 + > > > From: Jerome Glisse > > > On Wed, Aug 01, 2018 at 06:22:14PM +0800, Kenneth Lee wrote

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-01 Thread Jerome Glisse
On Wed, Aug 01, 2018 at 06:22:14PM +0800, Kenneth Lee wrote: > From: Kenneth Lee > > WarpDrive is an accelerator framework to expose the hardware capabilities > directly to the user space. It makes use of the exist vfio and vfio-mdev > facilities. So the user application can send request and DMA