Re: [PATCH] uacce: remove uacce_vma_fault

2020-06-17 Thread Jean-Philippe Brucker
ed as well, > required by __do_fault. > > Reported-by: Jean-Philippe Brucker > Signed-off-by: Zhangfei Gao Reviewed-by: Jean-Philippe Brucker > --- > drivers/misc/uacce/uacce.c | 9 - > 1 file changed, 9 deletions(-) > > diff --git a/drivers/misc/uacce/uac

Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-23 Thread Jean-Philippe Brucker
On Fri, Oct 18, 2019 at 08:01:44PM +0800, zhangfei@foxmail.com wrote: > > More generally, it would be nice to use the DMA API when SVA isn't > > supported, instead of manually allocating and mapping memory with > > iommu_map(). Do we only handcraft these functions in order to have VA == > > IOV

Re: [PATCH v6 1/3] uacce: Add documents for uacce

2019-10-21 Thread Jean-Philippe Brucker
Hi Kenneth, On Thu, Oct 17, 2019 at 03:49:07PM +0800, Kenneth Lee wrote: > Dear Jean, > > Please let me answer your question about why we build another subsystem > other than use vfio-mdev. > > I think you might remember that we did build WarpDrive on top of > vfio-mdev from the very beginning.

Re: [PATCH v6 1/3] uacce: Add documents for uacce

2019-10-16 Thread Jean-Philippe Brucker
Hi, I already commented on the interface in patch 2/3, so I just have a few additional comments on the documentation itself. On Wed, Oct 16, 2019 at 04:34:31PM +0800, Zhangfei Gao wrote: > +The user API > + > + > +We adopt a polling style interface in the user space: :: > + > + in

Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-16 Thread Jean-Philippe Brucker
Hi, I have a few comments on the overall design and some implementation details below. Could you also Cc io...@lists.linux-foundation.org on your next posting? I'm sure some subscribers would be interested and I don't think many people know about linux-accelerators yet. On Wed, Oct 16, 2019 at 0

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-20 Thread Jean-Philippe Brucker
On 20/11/2018 09:16, Jonathan Cameron wrote: > +CC Jean-Phillipe and iommu list. Thanks for the Cc, sorry I don't have enough bandwidth to follow this thread at the moment. > In WarpDrive/uacce, we make this simple. If you support IOMMU and it > support > SVM/SVA. Everything will be

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-07 Thread Jean-Philippe Brucker
On 07/09/2018 17:53, Jerome Glisse wrote: > So there is no reasons to do that under VFIO. Especialy as in your example > it is not a real user space device driver, the userspace portion only knows > about writting command into command buffer AFAICT. > > VFIO is for real userspace driver where inte

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-10 Thread Jean-Philippe Brucker
Hi Kenneth, On 10/08/18 04:39, Kenneth Lee wrote: >> You can achieve everything you want to achieve with existing upstream >> solution. Re-inventing a whole new driver infrastructure should really >> be motivated with strong and obvious reasons. > > I want to understand better of your idea. If I