Thanks allot!
James
On Fri, 2009-02-06 at 08:30 +1100, Herbert Xu wrote:
> On Thu, Feb 05, 2009 at 11:47:48AM -0800, James Hsiao wrote:
> >
> > Thanks for apply the patch.
> > Somehow the new directory driver/crypto/amcc is missing from the tree.
> > I can see everyth
+1100, Herbert Xu wrote:
> On Wed, Jan 28, 2009 at 02:53:05PM -0800, James Hsiao wrote:
> > This patch adds support for AMCC ppc4xx security device driver. This is the
> > initial release that includes the driver framework with AES and SHA1
> > algorithms
> > support.
&
11:30:50AM -0800, James Hsiao wrote:
> > This is the 5th submission of AMCC's security driver.
> > - remove aad support in build pd function, since we didn't release any
> > algorithm that use aead yet.
> >
> > - changed some hardcode value to #defines
>
Ok, I will remove the unused code for now.
Thanks
James
On Mon, 2008-12-08 at 18:35 -0600, Kim Phillips wrote:
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.htm
Hi Kim,
>> + /* figure how many gd is needed */
>> + if (aad_len) {
>> + num_gd = get_sg_count(assoc, aad_len) +
>> + get_sg_count(src, datalen);
> this is dead code - aad_len is never non-zero - is there some code
> missing from crypto4xx_alg.c? Also, II
Hi Kim,
I try to address some of the comments. I am not mentioning things that I
agree with you.
> + */
> +static int get_sg_count(struct scatterlist *sg_list, int nbytes)
> +{
> + struct scatterlist *sg = sg_list;
> + int sg_nents = 0;
> +
> + while (nbytes) {
> + sg_ne
I think the patch format in the email is incorrect, so the one go to
linux-crypto was filtered out. And the one directly to Kim was received
and Kim kindly reviewed
Thanks for review.
James
On Wed, 2008-10-29 at 14:14 +0100, Sebastian Andrzej Siewior wrote:
> * James Hsiao | 2008-10-27