Hi Dan,
I'm assuming you mean the upper 3 bits rather than bytes?
Thanks for the patch
James.
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: 20 March 2015 14:22
> To: Herbert Xu; James Hartley
> Cc: David S. Miller; linux-cr
Hi Dan,
Thanks for the patch.
James.
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: 20 March 2015 14:21
> To: Herbert Xu; James Hartley
> Cc: David S. Miller; linux-crypto@vger.kernel.org; kernel-
> janit...@vger.kernel.org
>
The Kconfig entry for CRYPTO_DEV_IMGTEC_HASH incorrectly selects
CRYPTO_SHA224, which does not exist (and is covered by CRYPTO_SHA256
which covers both 224 and 256). Remove it.
Also correct typo CRYPTO_ALG_API to be CRYPTO_ALGPI.
Reported-by: Valentin Rothberg
Signed-off-by: James Hartley
Hi Valentin,
> On 18 Mar 2015, at 01:35, Valentin Rothberg
> wrote:
>
> Hi James,
>
> your commit d358f1abbf71 ("crypto: img-hash - Add Imagination
> Technologies hw hash accelerator") adds two selects on undefined
> Kconfig symbols, namely CRYPTO_ALG_API and CRYPTO_SHA224.
>
> The first sym
Vladimir Zapolskiy
* rebased to current linux-next
James Hartley (2):
This adds support for the Imagination Technologies hash accelerator
which provides hardware acceleration for SHA1 SHA224 SHA256 and
MD5 hashes.
This adds the binding documentation for the Imaginat
This adds support for the Imagination Technologies hash accelerator which
provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes.
Signed-off-by: James Hartley
---
drivers/crypto/Kconfig| 14 +
drivers/crypto/Makefile |1 +
drivers/crypto/img-hash.c | 1030
This adds the binding documentation for the Imagination Technologies hash
accelerator that provides hardware acceleration for SHA1/SHA224/SHA256/MD5
hashes. This hardware will be present in the upcoming pistachio SoC.
Signed-off-by: James Hartley
Reviewed-by: Andrew Bresticker
Hi Andrew,
> -Original Message-
> From: abres...@google.com [mailto:abres...@google.com] On Behalf Of
> Andrew Bresticker
> Sent: 12 March 2015 18:57
> To: James Hartley
> Cc: Herbert Xu; smuel...@chronox.de; devicet...@vger.kernel.org; Ezequiel
> Garcia; linux-c
This adds support for the Imagination Technologies hash accelerator which
provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes.
Signed-off-by: James Hartley
---
drivers/crypto/Kconfig| 14 +
drivers/crypto/Makefile |1 +
drivers/crypto/img-hash.c | 1028
This adds the binding documentation for the Imagination Technologies hash
accelerator that provides hardware acceleration for SHA1/SHA224/SHA256/MD5
hashes. This hardware will be present in the upcoming pistachio SoC.
Signed-off-by: James Hartley
---
.../devicetree/bindings/crypto/img-hash.txt
the driver as a result of the above rework
Changes from V1:
* Addressed review comments from Andrew Bresticker and
Vladimir Zapolskiy
* rebased to current linux-next
James Hartley (2):
This adds support for the Imagination Technologies hash accelerator
which p
Hi Andrew,
> -Original Message-
> From: abres...@google.com [mailto:abres...@google.com] On Behalf Of
> Andrew Bresticker
> Sent: 10 March 2015 18:02
> To: James Hartley
> Cc: linux-crypto@vger.kernel.org
> Subject: Re: [PATCH V3 1/2] crypto: Add Imagination
Hi Andrew
> -Original Message-
> From: abres...@google.com [mailto:abres...@google.com] On Behalf Of
> Andrew Bresticker
> Sent: 06 March 2015 21:50
> To: James Hartley
> Cc: linux-crypto@vger.kernel.org
> Subject: Re: [PATCH V3 2/2] Documentation: crypto: Add DT b
Hi Andrew
> -Original Message-
> From: abres...@google.com [mailto:abres...@google.com] On Behalf Of
> Andrew Bresticker
> Sent: 09 March 2015 05:42
> To: James Hartley
> Cc: linux-crypto@vger.kernel.org
> Subject: Re: [PATCH V3 1/2] crypto: Add Imagination
> -Original Message-
> From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto-
> ow...@vger.kernel.org] On Behalf Of Herbert Xu
> Sent: 10 March 2015 09:56
> To: James Hartley
> Cc: Stephan Mueller; robh...@kernel.org; pawel.m...@arm.com;
> mar
Resend with correct email address for Andrew Bresticker.
> -Original Message-
> From: James Hartley
> Sent: 10 March 2015 09:53
> To: 'Herbert Xu'; Stephan Mueller
> Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com;
> ga...@codeaurora.org; an
> -Original Message-
> From: Herbert Xu [mailto:herb...@gondor.apana.org.au]
> Sent: 10 March 2015 09:37
> To: Stephan Mueller
> Cc: James Hartley; robh...@kernel.org; pawel.m...@arm.com;
> mark.rutl...@arm.com; ga...@codeaurora.org;
> andrew.brestic...@chromium
This adds the binding documentation for the Imagination Technologies
hash accelerator that provides hardware acceleration for
SHA1/SHA224/SHA256/MD5 hashes. This hardware will be present in
the upcoming pistachio SoC.
Signed-off-by: James Hartley
---
.../devicetree/bindings/crypto/img-hash.txt
* rebased to current linux-next
James Hartley (2):
crypto: Add Imagination Technologies hw hash accelerator
Documentation: crypto: Add DT binding info for the img hw hash
accelerator
.../devicetree/bindings/crypto/img-hash.txt| 27 +
drivers/crypto/Kconfig
This adds support for the Imagination Technologies hash
accelerator which provides hardware acceleration for
SHA1 SHA224 SHA256 and MD5 hashes.
Signed-off-by: James Hartley
---
drivers/crypto/Kconfig| 14 +
drivers/crypto/Makefile |2 +
drivers/crypto/img-hash.c | 1037
On 01/28/15 00:56, Herbert Xu wrote:
On Wed, Jan 28, 2015 at 12:29:29AM +, James Hartley wrote:
- If it is mandatory to impement a fallback driver (because the
potential users of the framework would not know only digest is
supported?)
Yes it is mandatory.
If I need to implement
On 01/28/15 00:01, James Hartley wrote:
> > +struct img_hash_request_ctx {
> > +struct img_hash_dev*hdev;
> > +u8 digest[SHA256_DIGEST_SIZE] __aligned(sizeof(u32));
> > +unsigned longflags;
> > +size_tdigsize;
> > +
Hi Herbert, thanks for the review.
> -Original Message-
> From: devicetree-ow...@vger.kernel.org [mailto:devicetree-
> ow...@vger.kernel.org] On Behalf Of Herbert Xu
> Sent: 20 November 2014 14:22
> To: James Hartley
> Cc: da...@davemloft.net; grant.lik...@linaro.org;
Hi All,
Apologies for this approach, but although my email replies seem to get
through to the mailing list, my patches dont (although they do appear to
land on the device tree list).
I'm sure Herbert will have received it in his inbox, but for anyone else
who might want to comment on the pat
This adds support for the Imagination Technologies hash
accelerator which provides hardware acceleratopm for
SHA1 SHA224 SHA256 and MD5 hashes.
Signed-off-by: James Hartley
---
MAINTAINERS |5 +
drivers/crypto/Kconfig| 14 +
drivers/crypto/Makefile |1 +
drivers
James Hartley (2):
crypto: Add Imagination Technologies hw hash accelerator
Documentation: crypto: Add DT binding info for the img hw hash
accelerator
.../devicetree/bindings/crypto/img-hash.txt| 26 +
MAINTAINERS|5 +
drivers/crypto
This adds the binding documenation for the Imagination Technologies
hash accelerator that provides hardware acceleration for
SHA1/SHA224/SHA256/MD5 hashes. This hardware will be present in
the upcoming pistachio SoC.
Signed-off-by: James Hartley
---
.../devicetree/bindings/crypto/img-hash.txt
Hi Andrew
> -Original Message-
> From: abres...@google.com [mailto:abres...@google.com] On Behalf Of
> Andrew Bresticker
> Sent: 10 November 2014 17:30
> To: James Hartley
> Cc: herb...@gondor.apana.org.au; da...@davemloft.net; Grant Likely; Rob
> Herring; a...@linux
Andrew,
Thanks for the review
> -Original Message-
> From: abres...@google.com [mailto:abres...@google.com] On Behalf Of
> Andrew Bresticker
> Sent: 14 November 2014 23:59
> To: James Hartley
> Cc: Herbert Xu; da...@davemloft.net; Grant Likely; Rob Herring;
> a...
Hi Vladimir
> -Original Message-
> From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto-
> ow...@vger.kernel.org] On Behalf Of Vladimir Zapolskiy
> Sent: 11 November 2014 15:12
> To: James Hartley; grant.lik...@linaro.org; robh...@kernel.org;
> a...@linux-f
Hi Vladimir, thanks for the review!
> -Original Message-
> From: Vladimir Zapolskiy [mailto:vladimir_zapols...@mentor.com]
> Sent: 10 November 2014 15:10
> To: James Hartley; herb...@gondor.apana.org.au; da...@davemloft.net;
> grant.lik...@linaro.org; robh...@kernel.
This adds support for the Imagination Technologies hash
accelerator that provides hardware acceleration for
SHA1 SHA224 SHA256 and MD5 Hashes.
This hardware is present in the upcoming Pistachio SoC.
James Hartley (2):
crypto: Add Imagination Technologies hw hash accelerator
Documentation
This adds support for the Imagination Technologies hash
accelerator that provides hardware acceleration for
SHA1 SHA224 SHA256 and MD5 Hashes.
Signed-off-by: James Hartley
---
MAINTAINERS |5 +
drivers/crypto/Kconfig| 13 +
drivers/crypto/Makefile |1 +
drivers
Signed-off-by: James Hartley
---
.../devicetree/bindings/crypto/img-hash.txt| 28
1 file changed, 28 insertions(+)
create mode 100644 Documentation/devicetree/bindings/crypto/img-hash.txt
diff --git a/Documentation/devicetree/bindings/crypto/img-hash.txt
b
34 matches
Mail list logo
