Re: [PATCH v10 0/5] Add Loongson Security Engine chip driver

2025-05-28 Thread Huacai Chen
On Wed, May 28, 2025 at 5:15 PM Yanteng Si wrote: > > 在 5/28/25 4:17 PM, Huacai Chen 写道: > > On Wed, May 28, 2025 at 4:06 PM Qunqin Zhao wrote: > >> > >> > >> 在 2025/5/28 下午3:17, Huacai Chen 写道: > >>> Hi, Qunqin, > >>> > >&g

Re: [PATCH v10 0/5] Add Loongson Security Engine chip driver

2025-05-28 Thread Huacai Chen
On Wed, May 28, 2025 at 4:06 PM Qunqin Zhao wrote: > > > 在 2025/5/28 下午3:17, Huacai Chen 写道: > > Hi, Qunqin, > > > > As I said before, why the patch "MAINTAINERS: Add entry for Loongson > > Security Module driver" is missing? > > Hi, Huacai > &

Re: [PATCH v10 0/5] Add Loongson Security Engine chip driver

2025-05-28 Thread Huacai Chen
Hi, Qunqin, As I said before, why the patch "MAINTAINERS: Add entry for Loongson Security Module driver" is missing? Huacai On Wed, May 28, 2025 at 2:59 PM Qunqin Zhao wrote: > > The Loongson Security Engine chip supports RNG, SM2, SM3 and SM4 > accelerator engines. Each engine have its own DMA

Re: [PATCH v9 0/5] Add Loongson Security Engine chip driver

2025-05-11 Thread Huacai Chen
Hi, Qunqin, Where is the 2nd patch in V7? Huacai On Tue, May 6, 2025 at 12:33 PM Qunqin Zhao wrote: > > The Loongson Security Engine chip supports RNG, SM2, SM3 and SM4 > accelerator engines. Each engine have its own DMA buffer provided > by the controller. The kernel cannot directly send comma

Re: [PATCH v8 0/5] Add Loongson Security Engine chip driver

2025-04-30 Thread Huacai Chen
On Wed, Apr 30, 2025 at 4:47 PM Qunqin Zhao wrote: > > > 在 2025/4/30 下午4:18, Herbert Xu 写道: > > On Wed, Apr 30, 2025 at 04:14:40PM +0800, Qunqin Zhao wrote: > >> Sorry to bother you, may i ask is it fine to move the Security Engine base > >> driver[Patch v8 1/5] to drivers/crypto ? > >> > >> The

Re: [PATCH v8 0/5] Add Loongson Security Engine chip driver

2025-04-20 Thread Huacai Chen
Hi, Qunqin, On Fri, Apr 18, 2025 at 5:33 PM Qunqin Zhao wrote: > > The Loongson Security Engine chip supports RNG, SM2, SM3 and SM4 > accelerator engines. Each engine have its own DMA buffer provided > by the controller. The kernel cannot directly send commands to the > engine and must first send

Re: [PATCH v7 3/6] crypto: loongson - add Loongson RNG driver support

2025-04-06 Thread Huacai Chen
Hi, Qunqin, On Thu, Apr 3, 2025 at 10:46 AM Qunqin Zhao wrote: > > Loongson's Random Number Generator is found inside Loongson security > engine. > > Co-developed-by: Yinggang Gu > Signed-off-by: Yinggang Gu > Signed-off-by: Qunqin Zhao > Reviewed-by: Huacai

Re: [PATCH v6 1/6] mfd: Add support for Loongson Security Module

2025-03-31 Thread Huacai Chen
Hi, Qunqin, On Thu, Mar 27, 2025 at 10:17 AM Qunqin Zhao wrote: > > This driver supports Loongson Security Module, which provides the control > for it's hardware encryption acceleration child devices. > > Co-developed-by: Yinggang Gu > Signed-off-by: Yinggang Gu > Signed-off-by: Qunqin Zhao >

Re: [PATCH v6 5/6] tpm: Add a driver for Loongson TPM device

2025-03-31 Thread Huacai Chen
Hi, Qunqin, On Thu, Mar 27, 2025 at 10:18 AM Qunqin Zhao wrote: > > Loongson security engine supports random number generation, hash, > symmetric encryption and asymmetric encryption. Based on these > encryption functions, TPM2 have been implemented in the Loongson > security engine firmware. Thi

Re: [PATCH v6 3/6] crypto: loongson - add Loongson RNG driver support

2025-03-31 Thread Huacai Chen
Hi, Qunqin, On Thu, Mar 27, 2025 at 10:17 AM Qunqin Zhao wrote: > > Loongson's Random Number Generator is found inside Loongson security > engine. > > Co-developed-by: Yinggang Gu > Signed-off-by: Yinggang Gu > Signed-off-by: Qunqin Zhao > --- > v6: Replace all "ls6000se" with "loongson" > v2-

Re: [PATCH v6 0/6] Drivers for Loongson security engine

2025-03-31 Thread Huacai Chen
driver, crypto and tpm are users. I have some small comments, if you make changes then you can add "Reviewed-by: Huacai Chen " for all patches. Huacai > > v6: mfd :MFD_LS6000SE -> MFD_LOONGSON_SE, ls6000se.c -> loongson-se.c > > crypto :CRYPTO_DEV_LS6000SE_RNG -&

Re: [PATCH v5 0/6] Drivers for Loongson security engine

2025-03-14 Thread Huacai Chen
On Thu, Mar 13, 2025 at 5:59 PM Qunqin Zhao wrote: > > > 在 2025/3/13 下午5:26, Huacai Chen 写道: > > You haven't seen my comments in previous version? > > > > https://lore.kernel.org/loongarch/CAAhV-H5xyRrF1_=e7rlm3dheyaebdmufyqvgoxaq6+d6s5u...@mail.gmail.com/ > >

Re: [PATCH v5 0/6] Drivers for Loongson security engine

2025-03-13 Thread Huacai Chen
You haven't seen my comments in previous version? https://lore.kernel.org/loongarch/CAAhV-H5xyRrF1_=e7rlm3dheyaebdmufyqvgoxaq6+d6s5u...@mail.gmail.com/ Huacai On Thu, Mar 13, 2025 at 5:05 PM Qunqin Zhao wrote: > > Loongson security engine supports random number generation, hash, > symmetric enc

Re: [PATCH v4 0/6] Drivers for Loongson security engine

2025-02-28 Thread Huacai Chen
Hi, Qunqin, On Wed, Feb 26, 2025 at 11:04 AM Qunqin Zhao wrote: > > Loongson security engine supports random number generation, hash, > symmetric encryption and asymmetric encryption. Based on these > encryption functions, TPM2 have been implemented in it. > > mfd is the baser driver, crypto and