[v3 PATCH] KEYS: Invert FINAL_PUT bit

lt;--- Invert the FINAL_PUT bit so that test_bit_acquire and clear_bit_unlock can be used instead of smp_mb. Signed-off-by: Herbert Xu diff --git a/include/linux/key.h b/include/linux/key.h index ba05de8579ec..81b8f05c6898 100644 --- a/include/linux/key.h +++ b/include/linux/key.h @@ -236,7 +23

Re: [PATCH 0/2] crypto: hisilicon/qm - memory allocation cleanups

ertions(+), 2 deletions(-) > --- > base-commit: 37ff6e9a2ce321b7932d3987701757fb4d87b0e6 > change-id: 20250503-hisilicon_qm-7b581a9b3799 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[v2 PATCH] KEYS: Invert FINAL_PUT bit

re is already a flag called KEY_FLAG_DEAD and it would be very confusing since they mean completely diferent things. How about USER_ALIVE? ---8<--- Invert the FINAL_PUT bit so that test_bit_acquire and clear_bit_unlock can be used instead of smp_mb. Signed-off-by: Herbert Xu diff --git a/include/lin

[PATCH] KEYS: Invert FINAL_PUT bit

On Sun, May 04, 2025 at 08:35:57AM +0800, Herbert Xu wrote: > > Or even better, reverse the FINAL_PUT bit and call it ALIVE, so > that you can use test_bit_acquire and clear_bit_unlock. Something like: ---8<--- Invert the FINAL_PUT bit so that test_bit_acquire and clear_bit_unlock

Re: [PATCH] KEYS: Reduce smp_mb() calls in key_put()

everse the FINAL_PUT bit and call it ALIVE, so that you can use test_bit_acquire and clear_bit_unlock. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] KEYS: Reduce smp_mb() calls in key_put()

does smp_mb() do > in that branch? Just checking if I'm missing something before sending > fixed version. I don't think spin_unlock alone is enough to replace an smp_mb. A spin_lock + spin_unlock would be enough though. However, looking at the bigger picture this smp_mb looks bogus. W

Re: [PATCH v8 0/5] Add Loongson Security Engine chip driver

> > "drivers/iio/common/ssp_sensors/ssp_dev.c" and > "drivers/firmware/xilinx/zynqmp.c". > > Thank you, and I look forward to hearing from you. I don't mind at this point in time. But if this driver were to develop features way outside of the Crypto API in fut

Re: [PATCH] crypto: iaa: Adjust workqueue allocation type

he allocation type to match the assignment. > > Signed-off-by: Kees Cook > --- > Cc: Kristen Accardi > Cc: Vinicius Costa Gomes > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: > --- > drivers/crypto/intel/iaa/iaa_crypto_main.c | 2 +- > 1 file

Re: [PATCH] crypto: using size_add() for kmalloc()

ze shouldn't even exceed a page in size, let alone be anywhere near 2^32. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: using size_add() for kmalloc()

7;re truly worried about this, you should change the algorithm registration code to check whether reqsize is sane. And that needs to wait until the algorithms are fixed to not use dynamic reqsizes. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: core - Add WARN_ON for buggy read return values

ffa00ecb7e57 So the return value was 0x903, way bigger than what we asked for (0x40). Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v7 3/6] crypto: loongson - add Loongson RNG driver support

d register with hwrng. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: axis/artpec6: change from kzalloc to kcalloc in artpec6_crypto_probe()

rds > --- > drivers/crypto/axis/artpec6_crypto.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: virtio - Erase some sensitive memory when it is freed

d instead. > --- > drivers/crypto/virtio/virtio_crypto_core.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/5] crypto virtio cleanups

/virtio_crypto_akcipher_algs.c | 41 --- > drivers/crypto/virtio/virtio_crypto_mgr.c | 2 +- > .../virtio/virtio_crypto_skcipher_algs.c | 17 ++-- > 3 files changed, 21 insertions(+), 39 deletions(-) > > -- > 2.43.0 All applied. Thanks. --

Re: [v3 PATCH] rhashtable: Fix rhashtable_try_insert test

return ERR_PTR(-EINVAL); But data == NULL is not an error, it is a successful return value for rhltable. It's when a key already exists in the rhltable and we're simply appending the new object to it. Thus the insertion was successful but the hash table did not grow. Cheers, --

[v3 PATCH] rhashtable: Fix rhashtable_try_insert test

erflow. Reported-by: Michael Kelley Fixes: e1d3422c95f0 ("rhashtable: Fix potential deadlock by moving schedule_work outside lock") Signed-off-by: Herbert Xu diff --git a/lib/rhashtable.c b/lib/rhashtable.c index bf956b85455a..0e9a1d4cf89b 100644 --- a/lib/rhashtable.c +++ b/lib/rhashta

Re: [PATCH] Add KUnit tests for curve25519

ially based on the existing curve25519 selftests in > crypto/curve25519-selftest.c Please explain the difference between this and the existing selftest. Why do we need both of them? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 00/19] Migrate to sig_alg and templatize ecdsa

| 152 ++- > include/linux/asn1_decoder.h | 1 + > include/linux/asn1_encoder.h | 1 - > include/linux/slab.h | 1 + > include/uapi/linux/cryptouser.h | 5 + > include/uapi/li

Re: [PATCH] hwrng: core - Add WARN_ON for buggy read return values

-0:1.0: 10 ports detected {code} Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: core - Add WARN_ON for buggy read return values

user interactions somehow, will > end up getting a CVE id when we fix it up to not do so. If the aformentioned WARN_ON hits, then the driver has probabaly already done a buffer overrun so it's a CVE anyway. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] hwrng: core - Add WARN_ON for buggy read return values

On Mon, Sep 23, 2024 at 10:52:49AM +0300, Jarkko Sakkinen wrote: > On Mon Sep 23, 2024 at 9:05 AM EEST, Herbert Xu wrote: > > Dear TPM maintainers: > > There's really only just me (for past 10 years). Maybe that should be > updatred. :) > > BUG_ON(!m

[PATCH] hwrng: core - Add WARN_ON for buggy read return values

he hwrng core. Reported-by: Guangwu Zhang Signed-off-by: Herbert Xu diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index 57c51efa5613..018316f54621 100644 --- a/drivers/char/hw_random/core.c +++ b/drivers/char/hw_random/core.c @@ -181,8 +181,15 @@ static inline int rng_

Re: [PATCH v3 00/14] KEYS: Add support for PGP keys and signatures

On Sun, Sep 15, 2024 at 05:15:25PM +0800, Herbert Xu wrote: > > Roberto, correct me if I'm wrong but your intended use case is > the following patch series, right? Actually the meat of the changes is in the following series: https://lore.kernel.org/linux-integrity/2024090515

Re: [PATCH v3 00/14] KEYS: Add support for PGP keys and signatures

erto, correct me if I'm wrong but your intended use case is the following patch series, right? https://lore.kernel.org/linux-integrity/20240905152512.3781098-1-roberto.sa...@huaweicloud.com/ Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://

Re: [PATCH v3 00/14] KEYS: Add support for PGP keys and signatures

e-case is bogus, then distro package verification is going to be the only application for PGP keys in the kernel. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 00/14] KEYS: Add support for PGP keys and signatures

of guarantees. Where is this discussion? I clicked through the two links above and everyone seems to agree that putting it in user-space is a good idea. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 00/14] KEYS: Add support for PGP keys and signatures

ing. If we really wanted to we could extend the user-space verification to modules too and perhaps kick all public key crypto out of the kernel. The complexity and lack of reviewer attention in this area means that we're more likely to introduce security holes into the kernel with such cod

Re: [PATCH] virtio-crypto: support crypto engine framework

xposed outside of the kernel. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][next] crypto: nx - Use static_assert() to check struct sizes

drivers/crypto/nx/nx-842.h | 3 +++ > 1 file changed, 3 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][next] crypto: qat - Use static_assert() to check struct sizes

drivers/crypto/intel/qat/qat_common/qat_bl.h | 2 ++ > 1 file changed, 2 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: chacha20poly1305 - Annotate struct chachapoly_ctx with __counted_by()

insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: arm/crc32 - add kCFI annotations to asm routines

kCFI is enabled. > > Cc: Kees Cook > Cc: Linus Walleij > Signed-off-by: Ard Biesheuvel > --- > arch/arm/crypto/crc32-ce-core.S | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.

Re: [PATCH v7 4/5] keys: asymmetric: Add tpm2_key_rsa

>hash_algo) { > + asn1 = rsa_lookup_asn1(params->hash_algo); Could you please explain why this can't be done through pkcs1pad instead of going to raw RSA? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: sm2 - Remove sm2 algorithm

emove this algorithm. It can be resubmitted when it is integrated properly into the asymmetric_keys subsystem. Signed-off-by: Herbert Xu --- crypto/Kconfig| 18 - crypto/Makefile | 8 - crypto/asymmetric_keys/pkcs7_parser.c | 4 - c

Re: [v3 PATCH] hwrng: core - Remove add_early_randomness

ernel thread doing the same thing, but moreover random.c itself has been modified so that it is no longer starved of entropy on startup. There is no reason to feed any early randomness. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [v3 PATCH] hwrng: core - Remove add_early_randomness

On Wed, May 22, 2024 at 02:51:36PM +0300, Jarkko Sakkinen wrote: > > What is the kthread doing this currently? It's hwrng_fillfn. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [v3 PATCH] hwrng: core - Remove add_early_randomness

compared to when the patch was first applied. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[v3 PATCH] hwrng: core - Remove add_early_randomness

gers Fixes: 1b6d7f9eb150 ("tpm: add session encryption protection to tpm2_get_random()") Link: https://lore.kernel.org/r/119dc5ed-f159-41be-9dda-1a056f29888d@notapiano/ Signed-off-by: Herbert Xu diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index f5c71a617a99

[v2 PATCH] crypto: api - Do not load modules if called by async probing

as F. R. A. Prado Reported-by: Eric Biggers Signed-off-by: Herbert Xu --- crypto/api.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crypto/api.c b/crypto/api.c index 22556907b3bc..7c4b9f86c1ad 100644 --- a/crypto/api.c +++ b/crypto/api.c @@ -10,6 +10,7 @@ *

Re: [PATCH] crypto: api - Do not load modules until algapi is ready

requires instantiation (anything with "()" in its name). Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: api - Do not load modules until algapi is ready

no point and it may deadlock) until such a point where all/most drivers have finished loading. So if the algorithm is missing (which shouldn't happen because of Kconfig selects), then it will simply fail. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/

Re: [PATCH v8 18/22] tpm: add session encryption protection to tpm2_get_random()

and all the required algorithms. You can verify this with the failing .config file as it has everything needed built into the kernel (which is in fact where the problem is). Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: api - Do not load modules until algapi is ready

re that it doesn't load modules if this is the case by checking crypto_boot_test_finished(). Add a call to wait_for_device_probe so that the drivers that may call into the Crypto API have finished probing. Reported-by: Nícolas F. R. A. Prado" Reported-by: Eric Biggers Signed-off-by: Herbert Xu

Re: [PATCH v2] crypto: rsa-pkcs1pad: export rsa1_asn_lookup()

uct. > --- > crypto/rsa-pkcs1pad.c | 16 ++-- > include/crypto/rsa-pkcs1pad.h | 20 > 2 files changed, 30 insertions(+), 6 deletions(-) > create mode 100644 include/crypto/rsa-pkcs1pad.h Please provide a link to the patch that will make use of this. Thank

Re: [PATCH v8 6/6] docs: trusted-encrypted: add DCP as new trust source

On Wed, Apr 03, 2024 at 06:47:51PM +0300, Jarkko Sakkinen wrote: > > Reviewed-by: Jarkko Sakkinen > > I can only test that this does not break a machine without the > hardware feature. Please feel free to take this through your tree. Thanks, -- Email: Herbert Xu

Re: [PATCH][next] crypto: qat - Avoid -Wflex-array-member-not-at-end warnings

ot at the end of another structure > [-Wflex-array-member-not-at-end] > > Link: https://github.com/KSPP/linux/issues/202 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/crypto/intel/qat/qat_common/qat_bl.c | 6 -- > drivers/crypto/intel/qat/qat_common/qat_bl.h | 11 +

Re: [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine

1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][next] crypto/nx: Avoid -Wflex-array-member-not-at-end warning

^~ > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/crypto/nx/nx-842.c | 6 -- > drivers/crypto/nx/nx-842.h | 10 ++ > 2 files changed, 10 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: virtio/akcipher - Fix stack overflow on memcpy

rtio-crypto: implement RSA algorithm") > Link: > https://lore.kernel.org/all/0a194a79-e3a3-45e7-be98-83abd3e1c...@roeck-us.net/ > Signed-off-by: zhenwei pi > --- > drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Patch

Re: [PATCH] crypto: sun8i-ce - Use kcalloc() instead of kzalloc()

> Signed-off-by: Erick Archer > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat - use kcalloc_node() instead of kzalloc_node()

ues/162 > Signed-off-by: Erick Archer > --- > drivers/crypto/intel/qat/qat_common/adf_isr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] dt-bindings: qcom-qce: Add compatible for SM6350

Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: virtio - Less function calls in __virtio_crypto_akcipher_do_req() after error detection

v2: > A typo was fixed for the delimiter of a label. > > drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: virtio-crypto: Wait for tasklet to complete on device remove

f-by: Gonglei > --- > drivers/crypto/virtio/virtio_crypto_core.c | 3 +++ > 1 file changed, 3 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: virtio-crypto: Fix gcc check warnings

ta) #endif extern const struct seq_operations cpuinfo_op; Please send this patch to the x86 people. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: virtio-crypto: Handle dataq logic with tasklet

drivers/crypto/virtio/virtio_crypto_core.c | 26 -- > 2 files changed, 18 insertions(+), 10 deletions(-) Your patch has already been merged. So please send this as an incremental patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][next] powerpc/crypto: Avoid -Wstringop-overflow warnings

pe; and just for consistency, do the same for parameter `Xi`. > > Reported-by: Stephen Rothwell > Closes: > https://lore.kernel.org/linux-next/20231121131903.68a37...@canb.auug.org.au/ > Signed-off-by: Gustavo A. R. Silva > --- > arch/powerpc/crypto/aes-gcm-p10-glue.c

Re: [PATCH] crypto: virtio-crypto: Handle dataq logic with tasklet

eletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 1/5] crypto: mxs-dcp: Add support for hardware-bound keys

--- > include/soc/fsl/dcp.h| 17 +++ > 2 files changed, 110 insertions(+), 11 deletions(-) > create mode 100644 include/soc/fsl/dcp.h Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] treewide: Add SPDX identifier to IETF ASN.1 modules

> crypto/rsapubkey.asn1| 7 +++ > fs/smb/server/ksmbd_spnego_negtokeninit.asn1 | 8 > fs/smb/server/ksmbd_spnego_negtokentarg.asn1 | 7 +++++++ > net/ipv4/netfilter/nf_nat_snmp_basic.asn1| 8 > 9 files changed, 62 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: Limit MODULE_SIG_KEY_TYPE_ECDSA to SHA384 or SHA512

384 curve is used, force using either SHA384 or SHA512. > > Signed-off-by: Dimitri John Ledkov > --- > certs/Kconfig | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] crypto: Limit MODULE_SIG_KEY_TYPE_ECDSA to SHA384 or SHA512

384 curve is used, force using either SHA384 or SHA512. > > Signed-off-by: Dimitri John Ledkov > --- > certs/Kconfig | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] module: Do not offer sha224 for built-in module signing

gt; sha224 being introduced. > > Signed-off-by: Dimitri John Ledkov > --- > kernel/module/Kconfig | 5 - > 1 file changed, 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: pkcs7: remove sha1 support

ic_keys/signature.c| 2 +- > crypto/asymmetric_keys/x509_cert_parser.c | 8 --- > crypto/testmgr.h | 80 --- > include/linux/oid_registry.h | 4 -- > kernel/module/Kconfig | 5 -- > 8 files changed, 2

Re: [PATCH] crypto: qat: Annotate struct adf_fw_counters with __counted_by

; (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct adf_fw_counters. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc

Re: [PATCH] crypto: qat - refactor deprecated strncpy

; drivers/crypto/intel/qat/qat_common/qat_uclo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: cavium/nitrox - refactor deprecated strncpy

off-by: Justin Stitt > --- > Note: build-tested only. > --- > drivers/crypto/cavium/nitrox/nitrox_hal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3] crypto: hisilicon/hpre - delete redundant log and return in advance

> --- > drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: crc32-generic - Use SPDX-License-Identifier

T > --- > crypto/crc32_generic.c | 24 +--- > 1 file changed, 1 insertion(+), 23 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: arm/curve25519 - Move '.fpu' after '.arch'

g > Fixes: d8f1308a025f ("crypto: arm/curve25519 - wire up NEON implementation") > Link: https://github.com/ClangBuiltLinux/continuous-integration2/issues/118 > Reported-by: Arnd Bergmann > Suggested-by: Arnd Bergmann > Suggested-by: Jessica Clarke > Signed-off-b

Re: [PATCH 0/3] crypto: hisilicon/hpre - add debug log

silicon/hpre - add debug log > > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 11 +-- > drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++-- > 2 files changed, 11 insertions(+), 4 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.

Re: [PATCH] crypto: qat - enable detection of accelerators hang

c | 40 +++ > .../crypto/qat/qat_common/adf_gen4_hw_data.h | 14 ++- > drivers/crypto/qat/qat_common/adf_init.c | 4 ++ > 9 files changed, 99 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 0/5] bug fix and clear coding style

le changed, 31 insertions(+), 6 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/2] crypto: correct the use of print format

3 files changed, 6 insertions(+), 6 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next 1/7] crypto: sun4i-ss - Fix PM reference leak when pm_runtime_get_sync() fails

.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: cavium - remove unused including

On Thu, Apr 08, 2021 at 11:21:51AM +0800, Tian Tao wrote: > Remove including that don't need it. > > Signed-off-by: Tian Tao > Signed-off-by: Zhiqi Song > --- > drivers/crypto/cavium/zip/common.h | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks. -- Em

Re: [PATCH -next 0/5] Remove redundant dev_err call

re.c | 1 - > 7 files changed, 3 insertions(+), 15 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/trng - add version to adapt new algorithm

off-by: Weili Qian > --- > drivers/crypto/hisilicon/trng/trng.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: arm64/aes-ce - deal with oversight in new CTR carry code

| 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/qm - add stop queue by hardware

ypto/hisilicon/qm.c | 29 - > 1 file changed, 28 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: ixp4xx -: use DEFINE_SPINLOCK() for spinlock

t; --- > drivers/crypto/ixp4xx_crypto.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: geode -: use DEFINE_SPINLOCK() for spinlock

> drivers/crypto/geode-aes.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] ecc: delete a useless function declaration

> v1 -> v2: Modify the 'Fixes tag' from '14bb76768275' to '4e6602916bc6 '. > > --- > crypto/ecc.h | 8 ---- > 1 file changed, 8 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/hpre - fix unmapping invalid dma address

-by: Hui Tang > --- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 18 ++ > 1 file changed, 18 insertions(+) This triggers new sparse warnings. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/8] ccp: KVM: SVM: Use stack for SEV command buffers

Herbert. I don't mind at all. Paolo you can take this through your tree. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat: Fix a double free in adf_create_ring

on/adf_transport.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH crypto] chcr: Read rxchannel-id from firmware

("crypto: chelsio - Use multiple txq/rxq per tfm to > process the requests) > Signed-off-by: Ayush Sawal > --- > drivers/crypto/chelsio/chcr_algo.c | 19 +-- > 1 file changed, 17 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH v2] crypto: hisilicon/qm - delete redundant code

v1 -> v2: > Re-edit the description. > > drivers/crypto/hisilicon/qm.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto:hisilicon/sec - fixup checking the 3DES weak key

ons(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][V2] crypto: sa2ul: Fix memory leak of rxd

o: sa2ul - Fix DMA mapping API usage") > Signed-off-by: Colin Ian King > --- > > V2: Fix typo in $SUBJECT > > --- > drivers/crypto/sa2ul.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://

Re: [PATCH][next] crypto: sun8i-ss: Fix memory leak of pad

uot;crypto: sun8i-ss - support hash algorithms") > Signed-off-by: Colin Ian King > --- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apan

Re: [PATCH] crypto: rockchip/rk3288_crypto_ahash - delete unneeded variable initialization

On Thu, Apr 01, 2021 at 11:01:39AM +0800, Kai Ye wrote: > Delete unneeded variable initialization > > Signed-off-by: Kai Ye > --- > drivers/crypto/rockchip/rk3288_crypto_ahash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Her

Re: [PATCH -next] crypto: ccp - Use DEFINE_SPINLOCK() for spinlock

o-main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: hisilicon/hpre - fix a typo in hpre_crypto.c

letion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ccp -A value assigned to a variable is never used.

d-off-by: Jiapeng Chong > --- > drivers/crypto/ccp/ccp-ops.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: hisilicon/sec - Fix a module parameter error

need to register the kernel mode algorithms. > > Signed-off-by: Longfang Liu > --- > > Changes in V2: > - Add algorithms unregistration processing > > drivers/crypto/hisilicon/sec2/sec_main.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) Pa

Re: crypto: possible NULL reference

ers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: allwinner: add missing CRYPTO_ prefix

ms") > Signed-off-by: Corentin Labbe > --- > drivers/crypto/allwinner/Kconfig | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 5/5] crypto: hisilicon/sgl - fix the sg buf unmap

[i].page_ctrl = NULL; > + hw_sge[i].buf = 0; > + hw_sge[i].len = 0; > + } > +} This causes a new sparse warning: CHECK ../drivers/crypto/hisilicon/sgl.c ../drivers/crypto/hisilicon/sgl.c:200:31: warning: restricted __le16 degrades to integer Please

  1   2   3   4   5   6   7   8   9   10   >