Re: [PATCH 5.10 000/286] 5.10.209-rc1 review

2024-01-26 Thread Guenter Roeck
On 1/26/24 14:35, Nathan Chancellor wrote: (slimming up the CC list, I don't think this is too relevant to the wider stable community) On Fri, Jan 26, 2024 at 01:01:15PM -0800, Guenter Roeck wrote: On 1/26/24 12:34, Nathan Chancellor wrote: On Fri, Jan 26, 2024 at 10:17:23AM -0800, Gu

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Guenter Roeck
On 4/18/21 9:27 PM, Alice Guo (OSS) wrote: > From: Alice Guo > > Update all the code that use soc_device_match because add support for > soc_device_match returning -EPROBE_DEFER. > > Signed-off-by: Alice Guo > --- [ ... ] > drivers/watchdog/renesas_wdt.c| 2 +- > 48 files chan

Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-02 Thread Guenter Roeck
; Cc: Linus Walleij > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Daniel Palmer > Cc: Bartosz Golaszewski > Cc: Avi Fishman > Cc: Tomer Maimon > Cc: Tali Perry > Cc: Joerg Roedel > Cc: Will Deacon > Cc: Andrew Jeffery > Cc: Joel Stanley > C

Re: [PATCH v3 4/5] amba: Make the remove callback return void

2021-01-27 Thread Guenter Roeck
rokhov > Acked-by: Krzysztof Kozlowski # for drivers/memory > Acked-by: Mark Brown > Acked-by: Dmitry Torokhov > Acked-by: Linus Walleij > Signed-off-by: Uwe Kleine-König For watchdog: Acked-by: Guenter Roeck Guenter > --- > drivers/amba/bus.c

Re: [PATCH 01/10] MIPS: TX49xx: Drop support

2021-01-05 Thread Guenter Roeck
| 2 +- Acked-by: Guenter Roeck Guenter

Re: [PATCH 15/17] crypto: arm/aes-ce - implement ciphertext stealing for CBC

2019-09-30 Thread Guenter Roeck
On Wed, Aug 21, 2019 at 05:32:51PM +0300, Ard Biesheuvel wrote: > Instead of relying on the CTS template to wrap the accelerated CBC > skcipher, implement the ciphertext stealing part directly. > > Signed-off-by: Ard Biesheuvel For arm:allmodconfig built with gcc 9.2.0, this patch results in ar

Re: [PATCH] crypto: scompress - initialize per-CPU variables on each CPU

2019-04-12 Thread Guenter Roeck
es") Reported-by: Guenter Roeck Signed-off-by: Sebastian Andrzej Siewior --- Guenter, this should cure that. Yes, it does. Tested-by: Guenter Roeck Tested with the patch applied on top of next-20190412, running all 345 qemu boot tests. No boot failures or new warnings observed. To be su

Re: [PATCH 2/2] crypto: scompress: Use per-CPU struct instead multiple variables

2019-04-12 Thread Guenter Roeck
On 4/12/19 1:54 AM, Sebastian Andrzej Siewior wrote: On 2019-04-10 21:39:34 [-0700], Eric Biggers wrote: Well, from a quick read of the patch, it's probably because it uses raw_cpu_ptr() instead of per_cpu_ptr() when allocating/freeing the buffers, so they are unlikely to actually be allocated f

Re: [PATCH 2/2] crypto: scompress: Use per-CPU struct instead multiple variables

2019-04-12 Thread Guenter Roeck
On 4/12/19 1:42 AM, Sebastian Andrzej Siewior wrote: On 2019-04-10 21:07:35 [-0700], Guenter Roeck wrote: Hi Sebastian, Hi Guenter, Unfortunately, this patch causes random crashes. … This is seen with an arm64 image running on qemu with machine xlnx-zcu102 and two CPUs, and crypto test

Re: [PATCH 2/2] crypto: scompress: Use per-CPU struct instead multiple variables

2019-04-10 Thread Guenter Roeck
Hi Sebastian, On Fri, Mar 29, 2019 at 02:09:56PM +0100, Sebastian Andrzej Siewior wrote: > Two per-CPU variables are allocated as pointer to per-CPU memory which > then are used as scratch buffers. > We could be smart about this and use instead a per-CPU struct which > contains the pointers alread

Re: [PATCH v4 3/3] crypto: s5p: add AES support for Exynos5433

2019-03-06 Thread Guenter Roeck
On 3/5/19 11:51 AM, Krzysztof Kozlowski wrote: On Tue, 5 Mar 2019 at 18:13, Guenter Roeck wrote: On Fri, Feb 22, 2019 at 01:21:44PM +0100, Kamil Konieczny wrote: Add AES crypto HW acceleration for Exynos5433, with the help of SlimSSS IP. Reviewed-by: Krzysztof Kozlowski Signed-off-by

Re: [PATCH v4 3/3] crypto: s5p: add AES support for Exynos5433

2019-03-05 Thread Guenter Roeck
On Fri, Feb 22, 2019 at 01:21:44PM +0100, Kamil Konieczny wrote: > Add AES crypto HW acceleration for Exynos5433, with the help of SlimSSS IP. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Kamil Konieczny > --- > drivers/crypto/s5p-sss.c | 50 >

Re: [v18,3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

2018-07-13 Thread Guenter Roeck
On 07/13/2018 05:20 PM, Logan Gunthorpe wrote: On 13/07/18 05:38 PM, Guenter Roeck wrote: This patch causes a build failure in -next when building ppc:corenet64_smp_defconfig. Thanks for the report. This 64bit IO stuff is a bit of a mess. It looks like your corner case arch and config was

Re: [v18,3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

2018-07-13 Thread Guenter Roeck
Hi, On Fri, Jun 22, 2018 at 01:47:48PM -0600, Logan Gunthorpe wrote: > In order to provide non-atomic functions for io{read|write}64 that will > use readq and writeq when appropriate. We define a number of variants > of these functions in the generic iomap that will do non-atomic > operations on p

Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes

2017-03-06 Thread Guenter Roeck
On 03/06/2017 03:20 PM, James Hogan wrote: Hi Guenter, On Mon, Mar 06, 2017 at 11:13:55AM -0800, Guenter Roeck wrote: Since commit f3ac60671954 ("sched/headers: Move task-stack related APIs from to ") and commit f780d89a0e82 ("sched/headers: Remove from "), various

[PATCH v3] MIPS: Fix build breakage caused by header file changes

2017-03-06 Thread Guenter Roeck
rs. Fixes: f3ac60671954 ("sched/headers: Move task-stack related APIs ...") Fixes: f780d89a0e82 ("sched/headers: Remove from ...") Cc: Ingo Molnar Signed-off-by: Guenter Roeck --- v3: Catch more build errors arch/mips/cavium-octeon/cpu.c | 3 ++- arch/mips/cavi

[PATCH] keys: Use non-conflicting variable name

2015-06-24 Thread Guenter Roeck
in ctype.h. Fixes: b6197b93fa4b ("arm64 : Introduce support for ACPI _CCA object") Cc: Suthikulpanit, Suravee Signed-off-by: Guenter Roeck --- crypto/asymmetric_keys/rsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/asymmetric_keys/rsa.

Re: [PATCH] crypto: jitterentropy - avoid compiler warnings

2015-06-23 Thread Guenter Roeck
On 06/23/2015 10:55 AM, Stephan Mueller wrote: Am Dienstag, 23. Juni 2015, 10:41:03 schrieb Guenter Roeck: Hi Guenter, Geert, On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote: Hi Geert, Guenter, may I ask that you check that the following patch compiles without errors or

Re: [PATCH] crypto: jitterentropy - avoid compiler warnings

2015-06-23 Thread Guenter Roeck
On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote: > Hi Geert, Guenter, > > may I ask that you check that the following patch compiles without errors or > warnings on your systems? > No build failures for all architectures. Guenter -- To unsubscribe from this list: send the line "

Re: [PATCH] crypto: jitterentropy - avoid compiler warnings

2015-06-23 Thread Guenter Roeck
On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote: > Hi Geert, Guenter, > > may I ask that you check that the following patch compiles without errors or > warnings on your systems? > Stephan, I applied your patch on top of the current mainline (which includes the crypto updates fo

Re: [PATCH] crypto: drbg - use pragmas for disabling optimization

2015-06-08 Thread Guenter Roeck
On 06/08/2015 07:08 PM, Stephan Mueller wrote: Hi, I performed measurements of the upper and lower boundary of the minimum and Shannon entropy for the RNG before the patch and after the patch. The values are very similar which demonstrates that the change does not affect the cryptographic charac

Re: randconfig build error with next-20150529, in crypto/jitterentropy.c

2015-06-08 Thread Guenter Roeck
On 06/08/2015 04:33 PM, Stephan Mueller wrote: Am Monday 08 June 2015, 16:30:09 schrieb Guenter Roeck: Hi Guenter, get_cycles is implemented as static inline which executes mfspr(SPR_TTCR). SPR_TTCR is a constant. Normally that information seems to be passed on, but not when get_cycles() is

Re: randconfig build error with next-20150529, in crypto/jitterentropy.c

2015-06-08 Thread Guenter Roeck
On 06/08/2015 03:36 PM, Stephan Mueller wrote: Am Monday 08 June 2015, 12:54:12 schrieb Guenter Roeck: Hi Guenter, Thanks for the note. ... --- openrisc:defconfig: In file included from ./arch/openrisc/include/asm/timex.h:23:0, ... from crypto/jitterentropy.c:52: ./arch

Re: randconfig build error with next-20150529, in crypto/jitterentropy.c

2015-06-08 Thread Guenter Roeck
On Mon, Jun 08, 2015 at 03:21:09PM +0300, Andy Shevchenko wrote: > On Fri, May 29, 2015 at 10:14 PM, Jim Davis wrote: > > Building with the attached random configuration file, > > Hit the very same error against next-20150605. > There are also several failing default configurations. Guenter -

[PATCH -next] crypto: api: Do not access module name directly from module structure

2015-04-25 Thread Guenter Roeck
ove module sig ifdef into accessor function") Cc: Herbert Xu Cc: Rusty Russell Signed-off-by: Guenter Roeck --- Seen in next-20150424. crypto/algapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/algapi.c b/crypto/algapi.c index c63836f4ff64..3103e6a1282

Re: [PATCH -next] crypto: api: Do not access module name directly from module structure

2015-04-25 Thread Guenter Roeck
On Sat, Apr 25, 2015 at 06:38:03AM +0800, Herbert Xu wrote: > On Fri, Apr 24, 2015 at 08:58:03AM -0700, Guenter Roeck wrote: > > 'struct module' is only fully declared if CONFIG_MODULES is configured. > > If not, the build fails with > > > > crypto/algapi.c:

Re: linux-next: Tree for Mar 11 (powerpc build failure due to vmx crypto code)

2015-03-11 Thread Guenter Roeck
On 03/11/2015 08:28 PM, Herbert Xu wrote: On Wed, Mar 11, 2015 at 07:43:22PM -0700, Guenter Roeck wrote: It looks like the perl scripts do run - I see the .S files, and I do see .o files created. But I still get the error. Looking into the object files, I see $ nm vmx-crypto.o | grep

Re: linux-next: Tree for Mar 11 (powerpc build failure due to vmx crypto code)

2015-03-11 Thread Guenter Roeck
On 03/11/2015 06:23 PM, Herbert Xu wrote: On Wed, Mar 11, 2015 at 08:47:17AM -0700, Guenter Roeck wrote: Building powerpc:allmodconfig: ERROR: ".aes_p8_cbc_encrypt" [drivers/crypto/vmx/vmx-crypto.ko] undefined! ERROR: ".aes_p8_set_encrypt_key" [drivers/crypto/vmx/vmx-