Re: [PATCH] crypto: geode-aes - convert to skcipher API and make thread-safe

2019-10-20 Thread Gert Robben
Op 11-10-2019 om 06:51 schreef Eric Biggers: From: Eric Biggers The geode AES driver is heavily broken because it stores per-request state in the transform context. So it will crash or produce the wrong result if used by any of the many places in the kernel that issue concurrent requests for t

Re: [PATCH v2] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-05 Thread Gert Robben
Op 05-10-2019 om 11:11 schreef Ard Biesheuvel: Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated the generic CBC template wrapper from a blkcipher to a skcipher algo, to get away from the deprecated blkcipher interface. However, as a side effect, drivers that instantiate CBC t

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-04 Thread Gert Robben
Op 04-10-2019 om 21:37 schreef Eric Biggers: On Fri, Oct 04, 2019 at 03:29:33PM +0200, Gert Robben wrote: Op 04-10-2019 om 08:16 schreef Ard Biesheuvel: On Thu, 3 Oct 2019 at 23:26, Gert Robben wrote: Op 03-10-2019 om 15:39 schreef Ard Biesheuvel: Commit 79c65d179a40e145 ("crypto

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-04 Thread Gert Robben
Op 04-10-2019 om 08:16 schreef Ard Biesheuvel: On Thu, 3 Oct 2019 at 23:26, Gert Robben wrote: Op 03-10-2019 om 15:39 schreef Ard Biesheuvel: Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated the generic CBC template wrapper from a blkcipher to a skcipher algo, t

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-03 Thread Gert Robben
ntiate CBC transforms using the blkcipher as a fallback no longer work, since skciphers can wrap blkciphers but not the other way around. This broke the geode-aes driver. So let's fix it by moving to the sync skcipher interface when allocating the fallback. Cc: Gert Robben Cc: Jelle de Jong

PROBLEM: geode-aes not working with skcipher cbc

2018-12-09 Thread Gert Robben
Hi, I try to use geode-aes/CRYPTO_DEV_GEODE, but it gives errors in dmesg and openssl (see below), and doesn't function. I found that the change "crypto: cbc - Convert to skcipher" gives the problem: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/crypto/cbc.c?id=79c